Closed gbalabasquer closed 2 years ago
can we remove the substance of these old vest tests: https://github.com/makerdao/spells-mainnet/pull/246/files#diff-cd597c47b9a6e2bae57aab767ee9e3d5bb3d8edeb3a2248b4519b9af791cb468R422
1 small comment from my side: We should probably comment out the content of the collateral onboarding function (as we usually do).
Ah yes I forgot to do it for mainnet spell, good catch. Will change it now. This is btw why I don't like much that separation. It is easy to forget what happens in that file.
can we remove the substance of these old vest tests: https://github.com/makerdao/spells-mainnet/pull/246/files#diff-cd597c47b9a6e2bae57aab767ee9e3d5bb3d8edeb3a2248b4519b9af791cb468R422
Not really sure if this link works as expected but I think I understood what you meant and made the changes.
- Have we confirmed with GovAlpha that Office Hours is ON for this spell?
Well in theory is them confirming with us. But yeah it is not in the doc summary, so just pinged LFW. Good catch!
Spell code matches deployed spell. Tests pass, good to publish from my side.
Checked post deployment and
let me know when archive is done and i can provide another review, but should be good to publish with deployed spell
@talbaneth @iamchrissmith archive done!
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR