Closed godsflaw closed 2 years ago
Spell looks good except for the copy hash.
We could remove the spell action and just use the custom DssExec. It would be kind of cool and would save gas, but is not necessary.
Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAAVEDirectBarChange() (gas: 721281)
[PASS] testCastCost() (gas: 390844)
[PASS] testFailTooEarly() (gas: 12550)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12594)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testOnTime() (gas: 387233)
[PASS] testSpellIsCast_GENERAL() (gas: 22187701)
[PASS] test_auth() (gas: 9223336852494766489)
[PASS] test_auth_in_sources() (gas: 9223336852484704559)
[PASS] test_bytecode_matches() (gas: 1130857)
[PASS] test_chainlog_values() (gas: 5448349)
[PASS] test_chainlog_version_bump() (gas: 2813999)
[PASS] test_nextCastTime() (gas: 368090)
[PASS] test_use_eta() (gas: 366900)
Test result: ok. 15 passed; 0 failed; finished in 8.26s
Deployed spell: 0x76b686379234C90b2d9d4A9412A359783273f6b2
etherscan: https://etherscan.io/address/0x76b686379234C90b2d9d4A9412A359783273f6b2#code
Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAAVEDirectBarChange() (gas: 721281)
[PASS] testCastCost() (gas: 390844)
[PASS] testFailTooEarly() (gas: 12550)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12594)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testOnTime() (gas: 387233)
[PASS] testSpellIsCast_GENERAL() (gas: 23305420)
[PASS] test_auth() (gas: 9223336852494766489)
[PASS] test_auth_in_sources() (gas: 9223336852484704559)
[PASS] test_bytecode_matches() (gas: 1130857)
[PASS] test_chainlog_values() (gas: 5448349)
[PASS] test_chainlog_version_bump() (gas: 2813999)
[PASS] test_nextCastTime() (gas: 368090)
[PASS] test_use_eta() (gas: 366900)
Test result: ok. 15 passed; 0 failed; finished in 8.60s
Urgent Weekly Executive 2022-06-15
bar
to 0 for the AAVE D3MContribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR