PE-1013-20220615: Urgent Weekly Executive 2022-06-15

[godsflaw]

Urgent Weekly Executive 2022-06-15

• calls the D3M mom to set bar to 0 for the AAVE D3M

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier override
• [x] Verify expiration (30 days unless otherwise specified)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[julienmartinlevrai]

Spell looks good except for the copy hash.

We could remove the spell action and just use the custom DssExec. It would be kind of cool and would save gas, but is not necessary.

[godsflaw]

Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAAVEDirectBarChange() (gas: 721281)
[PASS] testCastCost() (gas: 390844)
[PASS] testFailTooEarly() (gas: 12550)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12594)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testOnTime() (gas: 387233)
[PASS] testSpellIsCast_GENERAL() (gas: 22187701)
[PASS] test_auth() (gas: 9223336852494766489)
[PASS] test_auth_in_sources() (gas: 9223336852484704559)
[PASS] test_bytecode_matches() (gas: 1130857)
[PASS] test_chainlog_values() (gas: 5448349)
[PASS] test_chainlog_version_bump() (gas: 2813999)
[PASS] test_nextCastTime() (gas: 368090)
[PASS] test_use_eta() (gas: 366900)
Test result: ok. 15 passed; 0 failed; finished in 8.26s

[godsflaw]

Deployed spell: 0x76b686379234C90b2d9d4A9412A359783273f6b2 etherscan: https://etherscan.io/address/0x76b686379234C90b2d9d4A9412A359783273f6b2#code

Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAAVEDirectBarChange() (gas: 721281)
[PASS] testCastCost() (gas: 390844)
[PASS] testFailTooEarly() (gas: 12550)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12594)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testOnTime() (gas: 387233)
[PASS] testSpellIsCast_GENERAL() (gas: 23305420)
[PASS] test_auth() (gas: 9223336852494766489)
[PASS] test_auth_in_sources() (gas: 9223336852484704559)
[PASS] test_bytecode_matches() (gas: 1130857)
[PASS] test_chainlog_values() (gas: 5448349)
[PASS] test_chainlog_version_bump() (gas: 2813999)
[PASS] test_nextCastTime() (gas: 368090)
[PASS] test_use_eta() (gas: 366900)
Test result: ok. 15 passed; 0 failed; finished in 8.60s