Closed godsflaw closed 2 years ago
Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 427848)
[PASS] testFailTooEarly() (gas: 12640)
[PASS] testFailTooLate() (gas: 12639)
[PASS] testFailWrongDay() (gas: 12684)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testMKRPayment() (gas: 448212)
[PASS] testOnTime() (gas: 424237)
[PASS] testSpellIsCast_GENERAL() (gas: 22279607)
[PASS] test_auth() (gas: 9223336852494780258)
[PASS] test_auth_in_sources() (gas: 9223336852484718328)
[PASS] test_bytecode_matches() (gas: 1185506)
[PASS] test_chainlog_values() (gas: 5487353)
[PASS] test_chainlog_version_bump() (gas: 2853003)
[PASS] test_nextCastTime() (gas: 338990)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 15 passed; 0 failed; finished in 8.08s
Please review/merge https://github.com/makerdao/spells-mainnet/pull/253
Please review/merge #253
I thought we were merging this into next week's spell? If not, I can review and push this this week.
Please review/merge #253
I thought we were merging this into next week's spell? If not, I can review and push this this week.
Good point, maybe it makes sense to first put it in this week’s Görli spell. All these spells at the same time can get a bit confusing.
I thought we were merging this into next week's spell? If not, I can review and push this this week.
This was is separate from adding the Core address to the on-chain changelog. It does apply to Goerli however, so I think it's probably best to send it there first.
Deployed spell: 0xa963cc9e4F1Dc187d561830ee299040C582e2BfC
etherscan: https://etherscan.io/address/0xa963cc9e4F1Dc187d561830ee299040C582e2BfC#code
Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 427848)
[PASS] testFailTooEarly() (gas: 12640)
[PASS] testFailTooLate() (gas: 12639)
[PASS] testFailWrongDay() (gas: 12684)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testMKRPayment() (gas: 448212)
[PASS] testOnTime() (gas: 424237)
[PASS] testSpellIsCast_GENERAL() (gas: 23478463)
[PASS] test_auth() (gas: 9223336852494780258)
[PASS] test_auth_in_sources() (gas: 9223336852484718328)
[PASS] test_bytecode_matches() (gas: 1198175)
[PASS] test_chainlog_values() (gas: 5487353)
[PASS] test_chainlog_version_bump() (gas: 2853003)
[PASS] test_nextCastTime() (gas: 338990)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 15 passed; 0 failed; finished in 221.10s
Weekly Executive 2022-06-22
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR