godsflaw commented 2 years ago

Weekly Executive 2022-06-22

500 MKR payout from treasury to DECO
80 MKR payout from treasury to RWF

Contribution Checklist

[x] PR title starts with (PE-<TICKET_NUMBER>)
[x] Code approved
[x] Tests approved
[x] CI Tests pass

Checklist

[x] Every contract variable/method declared as public/external private/internal
[x] Consider if this PR needs the officeHours modifier override
[x] Verify expiration (30 days unless otherwise specified)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[x] Notify any external teams affected by the spell so they have the opportunity to review
[x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[x] Verify mainnet contract on etherscan
[x] Change test to use mainnet spell address and deploy timestamp
[x] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

godsflaw commented 2 years ago

Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 427848)
[PASS] testFailTooEarly() (gas: 12640)
[PASS] testFailTooLate() (gas: 12639)
[PASS] testFailWrongDay() (gas: 12684)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testMKRPayment() (gas: 448212)
[PASS] testOnTime() (gas: 424237)
[PASS] testSpellIsCast_GENERAL() (gas: 22279607)
[PASS] test_auth() (gas: 9223336852494780258)
[PASS] test_auth_in_sources() (gas: 9223336852484718328)
[PASS] test_bytecode_matches() (gas: 1185506)
[PASS] test_chainlog_values() (gas: 5487353)
[PASS] test_chainlog_version_bump() (gas: 2853003)
[PASS] test_nextCastTime() (gas: 338990)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 15 passed; 0 failed; finished in 8.08s

brianmcmichael commented 2 years ago

Please review/merge https://github.com/makerdao/spells-mainnet/pull/253

godsflaw commented 2 years ago

Please review/merge #253

I thought we were merging this into next week's spell? If not, I can review and push this this week.

julienmartinlevrai commented 2 years ago

Please review/merge #253

I thought we were merging this into next week's spell? If not, I can review and push this this week.

Good point, maybe it makes sense to first put it in this week’s Görli spell. All these spells at the same time can get a bit confusing.

brianmcmichael commented 2 years ago

I thought we were merging this into next week's spell? If not, I can review and push this this week.

This was is separate from adding the Core address to the on-chain changelog. It does apply to Goerli however, so I think it's probably best to send it there first.

godsflaw commented 2 years ago

Deployed spell: 0xa963cc9e4F1Dc187d561830ee299040C582e2BfC etherscan: https://etherscan.io/address/0xa963cc9e4F1Dc187d561830ee299040C582e2BfC#code

Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 427848)
[PASS] testFailTooEarly() (gas: 12640)
[PASS] testFailTooLate() (gas: 12639)
[PASS] testFailWrongDay() (gas: 12684)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testMKRPayment() (gas: 448212)
[PASS] testOnTime() (gas: 424237)
[PASS] testSpellIsCast_GENERAL() (gas: 23478463)
[PASS] test_auth() (gas: 9223336852494780258)
[PASS] test_auth_in_sources() (gas: 9223336852484718328)
[PASS] test_bytecode_matches() (gas: 1198175)
[PASS] test_chainlog_values() (gas: 5487353)
[PASS] test_chainlog_version_bump() (gas: 2853003)
[PASS] test_nextCastTime() (gas: 338990)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 15 passed; 0 failed; finished in 221.10s

makerdao / spells-mainnet

PE-1013-20220622: Weekly Executive 2022-06-22 #256

Weekly Executive 2022-06-22

Contribution Checklist

Checklist