PE-1032 - July 6th Executive Spell

[talbaneth]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[talbaneth]

Still missing the govalph doc and hash.

[naszam]

Test PASS (27376cc):

dapp-test: rpc block: 15083244
Running 16 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 4639)
[PASS] test_auth_in_sources() (gas: 281473905067710)
[PASS] test_use_eta() (gas: 327455)
[PASS] testOnTime() (gas: 1673882)
[PASS] testPayments() (gas: 1740613)
[PASS] testVestDAI() (gas: 2029694)
[PASS] test_nextCastTime() (gas: 328400)
[PASS] test_chainlog_values() (gas: 6110731)
[PASS] testFailTooEarly() (gas: 3594)
[PASS] test_bytecode_matches() (gas: 1750733)
[PASS] test_chainlog_version_bump() (gas: 4100304)
[PASS] test_auth() (gas: 281473915132564)
[PASS] testSpellIsCast_GENERAL() (gas: 21989538)
[PASS] testFailWrongDay() (gas: 3616)
[PASS] testCastCost() (gas: 1676188)
[PASS] testFailTooLate() (gas: 3549)

Running 1 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1847074)

[julienmartinlevrai]

• hash matches
• address change matches copy
• tests with undeployed spell pass

Good to deploy

[julienmartinlevrai]

• Contract verified on Etherscan
• Verified code matches repo
• dss-exec-library address matches repo
• deployed timestamp matches tx

[naszam]

Test PASS (0a37d50 at deployed spell block n. 15083979):

dapp-test: rpc block: 15083979
Running 16 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testFail_notScheduled() (gas: 12139)
[PASS] test_auth_in_sources() (gas: 281473905069742)
[PASS] test_use_eta() (gas: 336955)
[PASS] testOnTime() (gas: 1685882)
[PASS] testPayments() (gas: 1752613)
[PASS] testVestDAI() (gas: 2041694)
[PASS] test_nextCastTime() (gas: 337900)
[PASS] test_chainlog_values() (gas: 6126731)
[PASS] testFailTooEarly() (gas: 8594)
[PASS] test_bytecode_matches() (gas: 1764733)
[PASS] test_chainlog_version_bump() (gas: 4116304)
[PASS] test_auth() (gas: 281473915134595)
[PASS] testSpellIsCast_GENERAL() (gas: 23750227)
[PASS] testFailWrongDay() (gas: 8616)
[PASS] testCastCost() (gas: 1688188)
[PASS] testFailTooLate() (gas: 8549)

Running 1 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1859074)