PE-1039: Onboard RWA008 and RWA009

[hbarcelos]

Description

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier override
• [x] Verify expiration (30 days unless otherwise specified)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[hbarcelos]

* proof that `0x508D982e13263Fc8e1b5A4E6bf59b335202e36b4` is owned by the correct party

This is the transaction that Genesis submitted to prove they own this address: https://etherscan.io/tx/0xfecb71d9fa27e4b7b78fe31d0b7778a005ef96412d7d702371d334cab0092f1d

[gbalabasquer]

• Office hours on is correct
• 30 days expiration is correct

• Hash is still missing

• RWA_TOKEN_FAB (0x2B3a4c18705e99bC29b22222dA7E10b643658552) deployed code matches repo, compiler and optimization flags are ok

• RWA008 (0xb9737098b50d7c536b6416dAeB32879444F59fCA) was created from correct fab and 1 WAD token was sent to operator
• MCD_JOIN_RWA008_A (0x56eDD5067d89D4E65Bf956c49eAF054e6Ff0b262) was created with the known fab and the creation params were sent correctly
• RWA008_A_URN (0x495215cabc630830071F80263a908E8826a66121) deployed code matches repo, compiler and optimization flags are ok. Creation params ok. Rely Pause proxy, deny creator is ok.
• RWA008_A_URN_CLOSE_HELPER (0xCfc4043675EE82EEAe63C90D6eb3aB2dcf833431) deployed code matches repo, compiler and optimization flags are ok.
• RWA008_A_INPUT_CONDUIT (0xa397a23dDA051186F202C67148c90683c413383C) deployed code matches repo, compiler and optimization flags are ok. Creation params ok. Rely Pause proxy, deny creator is ok.
• RWA008_A_OUTPUT_CONDUIT (0x21CF5Ad1311788D762f9035829f81B9f54610F0C) deployed code matches repo, compiler and optimization flags are ok. Creation params ok. Rely Pause proxy, deny creator is ok.
• RWA008_A_OPERATOR (0x03f1A14A5b31e2f1751b6db368451dFCEA5A0439) It matches the address in the doc, however it is not confirmed, then it has been added in a conditional way where it can't really harm. Whenever is properly confirmed a new spell will add the missing permission to make it functional.
• RWA008_A_MATE (0xb9444802F0831A3EB9f90E24EFe5FfA20138d684) It matches the address in the doc.
• RWA008_DOC This should be approved by the reponsible parts of the agreement
• Risk parameters match the doc

• Collateral onboarding process looks good. RWA008_A_OUTPUT_CONDUIT is not hoping the RWA008_A_OPERATOR as there isn't formal verification that address is owned by SocGen, so this permission will be set in a next spell. Without it, effectively any DAI drawn can't leave the RWA008_A_OUTPUT_CONDUIT contract.

• RWA009 (0x8b9734bbaA628bFC0c9f323ba08Ed184e5b88Da2) was created from correct fab and 1 WAD token was sent to pause proxy (operator)
• MCD_JOIN_RWA009_A (0xEe0FC514280f09083a32AE906cCbD2FAc4c680FA) was created with the known fab and the creation params were sent correctly
• RWA009_A_URN (0x1818EE501cd28e01E058E7C283E178E9e04a1e79) deployed code matches repo, compiler and optimization flags are ok. Creation params ok. Rely Pause proxy, deny creator is ok.
• RWA009_A_JAR (0x6C6d4Be2223B5d202263515351034861dD9aFdb6) deployed code matches repo, compiler and optimization flags are ok.
• RWA009_A_OUTPUT_CONDUIT (0x508D982e13263Fc8e1b5A4E6bf59b335202e36b4) It matches the address in the doc.
• RWA009_DOC This should be approved by the reponsible parts of the agreement
• Risk parameters match the doc.
• Collateral onboarding process looks good.

• Initial draw generation of 25M DAI correctly done.

• Tests look good and are passing:

  
  Running 1 test for src/test/starknet.t.sol:StarknetTests
  [PASS] testStarknet() (gas: 4430041)
  Test result: ok. 1 passed; 0 failed; finished in 447.42s

Running 34 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testCastCost() (gas: 4237916) [PASS] testFailRWA008_INTEGRATION_CURE_BEFORE_TELL() (gas: 4368916) [PASS] testFailRWA009_INTEGRATION_CURE_BEFORE_TELL() (gas: 4368939) [PASS] testFailTooEarly() (gas: 401779) [PASS] testFailTooLate() (gas: 401896) [PASS] testFailWrongDay() (gas: 401781) [PASS] testFail_notScheduled() (gas: 14191) [PASS] testNewChainlogValues() (gas: 4383417) [PASS] testNewIlkRegistryValues() (gas: 4298618) [PASS] testOnTime() (gas: 4234372) [PASS] testRWA008_INTEGRATION_BUMP() (gas: 4258018) [PASS] testRWA008_INTEGRATION_TELL() (gas: 4254888) [PASS] testRWA008_INTEGRATION_TELL_CULL() (gas: 4275026) [PASS] testRWA008_INTEGRATION_TELL_CURE_GOOD() (gas: 4254244) [PASS] testRWA008_MIP21_COMPONENTS_PERMISSIONS() (gas: 4261993) [PASS] testRWA008_OPERATOR_LOCK_DRAW_CAGE() (gas: 4980853) [PASS] testRWA008_OPERATOR_LOCK_DRAW_CONDUITS_WIPE_FREE() (gas: 4646743) [PASS] testRWA008_OPERATOR_OWNS_RWA008_TOKEN_BEFORE_SPELL() (gas: 10010) [PASS] testRWA009_INTEGRATION_BUMP() (gas: 4258057) [PASS] testRWA009_INTEGRATION_TELL() (gas: 4254954) [PASS] testRWA009_INTEGRATION_TELL_CULL() (gas: 4236966) [PASS] testRWA009_INTEGRATION_TELL_CURE_GOOD() (gas: 4254286) [PASS] testRWA009_MIP21_COMPONENTS_PERMISSIONS() (gas: 4246015) [PASS] testRWA009_OPERATOR_LOCK_DRAW_CAGE() (gas: 4778428) [PASS] testRWA009_PAUSE_PROXY_OWNS_RWA009_TOKEN_BEFORE_SPELL() (gas: 15460) [PASS] testRWA009_SPELL_OPERATOR_LOCK_DRAW_WIPE_FREE() (gas: 4351277) [PASS] testSpellIsCast_GENERAL() (gas: 29708334) [PASS] test_auth() (gas: 9223336852496142139) [PASS] test_auth_in_sources() (gas: 9223336852484715866) [PASS] test_bytecode_matches() (gas: 4615242) [PASS] test_chainlog_values() (gas: 9456231) [PASS] test_chainlog_version_bump() (gas: 6068502) [PASS] test_nextCastTime() (gas: 404902) [PASS] test_use_eta() (gas: 337968)