PE-1047: Wednesday August 3rd 2022 Executive Spell

[julienmartinlevrai]

Description

Contribution Checklist

• [x] PR title starts with (PE-<TICKET_NUMBER>)
• [x] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier override
• [x] Verify expiration (30 days unless otherwise specified)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[gbalabasquer]

@julienmartinlevrai we should clean up DssSpellCollateral.sol file. This is another negative side of having a different file, we just missed to clean it up as not easy to detect we are leaving code there. Edit: And I know we are not importing it but better to clean it so it doesn't remain that code in the archive of this week.

[julienmartinlevrai]

@julienmartinlevrai we should clean up DssSpellCollateral.sol file. This is another negative side of having a different file, we just missed to clean it up as not easy to detect we are leaving code there. Edit: And I know we are not importing it but better to clean it so it doesn't remain that code in the archive of this week.

Done. I think we should let CES manage that file however they want.

[brianmcmichael]

So far so good. Just waiting on copy hash and manager address (if GovAlpha adds it)

[gbalabasquer]

• Office hours off is correct
• 30 days expiration is correct
• Hash still missing
• Extra 25M DAI being correctly minted for HVB (RWA009-A) is ok
• Yanking id: 8 from MCD_DAI_VEST correctly done
• New vesting matches correctly the doc (still pending to define if there will be a mgr)
• Tests look good
• Tests are passing:

  
  Running 1 test for src/test/starknet.t.sol:StarknetTests
  [PASS] testStarknet() (gas: 827175)
  Test result: ok. 1 passed; 0 failed; finished in 375.50s

Running 16 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testCastCost() (gas: 640377) [PASS] testFailTooEarly() (gas: 12706) [PASS] testFailTooLate() (gas: 12683) [PASS] testFailWrongDay() (gas: 12728) [PASS] testFail_notScheduled() (gas: 14139) [PASS] testOnTime() (gas: 631483) [PASS] testSpellIsCast_GENERAL() (gas: 22789451) [PASS] testVestDAI() (gas: 741317) [PASS] test_RWA009Draw() (gas: 644578) [PASS] test_auth() (gas: 9223336852496191121) [PASS] test_auth_in_sources() (gas: 9223336852484764849) [PASS] test_bytecode_matches() (gas: 1252056) [PASS] test_chainlog_values() (gas: 5919298) [PASS] test_chainlog_version_bump() (gas: 3166363) [PASS] test_nextCastTime() (gas: 338945) [PASS] test_use_eta() (gas: 337755) Test result: ok. 16 passed; 0 failed; finished in 1284.97s

Just waiting the hash and comment are added and get defined if the new vesting will go with a manager.
The rest looks good.

[gbalabasquer]

• Hash is correct
• Missing to add mgr address to the new vest or remove comment if not happening
• We are missing a test for checking the vest id 8 is correctly yanked.

[julienmartinlevrai]

• Hash is correct
• Missing to add mgr address to the new vest or remove comment if not happening
• We are missing a test for checking the vest id 8 is correctly yanked.

@gbalabasquer done

[gbalabasquer]

Changes look good. As soon as my local tests finish running will give the approval for deploying.

[julienmartinlevrai]

spell deployed at 0x6682133cCFbc8f87da51904d95241d243f7260Bf