makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

107 stars 43 forks source link

PE-1050 August 10, 2022 Executive Spell #266

Closed iamchrissmith closed 1 year ago

iamchrissmith commented 1 year ago

Description

Contribution Checklist

[ ] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier override
[ ] Verify expiration (30 days unless otherwise specified)
[ ] Verify hash in the description matches here
[ ] Validate all addresses used are in changelog or known
[ ] Notify any external teams affected by the spell so they have the opportunity to review
[ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

iamchrissmith commented 1 year ago

@hbarcelos tagging you for RWA payments and hope. (Spell still draft as we're waiting on content and other confirmations, so just FYI at this point)

hbarcelos commented 1 year ago

@hbarcelos tagging you for RWA payments and hope. (Spell still draft as we're waiting on content and other confirmations, so just FYI at this point)

I've made a very quick review and got some low-hanging fruits. Once you mark this as ready for review I'll do a more thorough one.

iamchrissmith commented 1 year ago

deployed and archived: https://etherscan.io/address/0x6773C82BbB9f0e4C73eecBC26aD3f8018580bEF9

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1731181)
Test result: ok. 1 passed; 0 failed; finished in 279.85ms

Running 17 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 1544383)
[PASS] testFailTooEarly() (gas: 402019)
[PASS] testFailTooLate() (gas: 402029)
[PASS] testFailWrongDay() (gas: 401959)
[PASS] testFail_notScheduled() (gas: 14147)
[PASS] testOnTime() (gas: 1535489)
[PASS] testPayments() (gas: 1636529)
[PASS] testRWA008_MIP21_UPDATED_PERMISSIONS() (gas: 1546038)
[PASS] testSpellIsCast_GENERAL() (gas: 26358235)
[PASS] test_RWA009Draw() (gas: 1556790)
[PASS] test_auth() (gas: 9223336852496976109)
[PASS] test_auth_in_sources() (gas: 9223336852484579325)
[PASS] test_bytecode_matches() (gas: 2023294)
[PASS] test_chainlog_values() (gas: 6813282)
[PASS] test_chainlog_version_bump() (gas: 4060347)
[PASS] test_nextCastTime() (gas: 404969)
[PASS] test_use_eta() (gas: 337923)
Test result: ok. 17 passed; 0 failed; finished in 2.33s