PE-1045

[hexonaut]

Description

PLEASE NOTE THE TESTS ONLY WORK IN FOUNDRY / FORGE.

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[hexonaut]

This is ready for review except for hash.

[hexonaut]

Ok this is ready for final review for deploy.

[talbaneth]

Unless we want to wait for goerli manual testing this LGTM to publish and archive.

Spell verified, license ok, compiler and flags ok, code matches repo, correct execlib address used. tests pass:

Running 1 test for src/test/starknet.t.sol:StarknetTests [PASS] testStarknet() (gas: 2888546) Test result: ok. 1 passed; 0 failed; finished in 11.56s

Running 19 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testCastCost() (gas: 2682535) [PASS] testCureTeleport() (gas: 4432575) [PASS] testFailTooEarly() (gas: 411191) [PASS] testFailTooLate() (gas: 411336) [PASS] testFailWrongDay() (gas: 411222) [PASS] testFail_notScheduled() (gas: 14147) [PASS] testNewChainlogValues() (gas: 2849386) [PASS] testNewIlkRegistryValues() (gas: 2706013) [PASS] testOnTime() (gas: 2678749) [PASS] testRWA009_SPELL_DRAW() (gas: 2702842) [PASS] testSpellIsCast_GENERAL() (gas: 32758648) [PASS] testTeleportFW() (gas: 4707111) [PASS] test_auth() (gas: 9223336852500860092) [PASS] test_auth_in_sources() (gas: 9223336852485195825) [PASS] test_bytecode_matches() (gas: 3846848) [PASS] test_chainlog_values() (gas: 8517564) [PASS] test_chainlog_version_bump() (gas: 4759365) [PASS] test_nextCastTime() (gas: 420135) [PASS] test_use_eta() (gas: 347239) Test result: ok. 19 passed; 0 failed; finished in 37.49s

[hexonaut]

Archive matches. Good to merge.