makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

120 stars 47 forks source link

PE-1064 #270

Closed talbaneth closed 2 years ago

talbaneth commented 2 years ago

Description

Contribution Checklist

[x] PR title starts with (PE-<TICKET_NUMBER>)
[x] Code approved
[x] Tests approved
[ ] CI Tests pass

Checklist

[x] Every contract variable/method declared as public/external private/internal
[x] Consider if this PR needs the officeHours modifier override
[x] Verify expiration (30 days unless otherwise specified)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[x] Notify any external teams affected by the spell so they have the opportunity to review
[x] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[x] Verify mainnet contract on etherscan
[x] Change test to use mainnet spell address and deploy timestamp
[x] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

talbaneth commented 2 years ago

Ready for review apart from the missing doc hash.

talbaneth commented 2 years ago

Gov sheet was updated, as growth is a vest stream. Will update the spell as well.

The-Arbiter commented 2 years ago

✅ Diff is fine ✅ Address is fine ✅ Timestamp 1662537477 matches ✅ Libs match GitHub content ✅ Tests pass as at 1ef36da

Pass

talbaneth commented 2 years ago

@The-Arbiter @hexonaut @naszam awaiting merge approvals.