makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

107 stars 43 forks source link

PE-1073: 2022-09-14 MakerDAO Executive Spell #272

Closed godsflaw closed 1 year ago

godsflaw commented 1 year ago

Description

2022-09-14 MakerDAO Executive Spell

Contribution Checklist

[x] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[x] CI Tests pass

Checklist

[x] Every contract variable/method declared as public/external private/internal
[x] Consider if this PR needs the officeHours modifier override
[x] Verify expiration (30 days unless otherwise specified)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[x] Notify any external teams affected by the spell so they have the opportunity to review
[ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

godsflaw commented 1 year ago

The make deploy changes will error if you're on the wrong network

$ make deploy
./scripts/deploy.sh
Please set a mainnet ETH_RPC_UR