makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells
GNU Affero General Public License v3.0
107 stars 43 forks source link

PE-1084: 2022-09-28 Executive Spell #273

Closed naszam closed 1 year ago

naszam commented 1 year ago

Description

Contribution Checklist

Checklist

The-Arbiter commented 1 year ago

PE-1084 Review

✅ Spell Actions OK:

✅ Office hours is off ✅ Addresses match the doc here ✅ Exec hash OK ✅ 30 days expiry ✅ Current PROXY_ACTIONS_END_CROPPER address is 0xAa61752a5Abf86A527A09546F23FE8bCB8fAB2C4 (valid), changing to 0x38f7C166B5B22906f04D8471E241151BA45d97Af (also valid). ✅ Starknet (external contract) call is documented and address is derived from chainlog call, action flow looks safe. ✅ Chainlog version has been updated (patch) - not sure if changing PROXY_ACTIONS_END_CROPPER is breaking... edit: this has been discussed and is OK ✅ Tests OK

Pass