Closed naszam closed 1 year ago
PE-1084 Review
✅ Spell Actions OK:
✅ Office hours is off ✅ Addresses match the doc here ✅ Exec hash OK ✅ 30 days expiry ✅ Current PROXY_ACTIONS_END_CROPPER address is 0xAa61752a5Abf86A527A09546F23FE8bCB8fAB2C4 (valid), changing to 0x38f7C166B5B22906f04D8471E241151BA45d97Af (also valid). ✅ Starknet (external contract) call is documented and address is derived from chainlog call, action flow looks safe. ✅ Chainlog version has been updated (patch) - not sure if changing PROXY_ACTIONS_END_CROPPER is breaking... edit: this has been discussed and is OK ✅ Tests OK
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR