makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

107 stars 43 forks source link

PE-1095 #275

Closed hexonaut closed 1 year ago

hexonaut commented 1 year ago

Description

Contribution Checklist

[ ] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier override
[ ] Verify expiration (30 days unless otherwise specified)
[ ] Verify hash in the description matches here
[ ] Validate all addresses used are in changelog or known
[ ] Notify any external teams affected by the spell so they have the opportunity to review
[ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

hexonaut commented 1 year ago

Ok this is ready for review. Ignore the failing tests as they will resolve once the previous spell is executed tomorrow.

nduchak commented 1 year ago

I mistakenly add draw of 1mm into the spell, draw should be done by Monetalis directly. I already fix the Goerli spell. Will push changes for mainnet in a few minutes(waiting for tests)

Actually it's wasn't me

hexonaut commented 1 year ago

I mistakenly add draw of 1mm into the spell, draw should be done by Monetalis directly. I already fix the Goerli spell. Will push changes for mainnet in a few minutes(waiting for tests)

Actually it's wasn't me

It was me. I've reverted.

nduchak commented 1 year ago

Fixed all comments

julienmartinlevrai commented 1 year ago

let’s add our new depolyer, 0xC1E6d8136441FC66612Df3584007f7CB68765e5D, to addresses_deployers