PE-1098: 2022-10-12 Executive

[The-Arbiter]

Spell Crafter Mainnet Workflow PE-1098

Steps:

• [x] Create Branch PE-<kanban ticket issue number> Using old name for consistency
  • [x] Note: for now current pattern is to use the same ticket issue number as per spells-goerli (this could be revised)
• [x] Pull Locally and Checkout to Branch
• [x] Cleanup Previous Spell's Actions in DssSpell.sol (diffcheck with Goerli)
  • [x] Check Previous Spells in the archive Folder for Cleanup Patterns
• [x] Cleanup Previous Spell's Onboarding Actions in DssSpellCollateral.sol
  • [ ] Check Previous Spells in the archive Folder for Cleanup Patterns
• [x] Cleanup Base Tests in config.sol (under test folder in src)
  • [x] Set deployed_spell to address(0)
  • [x] Set deployed_spell_created to 0
• [x] Cleanup Specific Tests in DssSpell.t.sol
  • [x] Check Previous Spells in the archive Folder for Cleanup Patterns
  • [x] Disable Specific Tests IF Not Used (eg. testCollateralIntegrations, Changelog, IlkRegistry, ...)
    • [x] Remove Specific Part
    • [x] Keep Setup
    • [x] Disable by setting visibility to private
    • [x] Add Commented Notes
      • [x] eg. // Insert new collateral integration tests here I looked at how the last 5 or so spells did it and copied that
• [x] Add Spell Actions as per GovAlpha Spell Content Sheet - Polls
  • [x] Polls starts on Monday and ends usually on Thursday
    • [x] Check Polls Details and Links (Thread, Risk, ...)
  • [x] Check on new-spells discord channel when Exec Doc is ready
  • [x] Pragma
    • [x] Current Solc Version 0.6.12
  • [x] Office hours off
  • [x] Use DssExecLib Functions
    • [x] Check DssExecLib Address Used in Spell (Makefile & test-dssspell.sh) Matches Latest Release Tag on dss-exec-lib repo
  • [x] Check Previous Spells for Common Patterns
• [x] Adjust Sytem Values, Collateral Values in DssSpell.t.base.sol (diffcheck with goerli) This should say config.sol? I did it there
• [x] Run Tests make test or make test match=<test_name> for specific tests
  • [x] Make sure to use latest dapptools release Foundry was used
• [x] Debug via make test-forge (for quicker testing)
• [x] Test PASS via make test + Good Coverage I used forge
• [x] Commit & Push
• [x] Open Draft PR on spells-mainnet titled "PE-: YYYY-MM-DD Executive"
• [x] Assign to yourself
• [x] Open PR & Add Reviewers
• [x] Iterate till Polls are Ended and Exec Copy is Merged
• [x] Confirm Exec Doc Actions
• [x] Make sure CI PASS
• [x] Add Exec Hash
  • [x] Check when Copy is Merged
  • [x] Reference either Latest Change or Merge Commit
• [x] Wait for at least two Approvals with local tests to Deploy

[The-Arbiter]

Note: I have edited the address list to rename FRONTIER_RESEARCH to FRONTIERRESEARCH, add LBSBLOCKCHAIN, ONESTONE and PVI.

[The-Arbiter]

Confirmed tests pass. Ready for review.

[ghost]

Extremely minor point but it is "PVL" not "PVI" - admittedly in lower case it is difficult to tell the difference

[The-Arbiter]

Extremely minor point but it is "PVL" not "PVI" - admittedly in lower case it is difficult to tell the difference

Not minor at all! :) Thanks for pointing it out

[The-Arbiter]

Deployment

• [x] Pre-Deploy Checks
  • [x] Set Local Env
  • [x] Check Local Env
  • [ ] Run make estimate and adjust ETH_GAS accordingly did not run on my machine
  • [x] Check Current Gas Price and set ETH_GAS_PRICE accordingly (adding a bit of margine in case of spikes if using EIP-1559, (eg. current gas price 100, 150 could be set)
  • [x] Check Env Chain seth chain
• [x] Deploy Spell on Mainnet via make deploy (this should also verify the Spell on Etherscan)
• [x] Add Deployed Spell Address & Timestamp to Base Tests
  • [x] deployed_spell: address(<deployed spell address>) // populate with deployed spell if deployed
  • [x] deployed_spell_created: <timestamp> // use get-created-timestamp.sh if deployed
• [x] Run Tests Locally with deployed spell address
• [x] Commit & Push for Review

Again thanks to Brian for deploying this.

Archive

• [x] Wait for at least two Approvals to Share to GovAlpha
• [x] Share Deployed Address in new-spells
• [x] Archive Spell via date="YYYY-MM-DD" make archive-spell
• [x] Commit & Push Archive for Review
• [x] Wait for Merge Approvals and CI to PASS

Merge

• [x] Squash & Merge
• [x] Fill Spell Crafter Related Boxes in the Main Exec Doc Sheet