PE-1102: 2022-10-19 Executive

[iamchrissmith]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[iamchrissmith]

CES changes merged in, tests pass, ready for pre-deploy review

• [x] Create Branch PE-<kanban ticket issue number>
  • [x] Note: for now current consensus is to use the same ticket issue number as per spells-goerli (this could be revised)
• [x] Pull Locally and Checkout Branch
• [x] Cleanup Previous Spell's Actions in DssSpell.sol (diffcheck with Goerli)
  • [x] Check Previous Spells in the archive Folder for Cleanup Patterns
• [x] Clenaup Previous Spell's Onboarding Actions in DssSpellCollateral.sol
  • [x] Check Previous Spells in the archive Folder for Cleanup Patterns
• [x] Cleanup Base Tests in config.sol (under test folder in src)
  • [x] Set deployed_spell to address(0)
  • [x] Set deployed_spell_created to 0
  • [x] Consider to add previous_spell address if it haven't been executed yet
• [x] Cleanup Specific Tests in DssSpell.t.sol
  • [x] Check Previous Spells in the archive Folder for Cleanup Patterns
  • [x] Disable Specific Tests IF Not Used (eg. testCollateralIntegrations, testNewChainlogValues, testNewIlkRegistryValues, ...)
  • [x] Remove Specific Part
  • [x] Keep Setup
  • [x] Disable by setting visibility to private
  • [x] Add Commented Notes
    • [x] eg. // Insert new collateral integration tests here
  • [x] Keep Commented Tests (eg. testOSMs, testMedianizers)
• [x] Add Spell Actions as per GovAlpha Spell Content Sheet - Polls
  • [x] Polls Starts on Monday and Ends on Thursday
  • [x] Check Polls Details and Links (Forum Posts, MIPs Portal, ...)
  • [x] Check on new-spells discord channel when Exec Doc is ready
  • [x] Pragma
  • [x] Current Solc Version 0.6.12
  • [x] Collateral Onboarding
    • [x] Add pragma experimental ABIEncoderV2; (Only IF DssExecLib.addNewCollateral is used)
  • [x] Interfaces
  • [x] Avoid dss-interfaces Multi-Import Layout (see issue #69)
  • [x] Prefer Single Import Layout
    • [x] import { VatAbstract } from "dss-interfaces/dss/VatAbstract.sol";
  • [x] Consider Static Interfaces
    • [x] IF not present in dss-interfaces
    • [x] IF present in dss-interfaces but TOFIX
    • [x] IF only few function interfaces are needed
  • [x] Consider Turn Office Hours On
  • [x] Check Spell Actions (eg. Onboarding, Liquidation Adjustments, New DSS Modules, ...)
  • [x] Note: Office Hours are On by default
  • [x] Use DssExecLib Functions
  • [x] Check DssExecLib Address Used in Spell (DssExecLib.address) Matches dss-exec-lib Latest Release Tag
  • [x] Check Previous Spells for Common Patterns
• [x] Adjust Sytem Values, Collateral Values in config.sol (diffcheck with spells-goerli)
• [x] Add Specific Tests in DssSpell.t.sol (diffcheck with spells-goerli)
  • [x] Add New Collateral Tests
  • [ ] Add Specific Tests (DAI/MKR Streams/Payments, Lerps, ...)
• [x] Run Tests make test or make test match=<test_name> to inspect debug traces
  • [x] Make sure to use latest dapptools
  • [x] dapp --version
  • [x] duppgrade <latest release> (eg. duppgrade hevm/0.49.0)
• [x] Debug via make test-forge or make test-forge match=<test_name> to inspect debut traces (for quicker testing)
  • [x] Make sure to use latest foundry
  • [x] Run foundryup
• [x] Test PASS via make test (Ensure Good Coverage)
• [x] Commit & Push
• [x] Open Draft PR on spells-mainnet titled "PE-: YYYY-MM-DD Executive"
• [x] Assign to yourself
• [x] Open PR & Add Reviewers

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 714782)
Test result: ok. 1 passed; 0 failed; finished in 40.08ms

Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 497011)
[PASS] testFailTooEarly() (gas: 12594)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12594)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testOnTime() (gas: 493422)
[PASS] testSpellIsCast_GENERAL() (gas: 22856338)
[PASS] testSpellIsCast_PSM_GUSD_A_tout() (gas: 503568)
[PASS] test_auth() (gas: 9223336852499061173)
[PASS] test_auth_in_sources() (gas: 9223336852485022489)
[PASS] test_bytecode_matches() (gas: 1173561)
[PASS] test_chainlog_values() (gas: 6024146)
[PASS] test_chainlog_version_bump() (gas: 3144118)
[PASS] test_nextCastTime() (gas: 338900)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 15 passed; 0 failed; finished in 217.35ms

[iamchrissmith]

• [x] Pre-Deploy Checks
  • [x] Set Local Env
  • [x] Check Local Env
  • [x] Run make estimate and adjust ETH_GAS accordingly
  • [x] Check Current Gas Price and Set ETH_GAS_PRICE accordingly
  • [x] Consider Adding Margin to Account for Spikes (eg. current gas price 25 gwei, 50 gwei could be set)
  • [x] Check Current Gas Priority Fee and Set ETH_PRIO_FEE accordingly
  • [x] Check Env Chain seth chain
• [x] Deploy Spell on Mainnet via make deploy (this should also verify the Spell on Etherscan)
• [x] Add Deployed Spell Address & Timestamp to Base Tests
  • [x] deployed_spell: address(<deployed_spell_address>) // populate with deployed spell if deployed
  • [x] deployed_spell_created: <timestamp> // use get-created-timestamp.sh if deployed
• [x] Run Tests Locally with deployed spell address
• [x] Commit & Push for Review

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 714782)
Test result: ok. 1 passed; 0 failed; finished in 145.05ms

Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 497011)
[PASS] testFailTooEarly() (gas: 12594)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12594)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testOnTime() (gas: 493422)
[PASS] testSpellIsCast_GENERAL() (gas: 24016389)
[PASS] testSpellIsCast_PSM_GUSD_A_tout() (gas: 503568)
[PASS] test_auth() (gas: 9223336852499061173)
[PASS] test_auth_in_sources() (gas: 9223336852485022489)
[PASS] test_bytecode_matches() (gas: 1173561)
[PASS] test_chainlog_values() (gas: 6024146)
[PASS] test_chainlog_version_bump() (gas: 3144118)
[PASS] test_nextCastTime() (gas: 338900)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 15 passed; 0 failed; finished in 1.07s