PE-1105: 2022-10-26 Executive

[The-Arbiter]

Spell Crafter Mainnet Workflow PE-1105 (Mainnet)

Mainnet

Repo: https://github.com/makerdao/spells-mainnet/pull/282

Steps:

• [x] Create Branch PE-<kanban ticket issue number>
  • [x] Note: for now current pattern is to use the same ticket issue number as per spells-goerli (this could be revised)
• [x] Pull Locally and Checkout to Branch
• [ ] Cleanup Previous Spell's Actions in DssSpell.sol (diffcheck with Goerli)
  • [ ] Check Previous Spells in the archive Folder for Cleanup Patterns
• [ ] Clenaup Previous Spell's Onboarding Actions in DssSpellCollateral.sol
  • [ ] Check Previous Spells in the archive Folder for Cleanup Patterns
• [ ] Cleanup Base Tests in config.sol (under test folder in src)
  • [ ] Set deployed_spell to address(0)
  • [ ] Set deployed_spell_created to 0
  • [ ] Consider to add previous_spell address if it haven't been executed yet
• [ ] Cleanup Specific Tests in DssSpell.t.sol
  • [ ] Check Previous Spells in the archive Folder for Cleanup Patterns
  • [ ] Disable Specific Tests IF Not Used (eg. testCollateralIntegrations, Changelog, IlkRegistry, ...)
    • [ ] Remove Specific Part
    • [ ] Keep Setup
    • [ ] Disable by setting visibility to private
    • [ ] Add Commented Notes
      • [ ] eg. // Insert new collateral integration tests here
• [ ] Add Spell Actions as per GovAlpha Spell Content Sheet - Polls
  • [ ] Polls starts on Monday and ends usually on Thursday
    • [ ] Check Polls Details and Links (Thread, Risk, ...)
  • [ ] Check on new-spells discord channel when Exec Doc is ready
  • [ ] Pragma
    • [ ] Current Solc Version 0.6.12
    • [ ] Collateral Onboarding
      • [ ] Add pragma experimental ABIEncoderV2;
  • [ ] Interfaces
    • [ ] Avoid dss-interfaces Multi-Import Layout (see issue #69)
    • [ ] Prefer Single Import Layout
      • [ ] import { VatAbstract } from "dss-interfaces/dss/VatAbstract.sol";
    • [ ] Consider Manual Contract Interfaces
      • [ ] IF not present in dss-interfaces
      • [ ] IF present in dss-interfaces but TOFIX
      • [ ] IF only few function interfaces are needed
  • [ ] Consider Turn Office Hours On
    • [ ] Check Spell Actions (eg. Onboarding, Liq Adjustments, New DSS Module, ...)
    • [ ] Note: Office Hours are On by default
  • [ ] Deploy New Join, Clip and Calc (Onboarding)
    • [ ] Join, check which one is required
      • [ ] Use JoinFab to Deploy
      • [ ] Etherscan Verification
        • [ ] Make sure AGPLv3 is specified and used
        • [ ] IF Flatten, Consider Removing HEVM Interface Artifacts
    • [ ] Clip
      • [ ] Use ClipFab to Deploy
      • [ ] Etherscan Verification
        • [ ] Make sure AGPLv3 is specified and used
    • [ ] Calc, check which one is required
      • [ ] Use CalcFab to Deploy
      • [ ] Note: Automatically Verified on Etherscan
    • [ ] Note: DSS Contracts Should Be Deployed On Mainnet Before Friday (Usually Wed-Thu)
  • [ ] Check with Oracle CU
    • [ ] Check IF Oracle Deployment is Required (eg. univ3-lp-oracle, new ilk pip, ...)
    • [ ] Note: Oracle Should Be Deployed On Mainnet Before Friday (Usually Wed-Thu)
  • [ ] Add New Addresses in the Changelog
  • [ ] Bump ChainLog, accordingly with spec (major, minor, patch)
    • [ ] MAJOR -> New Vat
    • [ ] MINOR -> Core Module (DSS) Update (e.g. Flapper)
    • [ ] PATCH -> Collateral addition or addition/modification
  • [ ] Use DssExecLib Functions
    • [ ] Check DssExecLib Address Used in Spell (Makefile & test-dssspell.sh) Matches Latest Release Tag on dss-exec-lib repo
  • [ ] Check Previous Spells for Common Patterns
• [ ] Adjust Sytem Values, Collateral Values in DssSpell.t.base.sol (diffcheck with goerli)
• [ ] Add Specific Tests in DssSpell.t.sol (diffcheck with gerli)
  • [ ] Add New Collateral Tests
  • [ ] Add New Changelog Value Tests
    • [ ] Add new Chaingelog Address in addresses_mainnet.sol
  • [ ] Add New Ilk Registry Value Tests
  • [ ] Add Specific Tests (Dai/MKR Streams/Payments, Lerps, ...)
• [ ] Run Tests make test or make test match=<test_name> for specific tests
  • [ ] Make sure to use latest dapptools release
    • [ ] dapp --version
    • [ ] duppgrade <latest release> (eg. duppgrade hevm/0.49.0)
• [ ] Debug via make test-forge (for quicker testing)
• [ ] Test PASS via make test + Good Coverage
• [ ] Commit & Push
• [ ] Open Draft PR on spells-mainnet titled "PE-: YYYY-MM-DD Executive"
• [ ] Assign to yourself
• [ ] Open PR & Add Reviewers
• [ ] Iterate till Polls are Ended and Exec Copy is Merged
• [ ] Confirm Exec Doc Actions
• [ ] Make sure CI PASS
• [ ] Add Exec Hash
  • [ ] Check when Copy is Merged
  • [ ] Reference either Latest Change or Merge Commit
• [ ] Wait for at least two Approvals with local tests to Deploy
• [ ] Pre-Deploy Checks
  • [ ] Set Local Env
  • [ ] Check Local Env
  • [ ] Run make estimate and adjust ETH_GAS accordingly
  • [ ] Check Current Gas Price and set ETH_GAS_PRICE accordingly (adding a bit of margine in case of spikes if using EIP-1559, (eg. current gas price 100, 150 could be set)
  • [ ] Check Env Chain seth chain
• [ ] Deploy Spell on Mainnet via make deploy (this should also verify the Spell on Etherscan)
• [ ] Add Deployed Spell Address & Timestamp to Base Tests
  • [ ] deployed_spell: address(<deployed spell address>) // populate with deployed spell if deployed
  • [ ] deployed_spell_created: <timestamp> // use get-created-timestamp.sh if deployed
• [ ] Run Tests Locally with deployed spell address
• [ ] Commit & Push for Review
• [ ] Wait for at least two Approvals to Share to GovAlpha
• [ ] Share Deployed Address in new-spells
• [ ] Archive Spell via date="YYYY-MM-DD" make archive-spell
• [ ] Commit & Push Archive for Review
• [ ] Wait for Merge Approvals and CI to PASS
• [ ] Squash & Merge
• [ ] Fill Spell Crafter Related Boxes in the Main Exec Doc Sheet

Next Steps

• [ ] Open Changelog PR (Deprecated in favour of chainlog-ui)
• [ ] MegaPoker Updates (handed over to Oracle Core Unit (OCU))
  • [ ] Inform Oracle Core Unit of Any Change Affecting the MegaPoker:
    • [ ] Collateral Onboardings
      • [ ] Including New Ilk Types (e.g. ETH-B)
    • [ ] Collateral Offboardings
    • [ ] Oracle Replacements
    • [ ] ...
  • [ ] Sanity Checks
    • [ ] Coordinate with Oracle CU and TechOps
    • [ ] Previous Code Patterns are Followed
    • [ ] MegaPoker Changes are Reviewed & Approved by OCU
    • [ ] CI & Local Tests PASS
    • [ ] New MegaPoker is Deployed
    • [ ] New Deployed MegaPoker Contract Address is Handed to TechOps
    • [ ] New Deployed Megapoker Contract Address is Updated in the README
• [ ] Keeper Support for New Onboarded Collateral
• [ ] Keeper Support for New Lerps (to call tall daily) via dss-cron
  • [ ] IF New Offboardings via Lerp (in current spell)