makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

107 stars 43 forks source link

PE-1108: November 2, 2022 Exec #285

Closed brianmcmichael closed 1 year ago

brianmcmichael commented 1 year ago

Description

Contribution Checklist

[X] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier override
[ ] Verify expiration (30 days unless otherwise specified)
[ ] Verify hash in the description matches here
[ ] Validate all addresses used are in changelog or known
[ ] Notify any external teams affected by the spell so they have the opportunity to review
[ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

talbaneth commented 1 year ago

LGTM to publish and archive.

Code matches repo. License ok. Compiler version ok. No optimizations with 200 iterations - ok. Execlib address matches repo. Tests pass.

talbaneth commented 1 year ago

@brianmcmichael note that we can now remove the content of skipWards and return false there (as oracle deployer of reth osm and medianizer was denied). Can also do it in a separate spell/PR if you want.