Closed gbalabasquer closed 1 year ago
Spell contract has been deployed to: https://etherscan.io/address/0xDe7FC6DD8F96c02E823278ff58Fa3624ff1A97A9#code
I'm updating the config to match it.
Spell hash check:
cast keccak -- "$(wget https://raw.githubusercontent.com/makerdao/community/d8c711404e9e17db24b611aa03d45507c1993148/governance/votes/Executive%20vote%20-%20November%2016%2C%202022.md -q -O - 2>/dev/null)
Result:
0xf3023b0a9b3c423edf28bf4cdbd61d287ab29265d462a5fae0378227c153ea7b
Content checking:
[x] Update line
, gap
and doc
for RWA007-A
line
) will be increased by 250 million DAI from 250 million DAI to 500 million DAI.gap
) will be increased by 50 million DAI from 50 million DAI to 100 million DAI.doc
parameter for RWA-007-A will be updated to QmejL1CKKN5vCwp9QD1gebnnAM2MJSt9XbF64uy4ptkJtR - IPFS Link - to reflect the most recent instuctions that can be found here.[x] Update line
, gap
and ttl
for RETH-A
line
) will be set to 5 million DAI.gap
) will be set to 3 million DAI.ttl
) will be set to 8 hours.[x] Update doc
for RWA008-A
doc
from QmdfzY6p5EpkYMN8wcomF2a1GsJbhkPiRQVRYSPfS4NZtB to QmZ4heYjptvj3ovafADJpXYMFXMyY3yQjkTXpvjFPnAKcy - IPFS Link.[x] Update doc
for RWA009-A
doc
from QmQx3bMtjncka2jUsGwKu7ButuPJFn9yDEEvpg9xZ71ECh to QmeRrbDF8MVPQfNe83gWf2qV48jApVigm1WyjEtDXCZ5rT - IPFS Link.[x] Update entries related to RWA007-A
components on the chainlog.
RWA007_A_INPUT_CONDUIT_URN
to RWA007_A_INPUT_CONDUIT
.RWAXXX_A_INPUT_CONDUIT_JAR
to RWAXXX_A_JAR_INPUT_CONDUIT
. ⚠️ This should specify RWA007_A_INPUT_CONDUIT_JAR
and RWA007_A_JAR_INPUT_CONDUIT
in the exec copy, but it's correct in the spell.Deployed spell (libs, version, settings, license) OK Code matches Timestamp looks OK
Tests pass
Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 992363)
Test result: ok. 1 passed; 0 failed; finished in 29.71s
Running 23 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 751171)
[PASS] testChangelogHousekeeping() (gas: 755258)
[PASS] testCollateralIntegrations() (gas: 1668772)
[PASS] testFailTooEarly() (gas: 401840)
[PASS] testFailTooLate() (gas: 401806)
[PASS] testFailWrongDay() (gas: 401714)
[PASS] testFail_notScheduled() (gas: 14147)
[PASS] testIlkClipper() (gas: 1368351)
[PASS] testNewChainlogValues() (gas: 779834)
[PASS] testOnTime() (gas: 747582)
[PASS] testRWA007DocChange() (gas: 805039)
[PASS] testRWA007OraclePriceBump() (gas: 935838)
[PASS] testRWA008DocChange() (gas: 805062)
[PASS] testRWA009DocChange() (gas: 805104)
[PASS] testRemoveChainlogValues() (gas: 755279)
[PASS] testSpellIsCast_GENERAL() (gas: 24006278)
[PASS] test_auth() (gas: 9223336852501692171)
[PASS] test_auth_in_sources() (gas: 9223336852485178776)
[PASS] test_bytecode_matches() (gas: 1638165)
[PASS] test_chainlog_values() (gas: 6395859)
[PASS] test_chainlog_version_bump() (gas: 2794834)
[PASS] test_nextCastTime() (gas: 404924)
[PASS] test_use_eta() (gas: 337923)
Test result: ok. 23 passed; 0 failed; finished in 1300.22s
LGTM
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR