makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells
GNU Affero General Public License v3.0
107 stars 43 forks source link

PE-1114 Executive vote #291

Closed gbalabasquer closed 1 year ago

gbalabasquer commented 1 year ago

Description

Contribution Checklist

Checklist

amusingaxl commented 1 year ago

Spell contract has been deployed to: https://etherscan.io/address/0xDe7FC6DD8F96c02E823278ff58Fa3624ff1A97A9#code

I'm updating the config to match it.

amusingaxl commented 1 year ago

Spell hash check:

cast keccak -- "$(wget https://raw.githubusercontent.com/makerdao/community/d8c711404e9e17db24b611aa03d45507c1993148/governance/votes/Executive%20vote%20-%20November%2016%2C%202022.md -q -O - 2>/dev/null)

Result:

0xf3023b0a9b3c423edf28bf4cdbd61d287ab29265d462a5fae0378227c153ea7b

The-Arbiter commented 1 year ago

Deployed spell (libs, version, settings, license) OK Code matches Timestamp looks OK

Tests pass

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 992363)
Test result: ok. 1 passed; 0 failed; finished in 29.71s

Running 23 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 751171)
[PASS] testChangelogHousekeeping() (gas: 755258)
[PASS] testCollateralIntegrations() (gas: 1668772)
[PASS] testFailTooEarly() (gas: 401840)
[PASS] testFailTooLate() (gas: 401806)
[PASS] testFailWrongDay() (gas: 401714)
[PASS] testFail_notScheduled() (gas: 14147)
[PASS] testIlkClipper() (gas: 1368351)
[PASS] testNewChainlogValues() (gas: 779834)
[PASS] testOnTime() (gas: 747582)
[PASS] testRWA007DocChange() (gas: 805039)
[PASS] testRWA007OraclePriceBump() (gas: 935838)
[PASS] testRWA008DocChange() (gas: 805062)
[PASS] testRWA009DocChange() (gas: 805104)
[PASS] testRemoveChainlogValues() (gas: 755279)
[PASS] testSpellIsCast_GENERAL() (gas: 24006278)
[PASS] test_auth() (gas: 9223336852501692171)
[PASS] test_auth_in_sources() (gas: 9223336852485178776)
[PASS] test_bytecode_matches() (gas: 1638165)
[PASS] test_chainlog_values() (gas: 6395859)
[PASS] test_chainlog_version_bump() (gas: 2794834)
[PASS] test_nextCastTime() (gas: 404924)
[PASS] test_use_eta() (gas: 337923)
Test result: ok. 23 passed; 0 failed; finished in 1300.22s

LGTM