makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells
GNU Affero General Public License v3.0
107 stars 43 forks source link

PE-1117: 2022-11-12 MakerDAO Executive Spell #292

Closed godsflaw closed 1 year ago

godsflaw commented 1 year ago

Description

Contribution Checklist

Checklist

iamchrissmith commented 1 year ago

tests pass:

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 842404)
Test result: ok. 1 passed; 0 failed; finished in 16.72s

Running 15 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAutoLineGap() (gas: 870633)
[PASS] testCastCost() (gas: 601234)
[PASS] testFailTooEarly() (gas: 12572)
[PASS] testFailTooLate() (gas: 12549)
[PASS] testFailWrongDay() (gas: 12594)
[PASS] testFail_notScheduled() (gas: 14139)
[PASS] testOnTime() (gas: 597645)
[PASS] testSpellIsCast_GENERAL() (gas: 23578827)
[PASS] test_auth() (gas: 9223336852501741738)
[PASS] test_auth_in_sources() (gas: 9223336852485228343)
[PASS] test_bytecode_matches() (gas: 1430949)
[PASS] test_chainlog_values() (gas: 6251922)
[PASS] test_chainlog_version_bump() (gas: 3304121)
[PASS] test_nextCastTime() (gas: 338878)
[PASS] test_use_eta() (gas: 337755)
Test result: ok. 15 passed; 0 failed; finished in 621.00s
The-Arbiter commented 1 year ago

Commits look ok

The-Arbiter commented 1 year ago

Address OK Settings and license OK DSSExecLib OK

godsflaw commented 1 year ago

etherscan link: https://etherscan.io/address/0x16787F838D6562D7A0337ff65130b6a9a1255C77#code