PE-1119

[hexonaut]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[hexonaut]

This is ready for review now. @gbalabasquer @megozu @The-Arbiter @rockyfour

[rockyfour]

Note that etherscan verification was done wIth GPL V3 instead of AGPL V3 (I think it's not a showstopper as the etherscan source code does have the correct license in the header).

[hexonaut]

In the interest of getting this deployed soon, can we keep all remaining review comments just to if any particular check or functionality is missing and not format, generalization of tests, etc.

[gbalabasquer]

The D3M sections looks good.

• DIRECT_HUB (0x12F36cdEA3A28C35aC8C6Cc71D9265c17C74A27F) matches code in the repo, compiler version and optimization are ok. Constructor param is ok. Pause Proxy relied, deployer denied.
• DIRECT_MOM (0x1AB3145E281c01a1597c8c62F9f060E8e3E02fAB) matches code in the repo, compiler version and optimization are ok. Pause Proxy set as owner.
• DIRECT_COMPV2_DAI_ORACLE (0x0e2bf18273c953B54FE0a9dEC5429E67851D9468) matches code in the repo, compiler version and optimization are ok. Constructor params are ok. Pause Proxy relied, deployer denied.
• DIRECT_COMPV2_DAI_POOL (0x621fE4Fde2617ea8FFadE08D0FF5A862aD287EC2) matches code in the repo, compiler version and optimization are ok. Constructor params are ok. Pause Proxy relied, deployer denied.
• DIRECT_COMPV2_DAI_PLAN (0xD0eA20f9f9e64A3582d569c8745DaCD746274AEe) matches code in the repo, compiler version and optimization are ok. Constructor param is ok. Pause Proxy relied, deployer denied.
• D3M_COMP_BORROW_RATE value (7535450719) is correct from the math calculation and also matches one used in the integration test.
• D3M_CDAI (0x5d3a536E4D6DbD6114cc1Ead35777bAB948E3643) is the official cDAI token
• D3M_COMPTROLLER (0x3d9819210A31b4961b30EF54bE2aeD79B9c9Cd3B) is the comptroller in the official cDAI token
• D3M_COMP (0xc00e94Cb662C3520282E6f5717214004A7f26888) is the official COMP token
• D3M_TACK (0xFB564da37B41b2F6B6EDcc3e56FbF523bD9F2012) is the interestRateModel of the official cDAI token
• D3M_DELEGATE (0x3363BAe2Fc44dA742Df13CD3ee94b6bB868ea376) is the implementation of the official cDAI token
• Sanity checks look good
• Hub is fully set for Compound D3M
• Mom authority is correctly set with the Chief (for no delayed action)
• Pool is fully set for Compound D3M
• Plan is fully set for Compound D3M (including allowing Mom for disabling it)
• Oracle is fully set for Compound D3M
• MCD_ESM doesn't need to be relied in any of the D3M modules which has been added (Hub, Mom, Oracle, Pool nor Plan). All of them won't allow any harmful admin execution after ES.
• testDirectCompV2Integration and other tests including D3M stuff look good

[rockyfour]

The cD3M part LGTM.

• deployed contract matches v2 branch.
• ctr parameters ok.
• relies/denies ok.
• spell content ok.
• test ok.

[hexonaut]

Two minor changes. LMK when you guys think it's good to deploy. Again please just structural issues and missing checks, etc.

@The-Arbiter take your time. Thorough review is important.

[rockyfour]

cd3m part still good to deploy

[luke7211]

L2Spell Review

• [x] L2Spell verified in StarkScan
• [x] 0x00da114221cb83fa859dbdb4c44beeaa0bb37c7537ad5ae66fe5e0efd20e6eb3 is L2 DAI Token
• [x] 0x075ac198e734e289a6892baa8dd14b21095f13bf8401900f5349d5569c3f6e60 is L2 DAI bridge deployed Oct 2022
• [x] 0x001108cdbe5d82737b9057590adaf97d34e74b5452f0628161d237746b6fe69e is L2 Legacy DAI bridge deployed May 2022
• [x] 0x05b20d8c7b85456c07bdb8eaaeab52a6bf3770a586af6da8d3f5071ef0dcf234 is L2 DAI Teleport Gateway deployed Nov 2022
• [x] 0x05f4d9b039f82e9a90125fb119ace0531f4936ff2a9a54a8598d49a4cd4bd6db is L2 Governance Relay deployed Nov 2022
• [x] new L1GovernanceRelay.l2GovernanceRelay = new L2 GovernanceRelay
• [x] new L1DaiBridge.l2DaiBridge = new L2 DAI bridge
• [x] legacy L1DaiBridge.l2DaiBridge = legacy L2 DAI bridge
• [x] L1DAITeleportGateway.l2TeleportGateway = L2 DAI Teleport Gateway
• [x] L2 Spell gives new L2 Govnernace Relay authority to L2 DAI, L2 DAI Bridge, legacy L2 DAI Bridge, L2 DAI Teleport Gateway

LGTM

[hexonaut]

Ok everything outstanding should be resolved now. Waiting for final confirmation before deploying @megozu @The-Arbiter

[The-Arbiter]

I forgot to put part of my deploy stage review so here it is:

Deployed Stage

• [x] Local Tests and CI PASS
• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No with 200 runs
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license
• [x] Deployed Spell Code matches GitHub
  • diffcheck etherscan source against spell PR (i.e. via vscode code --diff etherscan.sol github.sol)
• [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
  • git submodule hash matches dss-exec-lib latest release's tag commit

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 2716118)
Test result: ok. 1 passed; 0 failed; finished in 136.81s

Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testCastCost() (gas: 2454060)
[PASS] testDirectCompV2Integration() (gas: 2964797)
[PASS] testFailTooEarly() (gas: 401840)
[PASS] testFailTooLate() (gas: 401685)
[PASS] testFailWrongDay() (gas: 401686)
[PASS] testFail_notScheduled() (gas: 14169)
[PASS] testIlkClipper() (gas: 4227150)
[PASS] testMKRPayments() (gas: 2467692)
[PASS] testMedianizers() (gas: 2460832)
[PASS] testNewChainlogValues() (gas: 2578334)
[PASS] testNewIlkRegistryValues() (gas: 2476975)
[PASS] testOnTime() (gas: 2450515)
[PASS] testSpellIsCast_GENERAL() (gas: 29143581)
[PASS] test_auth() (gas: 9223336852501768144)
[PASS] test_auth_in_sources() (gas: 9223336852484776805)
[PASS] test_bytecode_matches() (gas: 5128272)
[PASS] test_chainlog_values() (gas: 8129997)
[PASS] test_chainlog_version_bump() (gas: 4455745)
[PASS] test_nextCastTime() (gas: 404835)
[PASS] test_use_eta() (gas: 337923)
Test result: ok. 20 passed; 0 failed; finished in 1714.34s