PE-1124 - December 9, 2022 Executive Spell

[brianmcmichael]

Description

MakerDAO December 9, 2022 Executive Spell

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[amusingaxl]

Deployed Contract exception: None of the Tinlake Managers have a license specified on Mainnet in Etherscan. They do in Goerli. I don't think this is a blocker for the spell, but @amusingaxl might be something to alert the Centrifuge team about.

Apparently the license is not shown on Etherscan UI, but there is one declared in the code:

[iamchrissmith]

Deployed Contract exception: None of the Tinlake Managers have a license specified on Mainnet in Etherscan. They do in Goerli. I don't think this is a blocker for the spell, but @amusingaxl might be something to alert the Centrifuge team about.

Apparently the license is not shown on Etherscan UI, but there is one declared in the code:

Yeah the code looks the same so seems like something they did it differently in etherscan. Not sure if they can update the license to display correctly under other settings, but might be worth trying. Either way, as the tinlake manager is not fully in scope, it is definitely not a blocker for us.