PE-1149

[iamchrissmith]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[The-Arbiter]

Tests OK

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1755479)
Test result: ok. 1 passed; 0 failed; finished in 50.11s

Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487101560772)
[PASS] testAuthInSources() (gas: 9223371487098802424)
[PASS] testBytecodeMatches() (gas: 2732155)
[PASS] testCastCost() (gas: 1555408)
[PASS] testChainlogValues() (gas: 9705183)
[PASS] testChainlogVersionBump() (gas: 4823679)
[PASS] testContractSize() (gas: 9028)
[PASS] testDeployCost() (gas: 2716801)
[PASS] testFailNotScheduled() (gas: 14353)
[PASS] testFailTooEarly() (gas: 13569)
[PASS] testFailTooLate() (gas: 13634)
[PASS] testFailWrongDay() (gas: 13657)
[PASS] testGeneral() (gas: 36471134)
[PASS] testMKRPayments() (gas: 1581612)
[PASS] testNextCastTime() (gas: 353165)
[PASS] testOnTime() (gas: 1552017)
[PASS] testPayments() (gas: 1718815)
[PASS] testUseEta() (gas: 351894)
[PASS] testVestDAI() (gas: 1772486)
[PASS] testVestMKR() (gas: 1654296)
Test result: ok. 20 passed; 0 failed; finished in 1471.17s

[iamchrissmith]

spell deploy https://etherscan.io/address/0xb02fd2a51517c035d05b11272f769097dc2ead87

and tests passing locally:

Running 1 test for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1755479)
Test result: ok. 1 passed; 0 failed; finished in 14.05s

Running 20 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487101560772)
[PASS] testAuthInSources() (gas: 9223371487098802424)
[PASS] testBytecodeMatches() (gas: 2745436)
[PASS] testCastCost() (gas: 1555408)
[PASS] testChainlogValues() (gas: 9705183)
[PASS] testChainlogVersionBump() (gas: 4823679)
[PASS] testContractSize() (gas: 9028)
[PASS] testDeployCost() (gas: 2730046)
[PASS] testFailNotScheduled() (gas: 14353)
[PASS] testFailTooEarly() (gas: 13569)
[PASS] testFailTooLate() (gas: 13634)
[PASS] testFailWrongDay() (gas: 13657)
[PASS] testGeneral() (gas: 36488334)
[PASS] testMKRPayments() (gas: 1581612)
[PASS] testNextCastTime() (gas: 353165)
[PASS] testOnTime() (gas: 1552017)
[PASS] testPayments() (gas: 1718447)
[PASS] testUseEta() (gas: 351894)
[PASS] testVestDAI() (gas: 1772486)
[PASS] testVestMKR() (gas: 1654296)
Test result: ok. 20 passed; 0 failed; finished in 630.24s