search

makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells
GNU Affero General Public License v3.0
107 stars 43 forks source link

Improve CI results by introducing rollFork #307

Closed iamchrissmith closed 1 year ago

iamchrissmith commented 1 year ago

Adding tracking for the block number for the deployed spell allows us to rollFork to that block so our test will continue to pass even after the spell has been scheduled/cast. This should give us more confidence in our CI results as there aren't times that it "should fail".

iamchrissmith commented 1 year ago

@brianmcmichael @gbalabasquer @godsflaw while we discuss the binary search optimization on spells-goerli, would you want to merge this on mainnet so we're at least in sync between the two repos?

iamchrissmith commented 1 year ago

merged in the latest spell changes. would be good to get this merged before we start the next spell