makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

107 stars 43 forks source link

PE-1198: 2023-03-08 Executive Spell #321

Closed gbalabasquer closed 1 year ago

gbalabasquer commented 1 year ago

Description

Contribution Checklist

[x] PR title starts with (PE-<TICKET_NUMBER>)
[x] Code approved
[x] Tests approved
[ ] CI Tests pass

Checklist

[x] Every contract variable/method declared as public/external private/internal
[x] Consider if this PR needs the officeHours modifier override
[x] Verify expiration (30 days unless otherwise specified)
[x] Verify hash in the description matches here
[x] Validate all addresses used are in changelog or known
[x] Notify any external teams affected by the spell so they have the opportunity to review
[x] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
[x] Verify mainnet contract on etherscan
[x] Change test to use mainnet spell address and deploy timestamp
[ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

gbalabasquer commented 1 year ago

@kmbarry1 @megozu I'm still keeping it as draft as we are missing two delegates to confirm their payments and also the hash has to be added. However if you want to start looking at it is pretty much done.

gbalabasquer commented 1 year ago

@kmbarry1 @megozu ready for review