PE-1202

[rockyfour]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[megozu]

Tests PASS (at deployed spell block=16804986):

./scripts/test-dssspell-forge.sh match="" block="16804986"
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠔] Compiling...
No files changed, compilation skipped

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 825446)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; finished in 264.64ms

Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAAVEDirectBarChange() (gas: 762033)
[PASS] testAuth() (gas: 9223371487101818864)
[PASS] testAuthInSources() (gas: 9223371487099163868)
[PASS] testBytecodeMatches() (gas: 2564868)
[PASS] testCastCost() (gas: 676217)
[PASS] testChainlogValues() (gas: 8884260)
[PASS] testChainlogVersionBump() (gas: 4031911)
[PASS] testCompoundDirectBarbChange() (gas: 1036746)
[PASS] testContractSize() (gas: 8962)
[PASS] testDeployCost() (gas: 2550532)
[PASS] testFailNotScheduled() (gas: 14353)
[PASS] testFailTooEarly() (gas: 13635)
[PASS] testFailTooLate() (gas: 13656)
[PASS] testFailWrongDay() (gas: 13635)
[PASS] testGeneral() (gas: 35580771)
[PASS] testNextCastTime() (gas: 393647)
[PASS] testOnTime() (gas: 666500)
[PASS] testPSMTinTout() (gas: 680250)
[PASS] testUseEta() (gas: 392376)
Test result: ok. 19 passed; 0 failed; finished in 1.34s