Closed kmbarry1 closed 1 year ago
LGTM to deploy. Tests still running but the 2 other successful test runs are enough.
Tests pass:
Running 2 tests for src/test/starknet.t.sol:StarknetTests [PASS] testStarknet() (gas: 885714) [PASS] testStarknetSpell() (gas: 2346) Test result: ok. 2 passed; 0 failed; finished in 22.12s
Running 18 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testAuth() (gas: 9223371487102099566) [PASS] testAuthInSources() (gas: 9223371487099270971) [PASS] testBytecodeMatches() (gas: 2132378) [PASS] testCastCost() (gas: 739220) [PASS] testChainlogValues() (gas: 8964162) [PASS] testChainlogVersionBump() (gas: 3176893) [PASS] testContractSize() (gas: 9006) [PASS] testDeployCost() (gas: 2118676) [PASS] testFailNotScheduled() (gas: 14375) [PASS] testFailTooEarly() (gas: 13629) [PASS] testFailTooLate() (gas: 13606) [PASS] testFailWrongDay() (gas: 13607) [PASS] testGeneral() (gas: 35302556) [PASS] testLineAdjustment() (gas: 744613) [PASS] testLineMom() (gas: 859694) [PASS] testNextCastTime() (gas: 353636) [PASS] testOnTime() (gas: 726812) [PASS] testUseEta() (gas: 352343) Test result: ok. 18 passed; 0 failed; finished in 1075.65s
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR