makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells

GNU Affero General Public License v3.0

107 stars 43 forks source link

PE-1217 #332

Closed iamchrissmith closed 1 year ago

iamchrissmith commented 1 year ago

Description

Contribution Checklist

[ ] PR title starts with (PE-<TICKET_NUMBER>)
[ ] Code approved
[ ] Tests approved
[ ] CI Tests pass

Checklist

[ ] Every contract variable/method declared as public/external private/internal
[ ] Consider if this PR needs the officeHours modifier override
[ ] Verify expiration (30 days unless otherwise specified)
[ ] Verify hash in the description matches here
[ ] Validate all addresses used are in changelog or known
[ ] Notify any external teams affected by the spell so they have the opportunity to review
[ ] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
[ ] Verify mainnet contract on etherscan
[ ] Change test to use mainnet spell address and deploy timestamp
[ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
[ ] squash and merge this PR

iamchrissmith commented 1 year ago

@The-Arbiter and @brianmcmichael This has everything in it as of 21:30 UTC on 03/31/23. Two notes:

Some of the delegate addresses have not been confirmed yet in the spreadsheet. The unconfirmed addresses match what we have in addresses_wallets.sol for those delegates so I am reasonably confident they are good
I did not add the Ecosystem Actor DAI transfers yet as those are new, unconfirmed and the Phoenix Labs one isn't even filled in yet

Feel free to start reviewing if you want since this is a long one, or I can ping you when I have final confirmation and content.

iamchrissmith commented 1 year ago

I believe i have corrected these things

brianmcmichael commented 1 year ago

Confirmed yanked streams are owned by SF (according to forums)

Tests passing

Need Governance copy merge