Spell 2023-06-07

[SidestreamSweatyPumpkin]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier override
• [x] Verify expiration (30 days unless otherwise specified)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[SidestreamSweatyPumpkin]

Outdated

`test_RWA012_Update` Fails on `draw` atm.

Log

``` ./scripts/test-dssspell-forge.sh match="test_RWA012_Update" block="" │ Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6 │ Compiling 4 files with 0.8.16 │ Solc 0.8.16 finished in 2.18s │ Compiler run successful │ │ Running 1 test for src/DssSpell.t.sol:DssSpellTest │ [FAIL. Reason: Vat/ceiling-exceeded] test_RWA012_Update() (gas: 7970974) │ Traces: │ [7553674] DssSpellTest::test_RWA012_Update() ....SKIPPING │ ├─ [7907] Vat::frob(0x5257413031322d41000000000000000000000000000000000000000000000│ 000, RwaUrn: [0xB22E9DBF60a5b47c8B2D0D6469548F3C2D036B7E], RwaUrn: [0xB22E9DBF60a5b47c8B2D0│ D6469548F3C2D036B7E], RwaUrn: [0xB22E9DBF60a5b47c8B2D0D6469548F3C2D036B7E], 0, 492716202734│ 73683159790433) │ │ │ └─ ← "Vat/ceiling-exceeded" ```

Fails with vat's `ceiling exceeded` for the frob dart value `49271620273473683159790433` which according to my calculations should not be the case: ``` In [91]: rate Out[91]: 1019109100349028321294098468 In [92]: line Out[92]: 80000000000000000000000000000000000000000000000000000 In [93]: art Out[93]: 29202675209661009418797776 In [94]: (art + 49271620273473683159790433) * rate < line Out[94]: True In [95]: line - (art + 49271620273473683159790433) * rate Out[95]: 26131329658786650242735408873063937319149130236188 ```

Keeping the PR as draft until goerli one gets approved.

[0xdecr1pto]

Checklist

• [X] Office Hours

  • [X] On (Collateral Onboarding, Keepers)
  • [X] match exec

• [X] Exec Hash

  • [X] Executive vote file name and date is correct
  • [X] community repo commit hash corresponds to latest change
  • [X] Raw GitHub URL is correct
  • [X] Exec hash is correct
  • [X] description date in DssSpell.sol matches exec copy date

• [X] 30 Days Expiry

• [X] lib

  • [X] dss-exec-lib
  • [X] if submodule upgrades are present make sure dss-exec-lib is synced as well
  • [X] git submodule hash matches tag latest release version or above
  • [X] dss-test
  • [X] dss-interfaces
    • [X] git submodule hash matches github master commit
  • [X] forge-std
    • [X] git submodule hash matches github tag latest release version

• [X] dss-interfaces

  • [X] used in the current spell
  • [X] cleanup previous ones
  • [X] ensure only single import layout is used (e.g. import "dss-interfaces/dss/VatAbstract.sol";)

• [X] Static Interfaces

  • [X] ensure they match dss-interfaces
  • [X] check on-chain interface of deployed contract via cast interfaces <contract_address> to ensure correctness
  • [X] interface naming style should match with Like suffix (e.g. VatLike)
  • [X] ensure they only list used functions in spell code

• [X] Rates match

  • [X] Compare against IPFS
  • [X] Check manually via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
  • [X] Variable visibility declared as internal

• [X] Math matches

  • [X] Internal Precision
  • [X] WAD = 10**18
  • [X] RAD = 10**45
  • [X] Ensure they match with ds-math and the Numerical Ranges
  • [X] Variable visibility declared as internal
  • [X] Units
  • [X] MILLION = 10**6
  • [X] Ensure they match with config
  • [X] Variable visibility declared as internal

• [X] Offboarding (Lerp mat)

  • [X] 1st Stage Spell Actions
    • [X] Remove Ilk from Autoline
    • [X] Set Ilks Debt Ceilings to 0
    • [ ] Cache Ilks line to Reduce in the Global Debt Ceiling We are not doing this as discussed and represented in exec doc
    • [ ] Decrease Global Debt Ceiling by Total Amount of Offboarded Ilks line Cached (see above)

• [x] RWA Updates (for RWA010, RWA011, RWA012, RWA012, RWA013)

  • [X] doc
  • [X] init the RwaLiquidationOracle to reset the doc
  • [X] Sanity Check pip must be set (not the zero address)
  • [X] ilk follows format "RWAXXX-A"
  • [X] val price ignored (0) if init has already been called
  • [X] doc new legal document (IPFS HASH) matches Doc (or Forum Post)
  • [X] tau parameter used is the old tau value
  • [X] Debt Ceiling (line) + Liquidation Oracle Price Bump (val)
  • [X] Increase Ilk Debt Ceiling (set DC + increase Global DC) -> global DC won’t be increased as per exec sheet
  • [x] bump RwaLiquidationOracle with new computed increased price (val)
  • [x] val should enable DAI to be drawn over the loan period while taking into account the configured ink amount, interest rate and liquidation ratio
  • [x] Poke spotter to pull in the new price

• [x] Deployed Contracts

  • [X] Verified on etherscan
  • [X] RWA015
  • [X] MCD_JOIN_RWA015_A
  • [X] RWA015_A_URN
  • [X] RWA015_A_JAR
  • [X] RWA015_A_INPUT_CONDUIT_URN
  • [X] RWA015_A_INPUT_CONDUIT_JAR
  • [X] RWA015_A_OUTPUT_CONDUIT
  • [X] Optimizations match Repo
  • [X] GNU AGPLv3 license
  • [X] Constructor args ok (e.g. vat, dai, dog, ...)
  • [X] Match ChainLog
    • [X] RWA015
    • [X] MCD_JOIN_RWA015_A
    • [X] RWA015_A_URN
    • [X] RWA015_A_JAR
    • [X] RWA015_A_INPUT_CONDUIT_URN
    • [X] RWA015_A_INPUT_CONDUIT_JAR
    • [X] RWA015_A_OUTPUT_CONDUIT
  • [X] Wards ok (pause proxy relied, deployer denied)
  • [X] MCD_JOIN_RWA015_A
  • [X] RWA015_A_URN
  • [X] RWA015_A_INPUT_CONDUIT_URN
  • [X] RWA015_A_INPUT_CONDUIT_JAR
  • [X] RWA015_A_OUTPUT_CONDUIT
  • [X] Check whether the contract requires to rely the ESM in the spell (in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy).
  • [X] Matches corresponding github source code (i.e. diffcheck via vscode code --diff etherscan.sol github.sol)
  • [X] Ensure deployer address is included into addresses_deployers.sol (to keep up to date)

• [X] Onboarding

  • [X] RWA Onboarding

• [X] CUs MKR Transfers

  • [X] Recipient Addresses match Doc
    • [X] Sidestream - 348.28 MKR - 0xb1f950a51516a697E103aaa69E152d839182f6Fe
    • [X] DUX - 225.12 MKR - 0x5A994D8428CCEbCC153863CCdA9D2Be6352f89ad
  • [X] Transfers Amounts match Doc
  • [x] Follows Previous Patterns (we are not using WAD here, use ether as a unit instead. See archive) Edited: Fixed by crafter

• [X] ChainLog

  • [X] Bump ChainLog, accordingly with spec (major, minor, patch)
  • [X] PATCH -> Collateral addition or addition/modification

• [X] addresses_goerli.sol matches spell code

• [X] Ensure every spell variable is declared as public/internal

• [X] Ensure immutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress and constant is used instead for static addresses

• [X] Spell actions match GovAlpha Spell Content Sheet

• [X] Tests PASS

  • [X] Ensure Good Coverage
  • [X] Ensure every test function is declared as public if enabled or private if disabled

• [X] Local Tests and CI PASS

RWA onboarding

• RWA Onboarding Checklist
  • [-] Deployed Contracts
  • [X] RwaToken (Token Used as Collateral In Adapter)
    • [X] deployed via RwaTokenFactory
    • [X] Fab matches chainlog
    • [X] Rwa Token transferred to MCD Pause Proxy
    • [X] createRwaToken parameters are correct
      • [X] name is in RWA-XXX format
      • [X] symbol is in RWAXXX format
      • [X] recipient matches MCD Pause Proxy
  • [X] AuthGemJoin (Join Adapter)
    • [X] deployed via JoinFab
    • [X] Fab matches chainlog
    • [X] newAuthGemJoin parameters are correct
      • [X] owner matches MCD Pause Proxy
      • [X] ilk is the bytes32 representation of "RWAXXX-A"
      • [X] cast --to-ascii <bytes32> matches ASCII Ilk
      • [X] cast --to-bytes32 $(cast --from-ascii "RWAXXX-A") matches bytes32
      • [X] gem matches RwaToken deployed contract
  • [X] RwaUrn2
    • [X] contract is verified on etherscan
    • [X] ensure 0.6.12 solc version is used
    • [X] ensure optimization are off
    • [X] ensure license is specified
    • [X] ensure source matches github code and it's consistent with previous RWA onboarding
    • [X] constructor args are correct and match chainlog
    • [X] vat
    • [X] jug
    • [X] gemJoin
    • [X] daiJoin
    • [X] outputConduit matches RwaOutputConduit<2,3>
    • [X] check wards
    • [X] MCD_PAUSE_PROXY is relied
    • [X] deployer is denied
    • [X] no other address has been relied
  • [X] RwaJar
    • [X] contract is verified on etherscan
    • [X] ensure 0.6.12 solc version is used
    • [X] ensure optimization are off
    • [X] ensure license is specified
    • [X] ensure source matches github code and it's consistent with previous RWA onboarding
    • [X] constructor arg matches chainlog
    • [X] chainlog
    • [X] no wards
  • [X] RwaInputConduit<2,3>s (both)
    • [X] contract is verified on etherscan
    • [X] ensure 0.6.12 solc version is used
    • [X] ensure optimization are off
    • [X] ensure license is specified
    • [X] ensure source matches github code and it's consistent with previous RWA onboarding
    • [X] constructor args are correct and match chainlog
    • [X] dai
    • [X] to (RwaUrn, RwaJar)
    • [X] gov (v1)
    • [X] psm, gem (v3)
    • [X] check wards
    • [X] MCD_PAUSE_PROXY is relied
    • [X] deployer is denied
    • [X] no other address has been relied
  • [X] RwaOutputConduit
    • [X] contract is verified on etherscan
    • [X] ensure 0.6.12 solc version is used
    • [X] ensure optimization are off
    • [X] ensure license is specified
    • [X] ensure source matches github code and it's consistent with previous RWA onboarding
    • [X] constructor args are correct and match chainlog
    • [X] dai
    • [X] gov (v1)
    • [X] psm, gem (v3)
    • [X] check wards
    • [X] MCD_PAUSE_PROXY is relied
    • [X] deployer is denied
    • [X] no other address has been relied
  • [X] Risk Parameters Match Doc
    • [X] duty(stability fee)
    • [X] line(debt ceiling)
    • [X] mat (liquidation ratio)
    • [X] val (oracle price)
    • [X] tau (pre-agreed remediation period)
    • [X] doc (IPFS Hash)
  • [-] Onboarding Actions
    • [X] ilk matches the format RWAXXX-A
    • [X] Sanity Checks (constructor args, public vars, ... via require condition)
    • [X] oracle.init
    • [X] vat.init.ilk
    • [x] vat rely join
    • [x] Increase Ilk Debt Ceiling (set DC + increase Global DC)
    • [X] File Ilk pip in the spotter
    • [x] File Ilk mat in the spotter
    • [X] Poke spotter to pull in the price
    • [x] join rely urn
    • [-] Access Control
    • [X] hope (operator, pause proxy)
    • [x] mate (operator, pause proxy as fallback if required)
    • [X] kiss (whitelist for urn destination address who)
    • [X] Filable
    • [X] quitTo
    • [X] New Chainlog Entries
    • [X] RWAXXX
    • [X] PIP_RWAXXX precomputed via cast compute-address $MIP21_LIQUIDATION_ORACLE
    • [X] MCD_JOIN_RWA015_A
    • [X] RWAXXX_A_URN
    • [X] RWAXXX_A_JAR
    • [X] RWAXXX_A_INPUT_CONDUIT_URN
    • [X] RWAXXX_A_INPUT_CONDUIT_JAR
    • [X] RWAXXX_A_OUTPUT_CONDUIT
    • [X] Chainlog Bump
    • [X] Patch x.x.1
    • [X] Add Ilk to IlkRegistry
    • [X] put is used
    • [X] class is 3
    • [X] name matches forum post (e.g. "RWA007-A: Monetalis Clydesdale")
    • [X] Ensure DssExecLib is used for the Onboarding (e.g. DssExecLib.vat)
    • [-] Test Coverage (Follow Previous Test Patterns)
    • [X] testNewChainlogValues
    • [X] testNewIlkRegistryValues
    • [X] testRWAXXX_INTEGRATION_CONDUITS_SETUP
    • [X] testRWAXXX_INTEGRATION_BUMP
    • [X] testRWAXXX_INTEGRATION_TELL
    • [X] testRWAXXX_INTEGRATION_TELL_CURE_GOOD
    • [X] testFailRWAXXX_INTEGRATION_CURE_BEFORE_TELL
    • [X] testRWAXXX_INTEGRATION_TELL_CULL
    • [X] testRWAXXX_PAUSE_PROXY_OWNS_RWAXXX_TOKEN_BEFORE_SPELL
    • [X] testRWAXXX_SPELL_LOCK_OPERATOR_DRAW_WIPE_FREE -> changed to testRWAXXX_SPELL_LOCK_OPERATOR_WIPE_FREE
    • [X] testFailRWAXXX_DRAW_ABOVE_LINE
    • [X] testRWAXXX_OPERATOR_LOCK_DRAW_CAGE -> change to testRWAXXX_SPELL_CAGE
    • [x] testFailRWAXXX_OUTPUT_CONDUIT_PUSH_ABOVE_BALANCE
    • [X] testRWAXXX_SPELL_LOCK -> changed to testRWAXXX_SPELL_EXECUTES_LOCK_DRAW_PUSH
    • [X] addresses_<mainnet, goerli>.sol
    • [X] config.sol

Spark

• [X] External Contracts Calls (e.g. Starknet)
  • [x] Target Contract don't block spell execution
  • [x] External call is NOT delegate call (proxy does external call, but I think checklist should be updated for that)
  • [x] Target Contract doesn't have permissions on the Vat
  • [x] Target Contract doesn't do anything untoward (e.g. interacting with unsafe contracts) Looks OK
  • [x] MCD Pause Proxy doesn't give any approvals
  • [x] Spark proxy can only be called via Pause proxy
  • [x] All possible actions of the Target Contract are documented (not true, but looks fine)
  • [x] Target contract is not upgradable (Technically is not, but proxy can call anything. This somehow related to delegatecall checklist point)
  • [X] Target Contract is included in the ChainLog N/A (SubDao related contract)
  • [X] Test Coverage is comprehensive Looks OK

[hexonaut]

Spark spell is confirmed as 0x41D7c79aE5Ecba7428283F66998DedFD84451e0e on mainnet Spark proxy: 0x3300f198988e4C9C63F75dF86De36421f06af8c4 ACL Manager: 0xdA135Cd78A086025BcdC87B038a1C462032b510C

[The-Arbiter]

Following concerns I have raised regarding the provenance of SubDAO related addresses, Spark Team has confirmed the addresses in #new-spells.

Many thanks to Spark Team for confirming these addresses in a timely manner. Addresses may be added to exec doc for additional provenance given how they were added to the mainnet spell but this will be done at the discretion of Governance Facilitators.

[ghost]

New copy commit as requested by @The-Arbiter: https://github.com/makerdao/community/blob/c55480785534ee1f75bda65afb9761ffaebe072f/governance/votes/Executive%20vote%20-%20June%2014%2C%202023.md

[The-Arbiter]

The current spell team has unanimously voted to remove the line DssExecLib.setChangelogAddress("SUBPROXY_SPARK", SPARK_PROXY); and relevant tests from the 2023-06-14 spell (this spell).

Reasoning:

This content was not present in the executive sheet.

Nor is it present in the forum posts used as provenance for deriving sheet actions.

This content was also not present in the current executive document.

The executive document contains precedent of ChangeLog / ChainLog changes being listed actions (represented as cells in the exec sheet), see the 2022-11-16 exec doc for reference.

Core spell team is capable of making technical decisions and requesting contextual inclusion in the executive document however this spell team has elected to remove this content as it was not an instruction and the spell team does not want to be construed as having had added content to the spell which would normally be an explicit instruction (action in the doc / cell in the sheet) where no such instruction was requested by Governance Facilitators.

The voting process is no concern of the spell team, however it should be noted that precedent for chainlog instructions that existed as standalone actions in the spell involved a forum post and presumably a vote, so the current spell team cannot add this content without sufficient provenance of Maker Core governance approving these actions, as they affect the Maker Core chainlog.

It should be noted that this represents a bug which occurred for the Goerli spell, as this action was not present in the executive sheet (the source of truth for the Goerli spell) at the time. Primary motivators for this bug include the relevant code snippet being PR'ed by a third party source (SubDAO), the crafter approving the PR to the main spell without noticing the extraneous content inclusion and two reviewer passes missing that this code was not an instruction provided by Governance Facilitators in the executive sheet. A retrospective report may be released on this event at a later date however given the current state of flux in the spellcrafting process, it is my opinion that this mistake is a result of inconsistency of processes and recent significant changes in team structures for both the Governance Facilitator Team and Maker Core Spell Team.

[ghost]

The voting process is no concern of the spell team, however it should be noted that precedent for chainlog instructions that existed as standalone actions in the spell involved a forum post and presumably a vote

On Governance process, in case interested parties read this - there is no requirement for a vote to take place on these items. Core Unit Facilitators (and now Scope Facilitators) are empowered by Governance to insert logic directly into Executive Votes where it falls within their mandate. Consequently, the vast majority of such Chainlog updates simply required a notification from the relevant Facilitator on the forum.

[0xdecr1pto]

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 7520266)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; finished in 109.04s

Running 40 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487104564591)
[PASS] testAuthInSources() (gas: 9223371487099024870)
[PASS] testBytecodeMatches() (gas: 4795049)
[PASS] testCastCost() (gas: 7376206)
[PASS] testChainlogValues() (gas: 15974053)
[PASS] testChainlogVersionBump() (gas: 9880876)
[PASS] testContractSize() (gas: 9050)
[PASS] testDeployCost() (gas: 4774011)
[PASS] testFailNotScheduled() (gas: 14361)
[PASS] testFailRWA015_A_DRAW_ABOVE_LINE() (gas: 7810501)
[PASS] testFailRWA015_A_INTEGRATION_CURE_BEFORE_TELL() (gas: 7793208)
[PASS] testFailRWA015_A_OUTPUT_CONDUIT_PUSH_ABOVE_BALANCE() (gas: 7810499)
[PASS] testFailTooEarly() (gas: 417571)
[PASS] testFailTooLate() (gas: 417571)
[PASS] testFailWrongDay() (gas: 417683)
[PASS] testGeneral() (gas: 45132600)
[PASS] testMKRPayments() (gas: 7391161)
[PASS] testNewChainlogValues() (gas: 7495301)
[PASS] testNewIlkRegistryValues() (gas: 7402007)
[PASS] testNextCastTime() (gas: 446365)
[PASS] testOnTime() (gas: 7363865)
[PASS] testPSMs() (gas: 8670008)
[PASS] testRWA010DocChange() (gas: 7444468)
[PASS] testRWA011DocChange() (gas: 7444422)
[PASS] testRWA012DocChange() (gas: 7444400)
[PASS] testRWA013DocChange() (gas: 7444466)
[PASS] testRWA015A_SPELL_EXECUTES_LOCK_DRAW_PUSH() (gas: 7382802)
[PASS] testRWA015_CONTRACT_DEPLOYMENT_SETUP() (gas: 131657)
[PASS] testRWA015_INTEGRATION_BUMP() (gas: 7390795)
[PASS] testRWA015_INTEGRATION_CONDUITS_SETUP() (gas: 7421408)
[PASS] testRWA015_INTEGRATION_TELL() (gas: 7389622)
[PASS] testRWA015_INTEGRATION_TELL_CULL() (gas: 7357731)
[PASS] testRWA015_INTEGRATION_TELL_CURE_GOOD() (gas: 7388183)
[PASS] testRWA015_PAUSE_PROXY_OWNS_RWA015_TOKEN_BEFORE_SPELL() (gas: 16464)
[PASS] testRWA015_SPELL_CAGE() (gas: 7892921)
[PASS] testRWA015_SPELL_LOCK_IGNORE_ART() (gas: 7380543)
[PASS] testRWA015_SPELL_OPERATOR_WIPE_FREE() (gas: 7548145)
[PASS] testSparkSpell() (gas: 7388274)
[PASS] testUseEta() (gas: 352492)
[PASS] test_RWA012_Update() (gas: 7571469)
Test result: ok. 40 passed; 0 failed; finished in 1012.08s

[0xdecr1pto]

good for deploy

PASS] testStarknet() (gas: 7520898)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; finished in 142.06s

Running 40 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487104564591)
[PASS] testAuthInSources() (gas: 9223371487099024870)
[PASS] testBytecodeMatches() (gas: 4795049)
[PASS] testCastCost() (gas: 7376838)
[PASS] testChainlogValues() (gas: 15974685)
[PASS] testChainlogVersionBump() (gas: 9881508)
[PASS] testContractSize() (gas: 9050)
[PASS] testDeployCost() (gas: 4774011)
[PASS] testFailNotScheduled() (gas: 14361)
[PASS] testFailRWA015_A_DRAW_ABOVE_LINE() (gas: 7811133)
[PASS] testFailRWA015_A_INTEGRATION_CURE_BEFORE_TELL() (gas: 7793840)
[PASS] testFailRWA015_A_OUTPUT_CONDUIT_PUSH_ABOVE_BALANCE() (gas: 7811131)
[PASS] testFailTooEarly() (gas: 417571)
[PASS] testFailTooLate() (gas: 417571)
[PASS] testFailWrongDay() (gas: 417683)
[PASS] testGeneral() (gas: 45133232)
[PASS] testMKRPayments() (gas: 7391793)
[PASS] testNewChainlogValues() (gas: 7495933)
[PASS] testNewIlkRegistryValues() (gas: 7402639)
[PASS] testNextCastTime() (gas: 446365)
[PASS] testOnTime() (gas: 7364497)
[PASS] testPSMs() (gas: 8670640)
[PASS] testRWA010DocChange() (gas: 7445100)
[PASS] testRWA011DocChange() (gas: 7445054)
[PASS] testRWA012DocChange() (gas: 7445032)
[PASS] testRWA013DocChange() (gas: 7445098)
[PASS] testRWA015A_SPELL_EXECUTES_LOCK_DRAW_PUSH() (gas: 7383434)
[PASS] testRWA015_CONTRACT_DEPLOYMENT_SETUP() (gas: 131657)
[PASS] testRWA015_INTEGRATION_BUMP() (gas: 7391427)
[PASS] testRWA015_INTEGRATION_CONDUITS_SETUP() (gas: 7422040)
[PASS] testRWA015_INTEGRATION_TELL() (gas: 7390254)
[PASS] testRWA015_INTEGRATION_TELL_CULL() (gas: 7358363)
[PASS] testRWA015_INTEGRATION_TELL_CURE_GOOD() (gas: 7388815)
[PASS] testRWA015_PAUSE_PROXY_OWNS_RWA015_TOKEN_BEFORE_SPELL() (gas: 16464)
[PASS] testRWA015_SPELL_CAGE() (gas: 7893553)
[PASS] testRWA015_SPELL_LOCK_IGNORE_ART() (gas: 7381175)
[PASS] testRWA015_SPELL_OPERATOR_WIPE_FREE() (gas: 7548777)
[PASS] testSparkSpell() (gas: 7388906)
[PASS] testUseEta() (gas: 352492)
[PASS] test_RWA012_Update() (gas: 7572216)
Test result: ok. 40 passed; 0 failed; finished in 1341.48s

[SidestreamSweatyPumpkin]

deployed at https://etherscan.io/address/0x9E16c8B4C998604471EA0e63ECBb6d6d30F07fA0#%E2%94%82code

[0xdecr1pto]

Good for handover

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell)
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address matches hardcoded local DssExecLib.address
  • [x] deployed_spell_created matches deployment timestamp
  • [x] deployed_spell_block matches deployment block number
  • [X] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [X] git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target exec date)
  • [x] ensure date corresponds to target exec date
• [x] Local Tests and CI PASS

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 7521128)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; finished in 140.95s

Running 40 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487104564591)
[PASS] testAuthInSources() (gas: 9223371487099024870)
[PASS] testBytecodeMatches() (gas: 4795049)
[PASS] testCastCost() (gas: 7377068)
[PASS] testChainlogValues() (gas: 15974915)
[PASS] testChainlogVersionBump() (gas: 9881738)
[PASS] testContractSize() (gas: 9050)
[PASS] testDeployCost() (gas: 4774011)
[PASS] testFailNotScheduled() (gas: 14361)
[PASS] testFailRWA015_A_DRAW_ABOVE_LINE() (gas: 7811363)
[PASS] testFailRWA015_A_INTEGRATION_CURE_BEFORE_TELL() (gas: 7794070)
[PASS] testFailRWA015_A_OUTPUT_CONDUIT_PUSH_ABOVE_BALANCE() (gas: 7811361)
[PASS] testFailTooEarly() (gas: 417571)
[PASS] testFailTooLate() (gas: 417571)
[PASS] testFailWrongDay() (gas: 417683)
[PASS] testGeneral() (gas: 45135559)
[PASS] testMKRPayments() (gas: 7392023)
[PASS] testNewChainlogValues() (gas: 7496163)
[PASS] testNewIlkRegistryValues() (gas: 7402869)
[PASS] testNextCastTime() (gas: 446365)
[PASS] testOnTime() (gas: 7364727)
[PASS] testPSMs() (gas: 8670870)
[PASS] testRWA010DocChange() (gas: 7445330)
[PASS] testRWA011DocChange() (gas: 7445284)
[PASS] testRWA012DocChange() (gas: 7445262)
[PASS] testRWA013DocChange() (gas: 7445328)
[PASS] testRWA015A_SPELL_EXECUTES_LOCK_DRAW_PUSH() (gas: 7383664)
[PASS] testRWA015_CONTRACT_DEPLOYMENT_SETUP() (gas: 131657)
[PASS] testRWA015_INTEGRATION_BUMP() (gas: 7391657)
[PASS] testRWA015_INTEGRATION_CONDUITS_SETUP() (gas: 7422270)
[PASS] testRWA015_INTEGRATION_TELL() (gas: 7390484)
[PASS] testRWA015_INTEGRATION_TELL_CULL() (gas: 7358593)
[PASS] testRWA015_INTEGRATION_TELL_CURE_GOOD() (gas: 7389045)
[PASS] testRWA015_PAUSE_PROXY_OWNS_RWA015_TOKEN_BEFORE_SPELL() (gas: 16464)
[PASS] testRWA015_SPELL_CAGE() (gas: 7893783)
[PASS] testRWA015_SPELL_LOCK_IGNORE_ART() (gas: 7381405)
[PASS] testRWA015_SPELL_OPERATOR_WIPE_FREE() (gas: 7549007)
[PASS] testSparkSpell() (gas: 7389136)
[PASS] testUseEta() (gas: 352492)
[PASS] test_RWA012_Update() (gas: 7572561)
Test result: ok. 40 passed; 0 failed; finished in 1348.73s