Mainnet spell 2023-07-12

[SidestreamColdMelon]

Description

This draft PR will implement executive spell planned for 2023-07-12 according to the Executive Vote Implementation Process spreadsheet. Submitting it early to allow other teams to fork and submit their part of the spell.

Contribution Checklist

• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier override
• [x] Verify expiration (30 days unless otherwise specified)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Verify mainnet contract on etherscan
• [x] Change test to use mainnet spell address and deploy timestamp
• [x] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [x] squash and merge this PR

[DaiFoundation-DevOps]

All committers have signed the CLA.

[SidestreamColdMelon]

❌ Spell copy says to remove MCD_FLAP from the chainlog, but we are actually replacing it with the new FlapperUniV2.

This line comes from my request to clearly specify that old address will not end up under MCD_FLAP_LEGACY, but is removed. How do you want to formulate this instruction to match what happens in the code?

❌ CRVV1ETHSTETH-A off-boarding is not reducing the global debt ceiling.

This is intentional, as Global Line Modifier set to No in the spreadsheet. Was also discussed in the call with GovAlpha.

[amusingaxl]

x Spell copy says to remove MCD_FLAP from the chainlog, but we are actually replacing it with the new FlapperUniV2.

This line comes from my request to clearly specify that old address will not end up under MCD_FLAP_LEGACY, but is removed. How do you want to formulate this instruction to match what happens in the code?

I see... In that case, it could be something like:

Deprecate MCD_FLAP and remove MCD_FLAP from chainlog -> Deprecate the current Flapper and replace the MCD_FLAP address in the chainlog with FlapperUniV2.

x CRVV1ETHSTETH-A off-boarding is not reducing the global debt ceiling.

This is intentional, as Global Line Modifier set to No in the spreadsheet. Was also discussed in the call with GovAlpha.

Oh, my bad... I completely overlooked that column.

[SidestreamColdMelon]

Deprecate MCD_FLAP and remove MCD_FLAP from chainlog -> Deprecate the current Flapper and replace the MCD_FLAP address in the chainlog with FlapperUniV2.

Actually, latest executive copy already doesn't contain remove MCD_FLAP from chainlog, it only says As only one Flapper can be active in the Maker Protocol, the old MCD_FLAP used for buy-and-burn will be deactivated. So I think this point is also resolved without the need to change executive sheet?

[ghost]

also leaving new copy link here to maximise visibility @SidestreamColdMelon : https://github.com/makerdao/community/blob/9cdf05e59054bf3c9f83d3b52717e27775b0267e/governance/votes/Executive%20vote%20-%20July%2014%2C%202023.md

[The-Arbiter]

Updates for new exec doc version: Exec URL is https://raw.githubusercontent.com/makerdao/community/9cdf05e59054bf3c9f83d3b52717e27775b0267e/governance/votes/Executive%20vote%20-%20July%2014%2C%202023.md Exec doc latest commit is 9cdf05e59054bf3c9f83d3b52717e27775b0267e Exec doc hash is 0xd0f51f9c121346d109607aea7752285b361e6ab48f65428fa3c17fd53237f347 New date is 2023-07-14 per exec doc title and content, and description should be updated to reflect this.

Good for deploy once this is done.

[The-Arbiter]

Description and aforementioned checks all OK, OK to deploy.

[SidestreamColdMelon]

The spell was deployed at https://etherscan.io/address/0x402D46A20C849390Da96CeB0C3c04832D29e87d7#code

[amusingaxl]

• [x] Deployed spell matches source code.
• [x] Licenses match
• [x] Optimizations enabled for this spell, so it doesn't hit code size limit
• [x] Deployed spell matches archive.
• [x] CI tests pass
• [x] Local tests pass

  
  Running 2 tests for src/test/starknet.t.sol:StarknetTests
  [PASS] testStarknet() (gas: 3369748)
  [PASS] testStarknetSpell() (gas: 2331)
  Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 50.48s

Running 30 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testBytecodeMatches() (gas: 4131799) [PASS] testAuth() (gas: 9223371487104096031) [PASS] testAuthInSources() (gas: 9223371487099105098) [PASS] testCastCost() (gas: 3239392) [PASS] testChainlogValues() (gas: 10619225) [PASS] testChainlogVersionBump() (gas: 5586663) [PASS] testContractSize() (gas: 8660) [PASS] testDeployCost() (gas: 4112198) [PASS] testFailNotScheduled() (gas: 13801) [PASS] testFailTooEarly() (gas: 405696) [PASS] testFailTooLate() (gas: 405491) [PASS] testFailWrongDay() (gas: 405342) [PASS] testFlapperUniV2() (gas: 3621513) [PASS] testGeneral() (gas: 34939875) [PASS] testMKRPayments() (gas: 3346478) [PASS] testNewChainlogValues() (gas: 3378575) [PASS] testNextCastTime() (gas: 405101) [PASS] testOnTime() (gas: 3235515) [PASS] testPSMs() (gas: 4409450) [PASS] testPayments() (gas: 3271906) [PASS] testRWA015_INTEGRATION_CONDUITS_SETUP() (gas: 3273352) [PASS] testRWA015_OPERATOR_DRAW_CONDUIT_PUSH() (gas: 3630055) [PASS] testRWA015_OUTPUT_CONDUIT_DEPLOYMENT_SETUP() (gas: 13224) [PASS] testRWA015_REVOKE_OLD_CONDUITS_PERMISSIONS() (gas: 3262290) [PASS] testRemoveChainlogValues() (gas: 3240731) [PASS] testSequencerFlapJob() (gas: 3739152) [PASS] testUseEta() (gas: 341775) [PASS] testVestDAI() (gas: 3385905) [PASS] testVestMKR() (gas: 3361134) [PASS] testYankDAI() (gas: 3249928) Test result: ok. 30 passed; 0 failed; 0 skipped; finished in 1038.72s Ran 2 test suites: 32 tests passed, 0 failed, 0 skipped (32 total tests)

Good to handover.