search

makerdao / spells-mainnet

Staging repo for MakerDAO weekly executive spells
GNU Affero General Public License v3.0
116 stars 46 forks source link

Add Flapper deployment #356

Closed sunbreak1211 closed 1 year ago

DaiFoundation-DevOps commented 1 year ago

CLA assistant check
All committers have signed the CLA.

sunbreak1211 commented 1 year ago

Tests have a hack to hardcode a value for MKR oracle until the contract has a value filled in. As soon as that happens we can remove the hack.

sunbreak1211 commented 1 year ago

Price is already coming from the Oracle, PR should be ready for final review. testAuth is failing, I don't think it is related to this PR but can not make it to finish in my local.

sunbreak1211 commented 1 year ago

Actually I just got a result, and it is the PIP_MKR not having the deployer deauthed. Will check with Nik when that will be done.

SidestreamColdMelon commented 1 year ago

Currently I still get the issue with PIP_MKR deployer: 

$ make test match=testAuth
./scripts/test-dssspell-forge.sh match="testAuth" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠔] Compiling...
No files changed, compilation skipped

Running 2 tests for src/DssSpell.t.sol:DssSpellTest
[FAIL. Reason: Assertion failed.] testAuth() (gas: 9223371487105411581)
Logs:
  Error: Bad Auth
     Deployer Address: 0x39abd7819e5632fa06d2ecbba45dca5c90687ee3
    Affected Contract: PIP_MKR

This address is marked as Oracles from 2022-10-26 in the addresses_deployers.sol