2023-08-02 Spell

[amusingaxl]

Description

Contribution Checklist

• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [x] Consider if this PR needs the officeHours modifier override
• [x] Verify expiration (30 days unless otherwise specified)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in changelog or known
• [x] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[The-Arbiter]

Requesting addition of subdao spell deployer address (in the form of a comment is fine, as I understand that this increases test time significantly).

Replication of this change

[The-Arbiter]

This spell (as well as the Goerli spell at the stage when I reviewed it) is very clean and well structured. Well done with this one @amusingaxl

[SidestreamSweatyPumpkin]

archive happened before deploy info was added so there's a mismatch now.

[amusingaxl]

archive happened before deploy info was added so there's a mismatch now.

My bad! It's fixed now.

[SidestreamSweatyPumpkin]

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell) among many lines of the deployed spell i did not discover anything malicious
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches .8.16
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file matches
    • [x] Check again that the PR did not modify the DssExecLib.sol file (e.g. look under the 'Files Changed' PR tab, etc.) not changed
  • [x] deployed_spell_created matches deployment timestamp
  • [x] deployed_spell_block matches deployment block number
  • [x] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [~] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that exec lib used by the contract matches the latest release) fine even though not the exact match. Was the same in previous deployments
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target exec date)
  • [x] ensure date corresponds to target exec date
• [x] CI tests are passing
• [x] Local Tests PASS

./scripts/test-dssspell-forge.sh match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠢] Compiling...
[⠘] Compiling 104 files with 0.8.16
[⠃] Solc 0.8.16 finished in 3.69s
Compiler run successful

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1771772)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; finished in 42.46s

Running 22 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487105707415)
[PASS] testAuthInSources() (gas: 9223371487099495064)
[PASS] testBytecodeMatches() (gas: 2468218)
[PASS] testCastCost() (gas: 1619621)
[PASS] testChainlogValues() (gas: 10460141)
[PASS] testChainlogVersionBump() (gas: 5236407)
[PASS] testContractSize() (gas: 9006)
[PASS] testDeployCost() (gas: 2453602)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13542)
[PASS] testFailTooLate() (gas: 13584)
[PASS] testFailWrongDay() (gas: 13607)
[PASS] testGeneral() (gas: 37270621)
[PASS] testMKRPayments() (gas: 1705603)
[PASS] testNextCastTime() (gas: 353637)
[PASS] testOnTime() (gas: 1615371)
[PASS] testPSMs() (gas: 2976957)
[PASS] testPayments() (gas: 1654922)
[PASS] testRWA002DocChange() (gas: 1682156)
[PASS] testRWA004OracleTell() (gas: 1632200)
[PASS] testSparkSpellIsExecuted() (gas: 1618907)
[PASS] testUseEta() (gas: 352346)
Test result: ok. 22 passed; 0 failed; finished in 1008.59s

Approved, can merge