2023-08-30 Spell

[0xdecr1pto]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[SidestreamSweatyPumpkin]

Note:

this does not seem to be addressed in this PR. Do you want to adjust it or do we leave it out because there was no corresponding instruction in the exec sheet?

[ghost]

no corresponding instruction in the exec sheet?

This is nothing to do with the exec sheet since it is not a governance action item. It's fixing what appears to be an error that was made in the config file, nothing to do with the exec contents. Remember Governance participants also reference that sheet so including stuff there that is not in the code might lead to confusion for voters.

Whether or not it needs to be fixed has nothing to do with GovAlpha.

[SidestreamSweatyPumpkin]

Ok, then we should adjust the config there for sure @0xdecr1pto

[0xdecr1pto]

Ok, then we should adjust the config there for sure @0xdecr1pto

We have an issue there, here is the discussion: https://github.com/makerdao/spells-mainnet/issues/362

I prefer to keep it as it is until we reach a consensus on how to dealt with it

[amusingaxl]

• [x] CI tests pass
• [x] Local tests pass

Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠔] Compiling...
[⠢] Compiling 4 files with 0.8.16
[⠒] Solc 0.8.16 finished in 2.64s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 2312546)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 16.38s

Running 30 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487105898164)
[PASS] testAuthInSources() (gas: 9223371487099324820)
[PASS] testBytecodeMatches() (gas: 2777538)
[PASS] testCastCost() (gas: 2160461)
[PASS] testChainlogValues() (gas: 11018150)
[PASS] testChainlogVersionBump() (gas: 4772012)
[PASS] testContractSize() (gas: 9006)
[PASS] testDeployCost() (gas: 2762152)
[PASS] testFailNotScheduled() (gas: 14420)
[PASS] testFailTooEarly() (gas: 13629)
[PASS] testFailTooLate() (gas: 13562)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testFlipperMomDeauth() (gas: 2162716)
[PASS] testGeneral() (gas: 38030850)
[PASS] testMKRPayments() (gas: 2175548)
[PASS] testNewChainlogValues() (gas: 2256556)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 2156145)
[PASS] testPSMs() (gas: 3517709)
[PASS] testPayments() (gas: 2226214)
[PASS] testRWA003OracleTell() (gas: 2172951)
[PASS] testRWA015_CONTRACT_DEPLOYMENT_SETUP() (gas: 90905)
[PASS] testRWA015_INPUT_CONDUITS() (gas: 2778029)
[PASS] testRWA015_INTEGRATION_CONDUITS_SETUP() (gas: 2213009)
[PASS] testRemoveChainlogValues() (gas: 2170652)
[PASS] testSparkSpellIsExecuted() (gas: 2159659)
[PASS] testUseEta() (gas: 352302)
[PASS] testVowEsmRely() (gas: 2162930)
[PASS] testYankDAI() (gas: 2172795)
[PASS] testYankMKR() (gas: 2210407)
Test result: ok. 30 passed; 0 failed; 0 skipped; finished in 457.80s
Ran 2 test suites: 32 tests passed, 0 failed, 0 skipped (32 total tests)

Good to deploy :shipit:

[0xdecr1pto]

Spell deployed: 0xf9a88bBABBe4b5b907D28322649c504cA9897892

[amusingaxl]

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell)
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • [x] Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
  • [x] deployed_spell_created matches deployment timestamp
  • [x] deployed_spell_block matches deployment block number
  • [x] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [x] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target Exec Doc date)
  • [x] Ensure date corresponds to target Exec Doc date
• [x] Tests
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit

    aa58b9f938f92d8406d14c1d49c8b9e10274cd7a

  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠢] Compiling...
[⠊] Compiling 4 files with 0.8.16
[⠢] Solc 0.8.16 finished in 2.65s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 2312546)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 193.78s

Running 30 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487105898164)
[PASS] testAuthInSources() (gas: 9223371487099324820)
[PASS] testBytecodeMatches() (gas: 2777538)
[PASS] testCastCost() (gas: 2160461)
[PASS] testChainlogValues() (gas: 11018150)
[PASS] testChainlogVersionBump() (gas: 4772012)
[PASS] testContractSize() (gas: 9006)
[PASS] testDeployCost() (gas: 2762152)
[PASS] testFailNotScheduled() (gas: 14420)
[PASS] testFailTooEarly() (gas: 13629)
[PASS] testFailTooLate() (gas: 13562)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testFlipperMomDeauth() (gas: 2162716)
[PASS] testGeneral() (gas: 38032947)
[PASS] testMKRPayments() (gas: 2175548)
[PASS] testNewChainlogValues() (gas: 2256556)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 2156145)
[PASS] testPSMs() (gas: 3517709)
[PASS] testPayments() (gas: 2226444)
[PASS] testRWA003OracleTell() (gas: 2172951)
[PASS] testRWA015_CONTRACT_DEPLOYMENT_SETUP() (gas: 90905)
[PASS] testRWA015_INPUT_CONDUITS() (gas: 2778029)
[PASS] testRWA015_INTEGRATION_CONDUITS_SETUP() (gas: 2213009)
[PASS] testRemoveChainlogValues() (gas: 2170652)
[PASS] testSparkSpellIsExecuted() (gas: 2159659)
[PASS] testUseEta() (gas: 352302)
[PASS] testVowEsmRely() (gas: 2162930)
[PASS] testYankDAI() (gas: 2172795)
[PASS] testYankMKR() (gas: 2210407)
Test result: ok. 30 passed; 0 failed; 0 skipped; finished in 418.03s
Ran 2 test suites: 32 tests passed, 0 failed, 0 skipped (32 total tests)

Good to handover.