2023-09-13 Executive Spell

[SidestreamSweatyPumpkin]

Description

This PR implements executive spell planned for 2023-09-13.

Contribution Checklist

• [x] Code approved
• [x] Tests approved
• [x] CI Tests pass

Checklist

• [x] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [x] Verify expiration (30 days unless otherwise specified)
• [x] Verify hash in the description matches here
• [x] Validate all addresses used are in Mainnet changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [x] Deploy spell to Mainnet ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [x] Ensure contract is verified on Mainnet etherscan
• [x] Change test to use Mainnet spell address and deploy timestamp
• [x] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol and DssSpell.t.base.sol
• [ ] squash and merge this PR

[DaiFoundation-DevOps]

All committers have signed the CLA.

[SidestreamColdMelon]

• ✅ All changes requested from my side were addressed
• ✅ The changes from my last review looks good
• ✅ Spell content didn't change
• ✅ Exec doc is still on ef20638
• ✅ Local tests pass

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠃] Compiling 4 files with 0.8.16
[⠒] Solc 0.8.16 finished in 1.87s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1285145)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 413.88s

Running 22 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487105890401)
[PASS] testAuthInSources() (gas: 9223371487099493823)
[PASS] testBytecodeMatches() (gas: 2756205)
[PASS] testCastCost() (gas: 1130538)
[PASS] testChainlogValues() (gas: 9990598)
[PASS] testChainlogVersionBump() (gas: 3766923)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 2740753)
[PASS] testFailNotScheduled() (gas: 14420)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13562)
[PASS] testFailWrongDay() (gas: 13563)
[PASS] testGeneral() (gas: 36939568)
[PASS] testMKRPayments() (gas: 1247971)
[PASS] testNewChainlogValues() (gas: 1133765)
[PASS] testNextCastTime() (gas: 353637)
[PASS] testOnTime() (gas: 1126244)
[PASS] testPSMs() (gas: 2500853)
[PASS] testRemoveChainlogValues() (gas: 1132241)
[PASS] testScuttleMcdCat() (gas: 1144821)
[PASS] testSparkSpellIsExecuted() (gas: 1129780)
[PASS] testUseEta() (gas: 352324)
Test result: ok. 22 passed; 0 failed; 0 skipped; finished in 988.94s

Ran 2 test suites: 24 tests passed, 0 failed, 0 skipped (24 total tests)

Good to deploy 👍

[amusingaxl]

• [x] Changes addressed
• [x] Local tests pass

Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠑] Compiling...
[⠒] Compiling 4 files with 0.8.16
[⠊] Solc 0.8.16 finished in 2.28s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1284110)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 17.76s

Running 22 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487105890401)
[PASS] testAuthInSources() (gas: 9223371487099493823)
[PASS] testBytecodeMatches() (gas: 2756205)
[PASS] testCastCost() (gas: 1129503)
[PASS] testChainlogValues() (gas: 9989563)
[PASS] testChainlogVersionBump() (gas: 3765888)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 2740753)
[PASS] testFailNotScheduled() (gas: 14420)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13562)
[PASS] testFailWrongDay() (gas: 13563)
[PASS] testGeneral() (gas: 36938533)
[PASS] testMKRPayments() (gas: 1246936)
[PASS] testNewChainlogValues() (gas: 1132730)
[PASS] testNextCastTime() (gas: 353637)
[PASS] testOnTime() (gas: 1125209)
[PASS] testPSMs() (gas: 2499818)
[PASS] testRemoveChainlogValues() (gas: 1131206)
[PASS] testScuttleMcdCat() (gas: 1143786)
[PASS] testSparkSpellIsExecuted() (gas: 1128745)
[PASS] testUseEta() (gas: 352324)
Test result: ok. 22 passed; 0 failed; 0 skipped; finished in 520.30s

Ran 2 test suites: 24 tests passed, 0 failed, 0 skipped (24 total tests)

Good to deploy :shipit:

[SidestreamSweatyPumpkin]

https://etherscan.io/address/0xD97B4e0b43708c836935c9b2320f57074DC1D146#code deployed

[SidestreamColdMelon]

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license Note: london evmVersion
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell)
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • [x] Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
  • [x] deployed_spell_created matches deployment timestamp
  • [x] deployed_spell_block matches deployment block number
  • [x] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [ ] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release) ⚠️ Doesn't match, as in many previous spells (dss-exec-lib submodule is at 69b658f which is the latest commit in the dss-exec-lib repo, but the latest release is at c0d3c6c which is 7 commits behind)
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target Exec Doc date)
  • [x] Ensure date corresponds to target Exec Doc date
• [x] Tests
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit Insert most recent commit hash where CI was passing 8be2261
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

Insert your passing local tests here

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠑] Compiling...
[⠑] Compiling 4 files with 0.8.16
[⠃] Solc 0.8.16 finished in 1.99s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1284972)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 91.05s

Running 22 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487105890401)
[PASS] testAuthInSources() (gas: 9223371487099493823)
[PASS] testBytecodeMatches() (gas: 2756205)
[PASS] testCastCost() (gas: 1130365)
[PASS] testChainlogValues() (gas: 9990425)
[PASS] testChainlogVersionBump() (gas: 3766750)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 2740753)
[PASS] testFailNotScheduled() (gas: 14420)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13562)
[PASS] testFailWrongDay() (gas: 13563)
[PASS] testGeneral() (gas: 36941492)
[PASS] testMKRPayments() (gas: 1247798)
[PASS] testNewChainlogValues() (gas: 1133592)
[PASS] testNextCastTime() (gas: 353637)
[PASS] testOnTime() (gas: 1126071)
[PASS] testPSMs() (gas: 2500680)
[PASS] testRemoveChainlogValues() (gas: 1132068)
[PASS] testScuttleMcdCat() (gas: 1144648)
[PASS] testSparkSpellIsExecuted() (gas: 1129607)
[PASS] testUseEta() (gas: 352324)
Test result: ok. 22 passed; 0 failed; 0 skipped; finished in 1004.48s

Ran 2 test suites: 24 tests passed, 0 failed, 0 skipped (24 total tests)

Good to handover 👍

[amusingaxl]

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell)
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • [x] Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
  • [x] deployed_spell_created matches deployment timestamp
  • [x] deployed_spell_block matches deployment block number

    ./scripts/check-deployed-dssspell.sh
    [✔] DssSpell is verified.
    [✔] DssSpell was verified with a valid license.
    [✔] DssSpell solc version matches.
    [✔] DssSpell was not compiled with optimizations.
    [✔] DssSpell library matches hardcoded address in DssExecLib.address.
    [✔] DssSpell deployment timestamp matches.
    [✔] DssSpell deployment block number matches.

  • [x] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [ ] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target Exec Doc date)
  • [x] Ensure date corresponds to target Exec Doc date
• [x] Tests
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit :white_check_mark: 8be2261
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠔] Compiling 104 files with 0.8.16
[⠒] Solc 0.8.16 finished in 4.44s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1284167)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 18.59s

Running 22 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487105890401)
[PASS] testAuthInSources() (gas: 9223371487099493823)
[PASS] testBytecodeMatches() (gas: 2756205)
[PASS] testCastCost() (gas: 1129560)
[PASS] testChainlogValues() (gas: 9989620)
[PASS] testChainlogVersionBump() (gas: 3765945)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 2740753)
[PASS] testFailNotScheduled() (gas: 14420)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13562)
[PASS] testFailWrongDay() (gas: 13563)
[PASS] testGeneral() (gas: 36940687)
[PASS] testMKRPayments() (gas: 1246993)
[PASS] testNewChainlogValues() (gas: 1132787)
[PASS] testNextCastTime() (gas: 353637)
[PASS] testOnTime() (gas: 1125266)
[PASS] testPSMs() (gas: 2499875)
[PASS] testRemoveChainlogValues() (gas: 1131263)
[PASS] testScuttleMcdCat() (gas: 1143843)
[PASS] testSparkSpellIsExecuted() (gas: 1128802)
[PASS] testUseEta() (gas: 352324)
Test result: ok. 22 passed; 0 failed; 0 skipped; finished in 512.40s

Ran 2 test suites: 24 tests passed, 0 failed, 0 skipped (24 total tests)

Good to handover :shipit: