2023-09-27 Mainnet Spell

[amusingaxl]

Description

Contribution Checklist

• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[0xdecr1pto]

Mainnet 2023-09-27

Spell Actions (Per Exec Sheet):

• [x] RWA007-A (Clydesdale) DAO Resolution
  • [x] Update the Doc variable for RWA007-A (Clydesdale) to QmWo3UVtEDKVwS5k34uLt1J6u9px3rjHYkTLK2rYQ31E3G
  • [x] Approve the DAO Resolution with hashQmZ94FG8YXK4seyBHBi2FfTfW5URtBqbCb7JZAB1HGkTNF
• [x] RWA-009A (HV Bank) DAO Resolution
  • [x] Update the Doc variable for RWA009-A (HV Bank) to QmYjvAZEeGCs8kMuLQz6kU8PWgsbG1i8QWd2jrwkSipcRx
• [x] Place the RWA005-A (Fortunafi) vault into "Soft Liquidation"
  • [x] Call tell() from RWA005-A (Fortunafi)
• [x] Spark Protocol (Main spell)
  • [x] Mainnet - 0x9FfFbc278119Ad854b58C3d219212849E8B54eF8

Development Stage

• [x] Office Hours

  • [x] OFF
  • [x] Matches Exec Doc

• [x] 30 days spell expiry in constructor (block.timestamp + 30 days)

• [x] Exec Doc Hash

  • [x] Search the 'Community' GitHub repo for the corresponding Exec Doc
  • [x] Click 'History' for the corresponding Exec Doc
  • [x] Ensure Exec Doc file name follows the format Executive vote - Month DD, YYYY.md
  • [x] Click 'View at this point in the history' (the file icon with < >) for the latest commit
  • [x] Click 'Raw' and copy the resulting URL https://raw.githubusercontent.com/makerdao/community/c0eb5feb51cf5a8d0dcdcd4436976d3b4f3da913/governance/votes/Executive%20vote%20-%20September%2027%2C%202023.md
  • [x] Generate Exec Doc Hash using this URL
  • [x] Automatically: using make exec-hash $URL
  • [x] Manually: using cast keccak -- "$(curl '$URL' -o - 2>/dev/null)" 0x3906bcfefa6d515aae83aba7dae150afde5772699e6a0741f3e89d344315aa36

• [x] Spell Description

  • [x] Description follows the format TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH)
  • [x] Target date in description matches the Exec Doc target date
  • [x] Exec Doc Hash in description matches your locally generated Exec Doc Hash
  • [x] Accompanying comment above spell description
  • [x] Comment follows the format // Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"
  • [x] Exec Doc URL in comment matches your Raw Exec Doc URL
  • [x] Exec Doc URL in comment refers to the 'Community' GitHub repo

• [x] Local Environment Actions

  • [x] Update Foundry by running foundryup
  • [x] Reinstall libraries
  • [x] Remove libraries by deleting the lib folder
  • [x] Install libraries using git submodule update --init --recursive

    Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
    Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f77'
    Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
    Submodule path 'lib/dss-test': checked out '4ad127cf53eeaddfb7b8ad56dd4b13e57d6a0067'
    Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-test/lib/forge-std': checked out 'aea0b2685bebc883c09f5554d7fb481e85d0564d'
    Submodule path 'lib/dss-test/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'

  • [x] Library Checks
  • [x] dss-exec-lib
    • [x] If submodule upgrades are present make sure dss-exec-lib is synced as well
    • [ ] (Non-critical) Submodule hash matches the latest release version (NOTE: dss-exec-lib as installed locally will use GitHub code more recent than the 0.0.9 release until the 0.0.10 release)
  • [ ] dss-test
    • [ ] dss-interfaces
    • [ ] (Non-critical) Submodule hash matches version used by dss-test
    • [ ] (Non-critical) Submodule hash matches version used by dss-exec-lib
    • [ ] forge-std
    • [ ] (Non-critical) Submodule hash matches version used by dss-test
    • [ ] (Non-critical) Submodule hash matches version used by dss-exec-lib

• [x] Interface Checks

  • [x] dss-interfaces

  • [ ] used in the current spell

  • [x] cleanup previous ones

  • [ ] ensure only single import layout is used (e.g. import "dss-interfaces/dss/VatAbstract.sol";)

  • [x] Static Interfaces

  • [x] ensure they match dss-interfaces (Where there is a mismatch, use cast interface as the source of truth)

  • [x] check on-chain interface of deployed contract via cast interface <contract_address> to ensure correctness

  • [x] interface naming style should match with Like suffix (e.g. VatLike), with some exceptions

  • [x] ensure they only list used functions in spell code

  • [x] Address Immutables

  • [x] Use the DssExecLib Core Address Helpers instead of getChangelogAddress() whenever possible (e.g. DssExecLib.vat())

  • [x] Follow pattern address internal immutable KEY_NAME = DssExecLib.getChangelogAddress(KEY_NAME)

  • [x] Variable name matches ChainLog key name

    • [x] Exceptions must follow archive patterns (e.g. MKR for MCD_GOV)

  • [x] Instantiate as address type

    • [x] Exceptions must follow archive patterns (e.g. GemLike for MKR)

  • [x] Visibility is internal

  • [x] State mutability is immutable

• [x] String constant

  • [x] IPFS hashes or DAO resolutions
  • [x] RWA007-A (Clydesdale) DAO Resolution -> QmZ94FG8YXK4seyBHBi2FfTfW5URtBqbCb7JZAB1HGkTNF

• [x] RWA Updates

  • [x] doc update for RWA009-A

  • [x] init the RwaLiquidationOracle to reset the doc

  • [x] Sanity Check pip must be set (not the zero address)

  • [x] ilk follows format "RWA009-A"

  • [x] val price ignored (0) if init has already been called

  • [x] doc new legal document (IPFS HASH) matches Doc (or Forum Post)

  • [x] tau parameter used is the old tau value

  • [x] doc update for RWA007-A

  • [x] init the RwaLiquidationOracle to reset the doc

  • [x] Sanity Check pip must be set (not the zero address)

  • [x] ilk follows format "RWA007-A"

  • [x] val price ignored (0) if init has already been called

  • [x] doc new legal document (IPFS HASH) matches Doc (or Forum Post)

  • [x] tau parameter used is the old tau value

  • [x] Place the RWA005-A (Fortunafi) vault into "Soft Liquidation"

  • [x] Calling tell for liquidation OK, tell is used

• [x] SubDAO Content

  • [x] SubDAO SubProxy spell execution
  • [x] SubDAO spell address matches Exec Doc
  • [ ] SubDAO spell deployer is a smart contract (e.g. multisig or factory)
    • [ ] Ensure the deployer address is in addresses_deployers.sol as an entry
  • [x] SubDAO spell deployer is purely an EOA
    • [x] Ensure the deployer address is in addresses_deployers.sol as a comment
  • [x] Executed using ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
  • [x] Execution is NOT delegate call
  • [x] Reviewer Note: Gas cost may be very high as SubDAO spells execute within the main cast execution. (Also note that low level call gas estimation is not done by our scripts)

• [x] addresses_mainnet.sol matches spell code

• [x] Ensure every spell variable is declared as public/internal

• [x] Spell actions match the corresponding Exec Doc

• [x] Tests

  • [x] Ensure each spell action has sufficient test coverage
  • [x] Update doc variable for RWA009-A & RWA007-A
  • [x] Call tell() from RWA005-A
  • [x] Trigger Spark Proxy Spell is tested via testSparkSpellIsExecuted
  • [x] Ensure every test function is declared as public if enabled or private if disabled
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit c4c1c28
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

    
    Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
    [⠔] Compiling...
    No files changed, compilation skipped

Running 2 tests for src/test/starknet.t.sol:StarknetTests [PASS] testStarknet() (gas: 688029) [PASS] testStarknetSpell() (gas: 2346) Test result: ok. 2 passed; 0 failed; finished in 15.75s

Running 21 tests for src/DssSpell.t.sol:DssSpellTest [PASS] testAuth() (gas: 9223371487105923956) [PASS] testAuthInSources() (gas: 9223371487099527378) [PASS] testBytecodeMatches() (gas: 1869176) [PASS] testCastCost() (gas: 533466) [PASS] testChainlogValues() (gas: 9408004) [PASS] testChainlogVersionBump() (gas: 4171503) [PASS] testContractSize() (gas: 8962) [PASS] testDeployCost() (gas: 1856194) [PASS] testFailNotScheduled() (gas: 14420) [PASS] testFailTooEarly() (gas: 13585) [PASS] testFailTooLate() (gas: 13584) [PASS] testFailWrongDay() (gas: 13607) [PASS] testGeneral() (gas: 35531404) [PASS] testNextCastTime() (gas: 353637) [PASS] testOnTime() (gas: 529128) [PASS] testPSMs() (gas: 1976038) [PASS] testRWA005OracleTell() (gas: 545933) [PASS] testRWA007DocChange() (gas: 595869) [PASS] testRWA009DocChange() (gas: 595913) [PASS] testSparkSpellIsExecuted() (gas: 532664) [PASS] testUseEta() (gas: 352346) Test result: ok. 21 passed; 0 failed; finished in 632.28s

[SidestreamSweatyPumpkin]

Good to deploy (since after my review the comment under https://github.com/makerdao/spells-mainnet/pull/367#discussion_r1340192555 is addressed)

[0xdecr1pto]

Good to deploy

[SidestreamSweatyPumpkin]

Summary

• The evm version on etherscan shows london instead of default. Please provide reason to this if you're aware of it

Other than the point above, no problems noticed.

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [ ] Other Settings: default evmVersion, GNU AGPLv3 license
  • ⚠️ london evm version
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell)
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • [x] Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
  • [x] deployed_spell_created matches deployment timestamp
  • [x] deployed_spell_block matches deployment block number
  • [x] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [x] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target Exec Doc date)
  • [x] Ensure date corresponds to target Exec Doc date
• [x] Tests
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit https://github.com/makerdao/spells-mainnet/pull/367/commits/351d78ed5e796ec08b7d6206104562cdc9a67b2f
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠑] Compiling...
[⠔] Compiling 5 files with 0.8.16
[⠢] Solc 0.8.16 finished in 1.79s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 688029)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 15.45s

Running 21 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487105923956)
[PASS] testAuthInSources() (gas: 9223371487099527378)
[PASS] testBytecodeMatches() (gas: 1869176)
[PASS] testCastCost() (gas: 533466)
[PASS] testChainlogValues() (gas: 9408004)
[PASS] testChainlogVersionBump() (gas: 4171503)
[PASS] testContractSize() (gas: 8962)
[PASS] testDeployCost() (gas: 1856194)
[PASS] testFailNotScheduled() (gas: 14420)
[PASS] testFailTooEarly() (gas: 13585)
[PASS] testFailTooLate() (gas: 13584)
[PASS] testFailWrongDay() (gas: 13607)
[PASS] testGeneral() (gas: 35533501)
[PASS] testNextCastTime() (gas: 353637)
[PASS] testOnTime() (gas: 529128)
[PASS] testPSMs() (gas: 1976038)
[PASS] testRWA005OracleTell() (gas: 545933)
[PASS] testRWA007DocChange() (gas: 595869)
[PASS] testRWA009DocChange() (gas: 595913)
[PASS] testSparkSpellIsExecuted() (gas: 532664)
[PASS] testUseEta() (gas: 352346)
Test result: ok. 21 passed; 0 failed; 0 skipped; finished in 911.80s

Ran 2 test suites: 23 tests passed, 0 failed, 0 skipped (23 total tests)

[SidestreamSweatyPumpkin]

In previous spell https://github.com/makerdao/spells-mainnet/pull/365 the evm version was also london after deployment.

• Me (prev spell crafter) with @amusingaxl both did not change deployment processes
• @SidestreamColdMelon explicitly OKyed the london version in the last spell.

This issue requires further looking into and requires investigation regarding why the etherscan now shows different evm version on latest spells. I as reviewer here do not consider the different version strong enough reason to block the further progress of the spell here due to:

1. both other spell process participants are also fine with moving on with this spell - this means @0xdecr1pto should agree with me here, @amusingaxl should agree with me here.
2. @SidestreamColdMelon has already OKyed the london (see above) - no action needed here.

[0xdecr1pto]

In previous spell #365 the evm version was also london after deployment.

• Me (prev spell crafter) with @amusingaxl both did not change deployment processes
• @SidestreamColdMelon explicitly OKyed the london version in the last spell.

This issue requires further looking into and requires investigation regarding why the etherscan now shows different evm version on latest spells. I as reviewer here do not consider the different version strong enough reason to block the further progress of the spell here due to:

1. both other spell process participants are also fine with moving on with this spell - this means @0xdecr1pto should agree with me here, @amusingaxl should agree with me here.
2. @SidestreamColdMelon has already OKyed the london (see above) - no action needed here.

aggree

[0xdecr1pto]

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [ ] Other Settings: default evmVersion, GNU AGPLv3 license
    • london evm is used
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell)
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • [x] Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
  • [x] deployed_spell_created matches deployment timestamp
  • [x] deployed_spell_block matches deployment block number
  • [x] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [x] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target Exec Doc date)
  • [x] Ensure date corresponds to target Exec Doc date
• [x] Tests
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit 351d78e
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

[amusingaxl]

Regarding the EVM version issue, I spent some time digging into it. I didn't find any explicit mention to this issue out there. Maybe it's related to us still using dapp.tools for verification or Etherscan changing something on their side 🤷🏻‍♂️.

Regarding the last spells, I checked 2 months worth of spells and apparently the issue started on Aug 18th.

Spells showing "London" as EVM version:

• Sep 13th: https://etherscan.io/address/0xD97B4e0b43708c836935c9b2320f57074DC1D146#code
• Aug 30th: https://etherscan.io/address/0xf9a88bBABBe4b5b907D28322649c504cA9897892#code
• Aug 18th: https://etherscan.io/address/0x2f34BB0FE10BCb5652390FD0bA3Af7879BcA4b62#code

Spells showing "default" EVM version:

• Aug 2nd: https://etherscan.io/address/0x73603dB34814b22379CeD3d2Cbb450B3968Fd892#code
• Jul 14th: https://etherscan.io/address/0x402D46A20C849390Da96CeB0C3c04832D29e87d7#code
• Jun 28th: https://etherscan.io/address/0x07D8D43916bc235B71d9683111De7c7c626Bb906#code

I also verified the current spell on Sourcify: https://repo.sourcify.dev/contracts/partial_match/1/0xD3F96B8Ffbf21033F5A6210C6349598AAdBd1152/metadata.json

However, it does not show any info regarding the EVM version :/

[SidestreamSweatyPumpkin]

Handover and Merge Stage

• [x] Check that the spell address posted by the crafter in new-spells is correct
  • [x] Confirm the address in new-spells (via a thumbs up message reaction, )
• [x] Ensure that no commits or changes have occurred since the spell was deployed and archived
• [x] Approve spell PR for merge via 'Approve' review option