Mainnet spell 2023-11-01

[SidestreamSweatyPumpkin]

Description

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[SidestreamColdMelon]

TLDR: ready to deploy after two nits from above are addressed

Mainnet 2023-11-01

Spell Actions (Per Exec Doc):

• Read spell actions and instructions from the Exec Doc
• List the actions being performed in this spell
• [x] Maker Governance will execute a payment from the Surplus Buffer of 2889 DAI to a smart contract (0x464C71f6c2F760DdA6093dCB91C24c39e5d6e18c) controlled by Aave Governance
• [x] DAO Resolution with the IPFS hash of QmbrCPtpKsCaQ2pKc8qLnkL8TywRYcKHYaX6LEzhhKQqAw will be approved
• [x] a one-time MKR payment in the amount of 6.34 MKR will be transferred to the Core Unit's Auditor Wallet (0xd1F2eEf8576736C1EbA36920B957cd2aF07280F4)
• [x] If this executive proposal passes, these contracts will be added to the Chainlog as:
  • MCD_PSM_GUSD_A_JAR
  • MCD_PSM_GUSD_A_INPUT_CONDUIT_JAR
  • MCD_PSM_PAX_A_JAR
  • MCD_PSM_PAX_A_INPUT_CONDUIT_JAR Further, <conduit>.rely(MCD_ESM) will be called on the SwapInputConduit contracts to allow the ESM module to deny the pause proxy. In the event of a successful governance attack, this prevents funds from being stolen from the SwapInputConduit contracts.

Development Stage

• [x] Office Hours
  • [ ] On (Collateral Onboarding, Keepers, Integrations, ...)
  • [x] Matches Exec Doc
• [x] 30 days spell expiry in constructor (block.timestamp + 30 days)
• [x] Exec Doc Hash
  • [x] Search the 'Community' GitHub repo for the corresponding Exec Doc
  • [x] Ensure Exec Doc file name follows the format Executive vote - Month DD, YYYY.md
  • [x] Extract permanent raw Url link via Github Insert your Raw Exec Doc URL here https://raw.githubusercontent.com/makerdao/community/99f49009e6e68b2178d621a31578d2e0156fb1cd/governance/votes/Executive%20vote%20-%20November%201%2C%202023.md
  • [x] Generate Exec Doc Hash using this URL
  • [x] Automatically: using make exec-hash $URL
  • [x] Manually: using cast keccak -- "$(curl '$URL' -o - 2>/dev/null)" Insert your Exec Doc Hash here 0x7bd6e83fdbc0f2eef6beea87f626af067630a8e3a375dca68fb2bf2df19cec62
• [x] Spell Description
  • [x] Description follows the format TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH)
  • [x] Target date in description matches the Exec Doc target date
  • [x] Exec Doc Hash in description matches your locally generated Exec Doc Hash
  • [x] Accompanying comment above spell description
  • [x] Comment follows the format // Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"
  • [ ] Exec Doc URL in comment matches your Raw Exec Doc URL ⚠️ Exec url doesn't match as it uses a later commit (which is fine as this does not affect content of the file and the produced hash)
  • [x] Exec Doc URL in comment refers to the 'Community' GitHub repo
• [x] Local Environment Actions
  • [x] Update Foundry by running foundryup
  • [x] Reinstall libraries
  • [x] Remove libraries by deleting the lib folder
  • [x] Install libraries using git submodule update --init --recursive

    Insert checked out submodule paths here
    Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
    Submodule path 'lib/dss-test': checked out '4ad127cf53eeaddfb7b8ad56dd4b13e57d6a0067'

  • [x] Dependency checks
  • [x] dss-exec-lib
    • [ ] if submodule upgrades are present make sure dss-exec-lib is synced as well
    • [x] git submodule hash (run git submodule status) matches the latest release version or newer (NOTE: dss-exec-lib as installed locally will use GitHub code more recent than the 0.0.9 release)
  • [x] dss-test
    • [x] dss-interfaces
    • [x] git submodule hash matches version used by dss-test (Non-critical)
    • [x] forge-std
    • [ ] git submodule hash matches version used by dss-test (Non-critical) ⚠️ Doesn't match: forge-std used by linked dss-test is at aea0b26 commit, while forge-std used by linked dss-exec-lib is at 0aa99eb commit
• [x] Interface Checks
  • [x] dss-interfaces
  • [x] used in the current spell
  • [x] cleanup previous ones
  • [x] ensure only single import layout is used (e.g. import "dss-interfaces/dss/VatAbstract.sol";)
  • [ ] Static Interfaces
  • [ ] ensure they match dss-interfaces (Where there is a mismatch, use cast interface as the source of truth)
  • [ ] check on-chain interface of deployed contract via cast interface <contract_address> to ensure correctness
  • [ ] interface naming style should match with Like suffix (e.g. VatLike), with some exceptions
  • [ ] ensure they only list used functions in spell code
• [ ] Rate constants used are correct
  • [ ] Manual check 1: using make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
  • [ ] Manual check 2: Compare against IPFS
  • [ ] Variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)
  • [ ] Variable visibility declared as internal
  • [ ] State mutability declared as constant
• [ ] Constants Match
  • [ ] Precision unit constants used match their defined values
  • [ ] WAD = 10 ** 18
  • [ ] RAY = 10 ** 27
  • [ ] RAD = 10 ** 45
  • [ ] Variable visibility declared as internal
  • [ ] State mutability declared as constant
  • [ ] Ensure they match with ds-math and the Numerical Ranges
  • [ ] Math unit constants used match their defined values
  • [ ] HUNDRED = 10 ** 2
  • [ ] THOUSAND = 10 ** 3
  • [ ] MILLION = 10 ** 6
  • [ ] BILLION = 10 ** 9
  • [ ] Variable visibility declared as internal
  • [ ] State mutability declared as constant
  • [ ] Ensure they match with config
  • [ ] Timestamp constants used are correct
  • [ ] Ensure the timestamp converts to the correct date
  • [ ] Variable naming matches MONTH_DD_YYYY (e.g. MAY_01_2023 for 2023-05-01)
  • [ ] Time of day makes logical sense (i.e. 23:59:59 for the final day of something, 00:00:00 for the first day of something) in the context of timestamp usage
  • [ ] Variable visibility declared as internal
  • [ ] State mutability declared as constant
• [x] Deployed Contracts (not yet on chainlog or new to chainlog)
  • For the MCD_PSM_GUSD_A_JAR
  • [x] Verified on etherscan
  • [x] Optimizations match Repo
  • [x] GNU AGPLv3 license
  • [x] Constructor args ok (e.g. vat, dai, dog, ...)
    • chainlog is correct
    • [x] Match ChainLog
  • [ ] Wards ok (pause proxy relied, deployer denied)
    • [ ] MCD_ESM is already relied / being relied in this spell (as approved by Governance Facilitators) in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy. ⚠️ There are no wards
  • [x] Matches corresponding github source code (i.e. diffcheck via vscode code --diff etherscan.sol github.sol) https://github.com/makerdao/rwa-toolkit/blob/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/jars/RwaJar.sol
  • [x] Ensure deployer address is included into addresses_deployers.sol (to keep up to date) Matches existing 0x45Ea4FADf8Db54DF5a96774167547893e0b4D6A5, // CES from 2022-10-26
  • For the MCD_PSM_GUSD_A_INPUT_CONDUIT_JAR
  • [x] Verified on etherscan
  • [x] Optimizations match Repo
  • [x] GNU AGPLv3 license
  • [x] Constructor args ok (e.g. vat, dai, dog, ...)
    • dai matches MCD_DAI
    • gem matches GUSD as in the name
    • psm matches MCD_PSM_GUSD_A
    • to matches MCD_PSM_GUSD_A_JAR from above
    • [x] Match ChainLog
  • [x] Wards ok (pause proxy relied, deployer denied)
    • [x] MCD_ESM is already relied / being relied in this spell (as approved by Governance Facilitators) in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy.
  • [x] Matches corresponding github source code (i.e. diffcheck via vscode code --diff etherscan.sol github.sol) https://github.com/makerdao/rwa-toolkit/blob/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/conduits/RwaSwapInputConduit2.sol
  • [x] Ensure deployer address is included into addresses_deployers.sol (to keep up to date) Matches existing 0x45Ea4FADf8Db54DF5a96774167547893e0b4D6A5, // CES from 2022-10-26
  • For the MCD_PSM_PAX_A_JAR
  • [x] Verified on etherscan
  • [x] Optimizations match Repo
  • [x] GNU AGPLv3 license
  • [x] Constructor args ok (e.g. vat, dai, dog, ...)
    • chainlog is correct
    • [x] Match ChainLog
  • [ ] Wards ok (pause proxy relied, deployer denied)
    • [ ] MCD_ESM is already relied / being relied in this spell (as approved by Governance Facilitators) in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy. ⚠️ There are no wards
  • [x] Matches corresponding github source code (i.e. diffcheck via vscode code --diff etherscan.sol github.sol) https://github.com/makerdao/rwa-toolkit/blob/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/jars/RwaJar.sol
  • [x] Ensure deployer address is included into addresses_deployers.sol (to keep up to date) Matches existing 0xb27B6fa77D7FBf3C1BD34B0f7DA59b39D3DB0f7e, // CES
  • For the MCD_PSM_PAX_A_INPUT_CONDUIT_JAR
  • [x] Verified on etherscan
  • [x] Optimizations match Repo
  • [x] GNU AGPLv3 license
  • [x] Constructor args ok (e.g. vat, dai, dog, ...)
    • dai matches MCD_DAI
    • gem matches PAX as in the name
    • psm matches MCD_PSM_PAX_A
    • to matches MCD_PSM_PAX_A_JAR from above
    • [x] Match ChainLog
  • [x] Wards ok (pause proxy relied, deployer denied)
    • [x] MCD_ESM is already relied / being relied in this spell (as approved by Governance Facilitators) in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy.
  • [x] Matches corresponding github source code (i.e. diffcheck via vscode code --diff etherscan.sol github.sol) https://github.com/makerdao/rwa-toolkit/blob/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/conduits/RwaSwapInputConduit2.sol
  • [x] Ensure deployer address is included into addresses_deployers.sol (to keep up to date) Matches existing 0xb27B6fa77D7FBf3C1BD34B0f7DA59b39D3DB0f7e, // CES
• [ ] Core System Parameter Changes
  • [ ] Stability Fee jug.ilk.duty (setIlkStabilityFee)
  • [ ] Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%.
  • [ ] Dai Savings Rate pot.dsr (setDSR)
  • [ ] Double check that PCT_RATE is correct
    • [ ] Check manually via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
    • [ ] Compare against IPFS
  • [ ] spotter.ilk.mat (liquidationRatio)
  • [ ] dog.ilk.hole (setIlkMaxLiquidationAmount)
  • [ ] vat.ilk.dust(setIlkMinVaultAmount)
  • [ ] dog.ilk.chop (liquidationPenalty)
  • [ ] clip.buf (startingPriceFactor)
  • [ ] clipperMom.clip.tolerance (setLiquidationBreakerPriceTolerance)
  • [ ] clip.tail (auctionDuration)
  • [ ] clip.cusp (permittedDrop)
  • [ ] clip.chip (kprPctReward)
  • [ ] clip.tip(kprFlatReward)
  • [ ] calc.tau (setLinearDecrease)
  • [ ] setStairstepExponentialDecrease
  • [ ] calc.cut
  • [ ] calc.step
• [ ] Debt Ceiling Changes
  • [ ] vat.ilk.line changes (per ilk)
  • [ ] Collateral type (ilk) is not RWAXXX (For RWA refer to the designated section of the checklist)
  • [ ] Either is used depending on the EXEC DOC contents:
    • [ ] setIlkDebtCeiling
      • [ ] ilk
      • [ ] line
    • [ ] increaseIlkDebtCeiling
      • [ ] ilk
      • [ ] amount
      • [ ] global
    • [ ] decreaseIlkDebtCeiling
      • [ ] ilk
      • [ ] amount
      • [ ] global
  • [ ] vat.Line changes (Global Line)
    • [ ] Either is used:
      • [ ] setGlobalDebtCeiling
        • [ ] amount
      • [ ] increaseGlobalDebtCeiling
        • [ ] amount
      • [ ] decreaseGlobalDebtCeiling
        • [ ] amount
  • [ ] Autoline Changes
  • [ ] setIlkAutoLineDebtCeiling
    • [ ] ilk
    • [ ] line
  • [ ] setIlkAutoLineParameters
    • [ ] ilk
    • [ ] line
    • [ ] gap
    • [ ] ttl
• [ ] Onboarding (insert relevant checklists inline here)
  • [ ] Collateral Onboarding
  • [ ] RWA Onboarding
  • [ ] Teleport Onboarding
• [ ] Offboarding (Lerp mat)
  • [ ] 1st Stage Spell Actions
  • [ ] Remove Ilk from Autoline
  • [ ] Set Ilks Debt Ceilings to 0
  • [ ] Cache Ilks line to Reduce in the Global Debt Ceiling
  • [ ] Decrease Global Debt Ceiling by Total Amount of Offboarded Ilks line Cached
  • [ ] 2nd Stage Spell Actions
  • [ ] Set Ilk Liquidation Penalty chop to 0
  • [ ] Set Keeper Incentive Flat Rate tip to 0
  • [ ] Check IF chip is required to be adjusted as well
  • [ ] Use DssExecLib.linearInterpolation
    • [ ] name Format matches "XXX-A Offboarding"
    • [ ] target matches spotter
    • [ ] ilk Format matches "XXX-A"
    • [ ] what matches mat
    • [ ] startTime matches block.timestamp
    • [ ] start matches Var CURRENT_XXX_A_MAT
    • [ ] end matches Var TARGET_XXX_A_MAT (Match Exec Doc & Risk Computations)
    • [ ] Check IF Target mat Covers All Remaining Vaults CR times Risk Multiplier Factor
    • [ ] duration matches Exec Doc
• [ ] RWA Updates
  • [ ] doc (Using the _updateDoc helper or otherwise)
  • [ ] init the RwaLiquidationOracle to reset the doc
  • [ ] Sanity Check pip must be set (not the zero address)
  • [ ] ilk follows format "RWAXXX-A"
  • [ ] val price ignored (0) if init has already been called
  • [ ] doc new legal document (IPFS HASH) matches Exec Doc
  • [ ] tau parameter used is the old tau value
  • [ ] Debt Ceiling changes (line)
  • [ ] Autoline (line) + Liquidation Oracle Price Bump (val)
    • [ ] Enable Autoline
    • [ ] ilk follows format "RWAXXX-A"
    • [ ] line (max debt ceiling)
    • [ ] gap
    • [ ] ttl
  • [ ] Debt Ceiling (line) + Liquidation Oracle Price Bump (val)
    • [ ] Increase Ilk Debt Ceiling (set DC + increase Global DC)
  • [ ] bump RwaLiquidationOracle with new computed increased price (val)
    • [ ] ensure val is set accordingly with autoline max debt ceiling (line)
    • [ ] val should enable DAI to be drawn over the loan period while taking into account the configured ink amount, interest rate and liquidation ratio (see below)
    • [ ] New val is calculated with line * [(1 + duty) ** years] * mat - rounded up - and makes sense in context of the rate mechanism. Minimum duration is usually in the Exec Doc of the spell with the RWAXXX ilk onboarding.
    • [ ] Comment explaining val formula (Debt ceiling * [ (1 + RWA stability fee ) ^ (minimum deal duration in years) ] * liquidation ratio) is present
    • [ ] Accompanying comment above bump line in format // XXM * 1.XX^X * X.XX as a WAD corresponding to the val calculation formula (e.g. // 15M * 1.03^2 * 1.00 as a WAD) is present along with the calculation formula on the line above
    • [ ] IF combining val of multiple RWA ilks being combined, val calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal.
  • [ ] Poke spotter to pull in the new price
  • [ ] Soft Liquidation (tell)
    • [ ] Call RwaLiquidationOracle.tell(ilk)
    • [ ] IF RWAXX_A_INPUT_CONDUIT is an instance of TinlakeMgr (it is a Centrifuge integration)
    • [ ] Call TinlakeMgr.tell() to prevent further TIN redemptions in the Centrifuge pool.
• [x] Payments
  • [x] MKR transfers
  • [x] Recipient addresses match Exec Doc
  • [x] Transfer values match Exec Doc
    • [x] All values are specified with at least 2 decimals
    • [x] Sum of all values matches Exec Doc ⚠️ Sum amount is not present in the Exec Doc, but since there is only a single MKR transfer it can be skipped
  • [x] Follows archive patterns
  • [x] DAI Surplus Buffer transfers
  • [x] Recipient addresses match Exec Doc
  • [x] Transfer values match Exec Doc
    • [ ] All values are specified with 2 decimals ⚠️ This can't be done by design, the proposal is to remove this rule before the next spell
    • [x] Sum of all values matches Exec Doc ⚠️ Sum amount is not present in the Exec Doc, but since there is only a single DAI transfer it can be skipped
  • [x] Follows previous patterns
  • [ ] Create New MKR/DAI Streams (DssVest)
  • [ ] DssVestLike interface is correct
  • [ ] Check for all streams (MKR, DAI)
    • [ ] restrict is used for each stream unless otherwise stated in the Exec Doc
    • [ ] usr (Vest recipient address) matches Exec Doc
    • [ ] tot (Total stream amount) matches Exec Doc
    • [ ] Use ether to express decimal (non-integer) values of tot
    • [ ] Where vest amount is expressed in 'per year' or similar in the Exec Doc, account for leap days
    • [ ] bgn (Vest start timestamp) matches Exec Doc
    • [ ] tau (Vest total duration) matches Exec Doc
    • [ ] tau is expressed as 'bgn - fin' (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
    • [ ] fin (Vest end timestamp) matches Exec Doc
    • [ ] eta (Vest cliff duration) matches Exec Doc
    • [ ] If the Exec Doc does not specify a cliff date (clf), eta is 0
    • [ ] clf (Cliff end timestamp) matches Exec Doc
    • [ ] If clf <= bgn, eta is 0
    • [ ] If clf > bgn
      • [ ] eta is expressed as 'clf - bgn' (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
    • [ ] mgr (Vest manager address) matches Exec Doc
    • [ ] If the Exec Doc does not specify a manager address, mgr is address(0)
  • [ ] Max vesting rate (cap) check (MKR, DAI)
    • [ ] The maximum vesting rate (tot divided by tau) <= the maximum vest streaming rate (cap)
    • [ ] The maximum vesting rate (tot divided by tau) > the maximum vest streaming rate (cap)
    • [ ] Calculate new cap value equal to 10% greater than the new maximum vesting rate
    • [ ] Round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)
    • [ ] Notify Governance Facilitators for addition in Exec Doc AND Exec Sheet
    • [ ] Ensure that cap change is noted in the Exec Doc
    • [ ] New cap value matches Exec Doc
  • [ ] MKR Streams (DssVestTransferrable)
    • [ ] Increase vest contract's MKR allowance by the cumulative tot (total of new MKR vest amounts)
    • [ ] Ensure allowance increase follows archive patterns
  • [ ] Terminate Existing MKR/DAI Streams (Yank)
  • [ ] Yanked stream ID matches Exec Doc
  • [ ] Use MCD_VEST_MKR_TREASURY for MKR yank
  • [ ] Use MCD_VEST_DAI for DAI yank
  • [ ] Ensure Recipient Addresses match addresses_wallets.sol
• [ ] SubDAO Content
  • [ ] SubDAO SubProxy spell execution
  • [ ] SubDAO spell address matches Exec Doc
  • [ ] IF SubDAO spell deployer is a smart contract (e.g. multisig or factory)
    • [ ] Ensure the deployer address is in addresses_deployers.sol as an entry
  • [ ] Executed using ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
  • [ ] Execution is NOT delegate call
  • [ ] Reviewer Note: Gas cost may be very high as SubDAO spells execute within the main cast execution. (Also note that low level call gas estimation is not done by our scripts)
  • [ ] Maker Core (main spell) SubDAO actions (i.e. operate in Pause Proxy DelegateCall context)
  • [ ] No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)
  • [ ] SubDAO contract licensing and optimizations generally do not matter (except where they pose a security risk)
  • [ ] SubDAO contracts and all libraries / dependencies are verified (Blocking if not true)
  • [ ] Upgradable SubDAO contracts
    • [ ] Any upgradable contracts have the PAUSE_PROXY as their admin (i.e. the party that can upgrade)
    • [ ] Any upgradable SubDAO contracts with an admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)
  • [ ] All SubDAO content addresses (i.e. provided contract addresses or EOAs) present in the Maker Core spell are present in the Exec Doc and are correct. SubDAO addresses being authed or given any permissions MUST be in the Exec Doc. SubDAO addresses being called must be confirmed by the SubDAO spell team.
    • [ ] IF addresses not PR'ed in by the SubDAO team (use git blame for example), SubDAO content addresses all have inline comment for provenance or source being OKed by SubDAO
  • [ ] SubDAO actions match Exec Doc (only where inline with main spell code) and do not affect core contracts
  • [ ] Core contract knock-on actions (such as offboarding or setting DC to 0) are present in the exec and match the code
  • [ ] External calls for SubDAO content are NOT delegate call
  • [ ] Code does not have untoward behavior within the scope of Maker Core Contracts (e.g. up to the SubDAO proxy)
• [ ] External Contracts Calls (Not SubDAOs, e.g. Starknet)
  • [ ] Target Contract don't block spell execution
  • [ ] External call is NOT delegate call
  • [ ] Target Contract doesn't have permissions on the Vat
  • [ ] Target Contract doesn't do anything untoward (e.g. interacting with unsafe contracts)
  • [ ] Contracts deployed via CREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their code
  • [ ] MCD Pause Proxy doesn't give any approvals
  • [ ] All possible actions of the Target Contract are documented
  • [ ] Target contract is not upgradable
  • [ ] Target Contract is included in the ChainLog
  • [ ] Test Coverage is comprehensive
• [x] ChainLog
  • [x] Increment ChainLog version based on update type
  • [ ] Major -> New Vat (++.0.0)
  • [ ] Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
  • [x] Patch -> Collateral addition or addition/modification (0.0.++)
• [x] addresses_mainnet.sol matches spell code
• [x] Ensure every spell variable is declared as public/internal
• [x] Ensure immutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress and constant is used instead for static addresses
  • [x] Fetch addresses as type address and wrap with Like suffix interfaces inline (when making calls) unless archive patterns permit otherwise (Such as MKR)
  • [x] Use the DssExecLib Core Address Helpers where possible (e.g. DssExecLib.vat())
  • [x] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)
• [x] Spell actions match the corresponding Exec Doc
• [x] Tests
  • [x] Ensure each spell action has sufficient test coverage List actions for which coverage was checked here
  • MKR transfers + sum of all
  • DAI surplus transfers + sum of all
  • 4 new chainlog keys
  • updated chainlog version
  • new ESM authorizations
  • [x] Ensure every test function is declared as public if enabled or private if disabled
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit Insert most recent commit hash where CI was passing f75b645
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

_Insert your passing local tests here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠃] Compiling...
No files changed, compilation skipped

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1012566)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 42.83s

Running 21 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487106283535)
[PASS] testAuthInSources() (gas: 9223371487099524853)
[PASS] testBytecodeMatches() (gas: 1778782)
[PASS] testCastCost() (gas: 860503)
[PASS] testChainlogValues() (gas: 9791059)
[PASS] testChainlogVersionBump() (gas: 3494415)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 1766070)
[PASS] testEsmAuth() (gas: 875495)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13584)
[PASS] testFailWrongDay() (gas: 13607)
[PASS] testGeneral() (gas: 35793958)
[PASS] testMKRPayments() (gas: 877486)
[PASS] testNewChainlogValues() (gas: 925619)
[PASS] testNextCastTime() (gas: 353659)
[PASS] testOnTime() (gas: 856165)
[PASS] testPSMs() (gas: 2204183)
[PASS] testPayments() (gas: 928311)
[PASS] testUseEta() (gas: 352346)
Test result: ok. 21 passed; 0 failed; 0 skipped; finished in 962.98s

Ran 2 test suites: 23 tests passed, 0 failed, 0 skipped (23 total tests)

[SidestreamColdMelon]

@0xp3th1um regarding your review. You've crossed out this section:

• [ ] Deployed Contracts (not yet on chainlog or new to chainlog)

But it's actually applicable to this spell: we have contracts that are "new to chainlog" and the reviewer need to follow those checks for each of the new contracts.

[SidestreamColdMelon]

✅ requested changes are applied ✅ no other content is changed since last review ✅ CI tests pass on 374473f ✅ local tests pass

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠃] Compiling...
[⠊] Compiling 6 files with 0.8.16
[⠒] Solc 0.8.16 finished in 2.09s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1012566)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 968.63s

Running 21 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487106283535)
[PASS] testAuthInSources() (gas: 9223371487099524853)
[PASS] testBytecodeMatches() (gas: 1778782)
[PASS] testCastCost() (gas: 860503)
[PASS] testChainlogValues() (gas: 9791059)
[PASS] testChainlogVersionBump() (gas: 3494415)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 1766070)
[PASS] testEsmAuth() (gas: 875495)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13584)
[PASS] testFailWrongDay() (gas: 13607)
[PASS] testGeneral() (gas: 35793958)
[PASS] testMKRPayments() (gas: 877486)
[PASS] testNewChainlogValues() (gas: 925619)
[PASS] testNextCastTime() (gas: 353659)
[PASS] testOnTime() (gas: 856165)
[PASS] testPSMs() (gas: 2204183)
[PASS] testPayments() (gas: 928656)
[PASS] testUseEta() (gas: 352346)
Test result: ok. 21 passed; 0 failed; 0 skipped; finished in 968.63s

Ran 2 test suites: 23 tests passed, 0 failed, 0 skipped (23 total tests)

Good to deploy from my side 👍

[0xp3th1um]

• I updated my review to include the deployed contracts added on CHANGELOG.
• The question related to DAI decimals has been addressed!
• The suggestion in https://github.com/makerdao/spells-mainnet/pull/369#discussion_r1380026752 has been addressed
• No other code changes have occurred
• CI and local tests passing in latest commit: https://github.com/makerdao/spells-mainnet/commit/374473f29ccef37cfe023eece6c37e03c083fa6d

Ready to deploy!

[SidestreamSweatyPumpkin]

deployed at

https://etherscan.io/address/0x77583dc3D6192D55eF642060e82Af1D7A34BC142#code

[SidestreamColdMelon]

TLDR: good to handover 👍

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license london EvmVersion
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell) ⚠️ Part of the verified code is different as in many previous spells: part of the DssExecLib is replaced by /* WARNING by the verification script, but it's expected
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • [x] Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
  • [x] deployed_spell_created matches deployment timestamp
  • [x] deployed_spell_block matches deployment block number
  • [x] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config ⚠️ The link in the check is misleading as it's pointing to the master branch, but the checks should be done against current spell branch
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [x] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release) ⚠️ Hash doesn't match as in many previous spells. Latest release v0.0.9 has hash of c0d3c6c made on Feb 1, 2022, while git submodule of lib/dss-exec-lib is set to track the latest commit 69b658f made on Jan 23, 2023
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target Exec Doc date)
  • [x] Ensure date corresponds to target Exec Doc date
• [x] Tests
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit Insert most recent commit hash where CI was passing aebdef8
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

_Insert your passing local tests here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠘] Compiling...
[⠑] Compiling 4 files with 0.8.16
[⠒] Solc 0.8.16 finished in 1.85s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1012566)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 42.97s

Running 21 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487106283535)
[PASS] testAuthInSources() (gas: 9223371487099524853)
[PASS] testBytecodeMatches() (gas: 1778782)
[PASS] testCastCost() (gas: 860503)
[PASS] testChainlogValues() (gas: 9791059)
[PASS] testChainlogVersionBump() (gas: 3494415)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 1766070)
[PASS] testEsmAuth() (gas: 875495)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13584)
[PASS] testFailWrongDay() (gas: 13607)
[PASS] testGeneral() (gas: 35796055)
[PASS] testMKRPayments() (gas: 877486)
[PASS] testNewChainlogValues() (gas: 925619)
[PASS] testNextCastTime() (gas: 353659)
[PASS] testOnTime() (gas: 856165)
[PASS] testPSMs() (gas: 2204183)
[PASS] testPayments() (gas: 928541)
[PASS] testUseEta() (gas: 352346)
Test result: ok. 21 passed; 0 failed; 0 skipped; finished in 955.21s

Ran 2 test suites: 23 tests passed, 0 failed, 0 skipped (23 total tests)

[0xp3th1um]

Good to handover!

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell)
  • ⚠️ There is an expected difference as in previous spells becuse part of the DssExecLib code is replaced
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • [x] Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
  • [ ] deployed_spell_created matches deployment timestamp
    • ⚠️ The script gives a wrong result on Mac, checked manually below
  • [ ] deployed_spell_block matches deployment block number
    • ⚠️ The script gives a wrong result on Mac, checked manually below
  • [x] manual checks
  • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] timestamp: 1698950939
    • [x] deployed_spell_block block number
    • [x] block: 18486279
  • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
  • ℹ️ Step below skipped, there is a current mismatch as in previous spells
  • [ ] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target Exec Doc date)
  • [x] Ensure date corresponds to target Exec Doc date

• [x] Tests

  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit Insert most recent commit hash where CI was passing https://github.com/makerdao/spells-mainnet/commit/aebdef8589a2ee7458dcae8f71587df1858b0788
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠑] Compiling...
No files changed, compilation skipped

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1012566)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 33.32s

Running 21 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487106283535)
[PASS] testAuthInSources() (gas: 9223371487099524853)
[PASS] testBytecodeMatches() (gas: 1778782)
[PASS] testCastCost() (gas: 860503)
[PASS] testChainlogValues() (gas: 9791059)
[PASS] testChainlogVersionBump() (gas: 3494415)
[PASS] testContractSize() (gas: 8984)
[PASS] testDeployCost() (gas: 1766070)
[PASS] testEsmAuth() (gas: 875495)
[PASS] testFailNotScheduled() (gas: 14375)
[PASS] testFailTooEarly() (gas: 13607)
[PASS] testFailTooLate() (gas: 13584)
[PASS] testFailWrongDay() (gas: 13607)
[PASS] testGeneral() (gas: 35796055)
[PASS] testMKRPayments() (gas: 877486)
[PASS] testNewChainlogValues() (gas: 925619)
[PASS] testNextCastTime() (gas: 353659)
[PASS] testOnTime() (gas: 856165)
[PASS] testPSMs() (gas: 2216245)
[PASS] testPayments() (gas: 928656)
[PASS] testUseEta() (gas: 352346)
Test result: ok. 21 passed; 0 failed; 0 skipped; finished in 1439.58s

Ran 2 test suites: 23 tests passed, 0 failed, 0 skipped (23 total tests)

[SidestreamSweatyPumpkin]

Notified the public.