Mainnet spell 2024-01-24

[SidestreamColdMelon]

Description

• This PR implements 2024-01-24 mainnet spell based on the relevant Exec Sheet
• This PR is a mainnet version of the relevant goerli spell

Contribution Checklist

• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[SidestreamStrongStrawberry]

Changes LGTM, hence good to deploy :)

[oddaf]

Agreed, good to deploy!

[SidestreamColdMelon]

The spell was deployed to https://etherscan.io/address/0x4242347798bD2DEc6540dF55E5e47802d9b78aC7#code

I've also created new Tenderly testnet with already casted spell. It can be used to test external dependencies via public rpc url, but also inspect cast transaction: https://dashboard.tenderly.co/explorer/vnet/56ac9c8b-21bc-4880-9ac5-8e3203902557

[SidestreamStrongStrawberry]

Good to cast :D Good to handover 🤝

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell) ⚠️ The command doesn't work for me, but manual check confirms that code matches
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • [x] Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
  • [x] deployed_spell_created matches deployment timestamp ⚠️ The command says it doesn't but manual check confirms that timestamp is correct
  • [x] deployed_spell_block matches deployment block number ⚠️ The command says it doesn't but manual check confirms that block number is correct
  • [x] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [x] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target Exec Doc date)
  • [x] Ensure date corresponds to target Exec Doc date
• [x] Tests
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit Insert most recent commit hash where CI was passing c0ac60fc4aceaf9b6b53d0140a3cb922031acc51
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

#_Insert your passing local tests here_

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠘] Compiling...
[⠆] Compiling 5 files with 0.8.16
[⠢] Solc 0.8.16 finished in 2.45s
Compiler run successful!

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1622957)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 317.60s

Running 23 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487106788559)
[PASS] testAuthInSources() (gas: 9223371487099505000)
[PASS] testBytecodeMatches() (gas: 2968483)
[PASS] testCastCost() (gas: 1468350)
[PASS] testChainlogValues() (gas: 10426559)
[PASS] testChainlogVersionBump() (gas: 4122019)
[PASS] testContractSize() (gas: 8962)
[PASS] testDaoResolutions() (gas: 13047)
[PASS] testDeployCost() (gas: 2952495)
[PASS] testEsmAuth() (gas: 1477865)
[PASS] testFailNotScheduled() (gas: 14428)
[PASS] testFailTooEarly() (gas: 417614)
[PASS] testFailTooLate() (gas: 417527)
[PASS] testFailWrongDay() (gas: 417595)
[PASS] testGeneral() (gas: 37347850)
[PASS] testIlkClipper() (gas: 1920992)
[PASS] testMKRPayments() (gas: 1556911)
[PASS] testNewChainlogValues() (gas: 1487054)
[PASS] testNextCastTime() (gas: 446739)
[PASS] testOnTime() (gas: 1464056)
[PASS] testPSMs() (gas: 2816880)
[PASS] testSparkSpellIsExecuted() (gas: 1467592)
[PASS] testUseEta() (gas: 352492)
Test result: ok. 23 passed; 0 failed; 0 skipped; finished in 1894.26s

Ran 2 test suites: 25 tests passed, 0 failed, 0 skipped (25 total tests)

[oddaf]

Good to handover:

Deployed Stage

• [x] Deployed Spell is Verified
  • [x] Optimization Enabled: No
  • [x] Other Settings: default evmVersion, GNU AGPLv3 license
• [x] Deployed Spell Code matches GitHub
  • [x] diffcheck etherscan source against spell PR (via make diff-deployed-spell) ⚠️ command fails but spell matches deployed.
• [x] Deployed Spell Etherscan Checks
  • [x] automated checks via make check-deployed-spell
  • [x] verified
  • [x] license type matches
  • [x] solc version matches
  • [x] optimizations are disabled
  • [x] dss-exec-lib library address used (under 'Libraries Used') matches the hardcoded local DssExecLib.address file
    • [x] Check again that the PR did not modify the DssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)
  • [x] deployed_spell_created matches deployment timestamp ⚠️ command fails but manually inspected and it matches.
  • [x] deployed_spell_block matches deployment block number ⚠️ command fails but manually inspected and it matches.
  • [x] manual checks
    • [x] Ensure make deploy-info tx=<tx> matches config
    • [x] deployed_spell_created timestamp
    • [x] deployed_spell_block block number
    • [x] Ensure Etherscan Libraries Used matches DssExecLib Latest Release
    • [x] (For your tests to be accurate) git submodule hash matches dss-exec-lib latest release's tag commit and inspect diffs if doesn't match to ensure expected behaviour (Currently Non-Critical pending the next DssExecLib release, double check that the ExecLib used by the contract matches the latest release)
• [x] Archive matches src
  • [x] make diff-archive-spell for current date or or date="YYYY-MM-DD" make diff-archive-spell (date as per target Exec Doc date)
  • [x] Ensure date corresponds to target Exec Doc date
• [x] Tests
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit Insert most recent commit hash where CI was passing c0ac60fc4aceaf9b6b53d0140a3cb922031acc51
  • [x] Check all tests are passing locally using make test
  • [x] Ensure that only ETH_RPC_URL is being used from env (i.e. no match, block or similar are active in your env)

_Insert your passing local tests here_

./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠆] Compiling...
No files changed, compilation skipped

Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1621462)
[PASS] testStarknetSpell() (gas: 2346)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 93.46s

Running 23 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testAuth() (gas: 9223371487106788559)
[PASS] testAuthInSources() (gas: 9223371487099505000)
[PASS] testBytecodeMatches() (gas: 2968483)
[PASS] testCastCost() (gas: 1466855)
[PASS] testChainlogValues() (gas: 10425064)
[PASS] testChainlogVersionBump() (gas: 4120524)
[PASS] testContractSize() (gas: 8962)
[PASS] testDaoResolutions() (gas: 13047)
[PASS] testDeployCost() (gas: 2952495)
[PASS] testEsmAuth() (gas: 1476370)
[PASS] testFailNotScheduled() (gas: 14428)
[PASS] testFailTooEarly() (gas: 417614)
[PASS] testFailTooLate() (gas: 417527)
[PASS] testFailWrongDay() (gas: 417595)
[PASS] testGeneral() (gas: 37346355)
[PASS] testIlkClipper() (gas: 1919497)
[PASS] testMKRPayments() (gas: 1555416)
[PASS] testNewChainlogValues() (gas: 1485559)
[PASS] testNextCastTime() (gas: 446739)
[PASS] testOnTime() (gas: 1462561)
[PASS] testPSMs() (gas: 2815385)
[PASS] testSparkSpellIsExecuted() (gas: 1466097)
[PASS] testUseEta() (gas: 352492)
Test result: ok. 23 passed; 0 failed; 0 skipped; finished in 1566.89s

Ran 2 test suites: 25 tests passed, 0 failed, 0 skipped (25 total tests)