Closed amusingaxl closed 3 months ago
The current implementation of testRemoveChainlogValues can generate false positives in case there is a typo in the key in the test file:
testRemoveChainlogValues
function testRemoveChainlogValues() public skipTest { // add the `skipTest` modifier to skip _vote(address(spell)); _scheduleWaitAndCast(address(spell)); assertTrue(spell.done(), "TestError/spell-not-done"); try chainLog.getAddress("MCD_CAT") { assertTrue(false); } catch Error(string memory errmsg) { assertTrue(_cmpStr(errmsg, "dss-chain-log/invalid-key")); } catch { assertTrue(false); } }
Ideally, we would want to query for any removed keys before the spell is executed and if they have been properly removed after that.
The current implementation of
testRemoveChainlogValues
can generate false positives in case there is a typo in the key in the test file:Ideally, we would want to query for any removed keys before the spell is executed and if they have been properly removed after that.