DaiFoundation-DevOps
commented
9 months ago
All committers have signed the CLA.
Closed oddaf closed 9 months ago
DaiFoundation-DevOps
commented
9 months ago
All committers have signed the CLA.
0xp3th1um
commented
9 months ago Preparation
[x] Exec Sheet for the specified date is found in the "Executive Vote Implementation Process" google sheet Insert URL to the specific sheet here https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/
[x] Exec Doc for the specified date is found in the makerdao/community GitHub repo
[x] Exec Doc file name follows the format Executive vote - Month DD, YYYY.md
[x] Extract permanent URL to the raw markdown file and paste it below Insert your Raw Exec Doc URL here https://raw.githubusercontent.com/makerdao/community/4fa152956a992fe19ce1e8cce89920fcf896b304/governance/votes/Executive%20vote%20-%20February%2007%2C%202024.md
[ ] Using Exec Doc URL from the above and the TARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL
⚠️ script is not working!
[x] Using Exec Doc URL from the above, generate Exec Doc Hash via cast keccak -- "$(curl '$URL' -o - 2>/dev/null)"
Insert your Exec Doc Hash here
0xeafae0d525faaab32a2e67aeef2aff3cd59b80b2c466553986fe72917f4b14b7
[x] Using Exec Doc URL from the above, read spell instructions from the Exec Doc and list them below List all instructions announced in the Exec Doc
[x] Auction Parameter Updates
[x] Increase the WSTETH-A Local Liquidation Limit (ilk.hole) by 15 million DAI from 15 million DAI to 30 million DAI.
[x] Increase the WSTETH-B Local Liquidation Limit (ilk.hole) by 10 million DAI from 10 million DAI to 20 million DAI.
[x] Decrease the WBTC-A Local Liquidation Limit (ilk.hole) by 20 million DAI from 30 million DAI to 10 million DAI.
[x] Decrease the WBTC-B Local Liquidation Limit (ilk.hole) by 5 million DAI from 10 million DAI to 5 million DAI.
[x] Decrease the WBTC-C Local Liquidation Limit (ilk.hole) by 10 million DAI from 20 million DAI to 10 million DAI.
[x] Increase the Global Liquidation Limit (Hole) by 50 million DAI from 100 million DAI to 150 million DAI.
[x] Push GUSD out of input conduit
[x] Aave SparkLend Revenue Share
[x] Transfer 100,603 DAI to 0x464C71f6c2F760DdA6093dCB91C24c39e5d6e18c
[x] RWA009 doc Update
[x] Update HVBank (RWA009-A) doc to QmPzuLuJ5Xq6k6Hbop1W5s4V9ksvafYoqcW9sU5QRwz5h1
[x] Delegate Compensation
[x] 0xDefensor - 41.67 MKR - 0x9542b441d65B6BF4dDdd3d4D2a66D8dCB9EE07a9
[x] BLUE - 41.67 MKR - 0xb6C09680D822F162449cdFB8248a7D3FC26Ec9Bf
[x] BONAPUBLICA - 41.67 MKR - 0x167c1a762B08D7e78dbF8f24e5C3f1Ab415021D3
[x] Cloaky - 41.67 MKR - 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818
[x] TRUE NAME - 41.67 MKR - 0x612F7924c367575a0Edf21333D96b15F1B345A5d
[x] PBG - 13.89 MKR - 0x8D4df847dB7FfE0B46AF084fE031F7691C6478c2
[x] UPMaker - 13.89 MKR - 0xbB819DF169670DC71A16F58F55956FE642cc6BcD
[x] vigilant - 13.89 MKR - 0x2474937cB55500601BCCE9f4cb0A0A72Dc226F61
[x] WBC - 13.89 MKR - 0xeBcE83e491947aDB1396Ee7E55d3c81414fB0D47
[x] JAG - 13.71 MKR - 0x58D1ec57E4294E4fe650D1CB12b96AE34349556f
[x] Ensure that instructions announced in the Exec Doc match instructions in the Exec Sheet
Base checks
0.8.16true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to falseblock.timestamp + 30 days)Spell description
TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASHTARGET_DATE in the description matches the Exec Doc target date// Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"Comments inside the spell
// ----- Section text -----)// Instruction text// Note: (e.g.: // Note: Payments are skipped on goerli)chainlog version bump), the necessity of it is explained in the comment above prefixed with // Note:Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)Reasoning URL and Authority URL have prefix derived from the url itself// Executive Vote: if URL starts with https://vote.makerdao.com/executive/// Poll: if URL starts with https://vote.makerdao.com/polling/// Forum: if URL starts with https://forum.makerdao.com/t/// MIP: if URL starts with https://mips.makerdao.com/mips/details/Dependency checks
foundryuprm -rf ./lib && git submodule update --init --recursive
Insert checked out submodule paths here
Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f77'
Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'
Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
Submodule path 'lib/dss-test/lib/forge-std': checked out '155d547c449afa8715f538d69454b83944117811'
Submodule path 'lib/dss-test/lib/forge-std/lib/ds-test': checked out 'e282159d5170298eb2455a6c05280ab5a73a4ef0'dss-exec-lib is synced as welldss-exec-lib (run git submodule status) matches the latest release version or newerdss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-testIF interfaces are present in the spell
dss-interfacesdss-interfacesimport "dss-interfaces/dss/VatAbstract.sol";)dss-interfaces, OTHERWISE should be imported from therecast interface <contract_address> commandLike suffix (e.g. VatLike)
IF variable declarations are present in the spell
WAD = 10 ** 18RAY = 10 ** 27RAD = 10 ** 45internalconstantHUNDRED = 10 ** 2THOUSAND = 10 ** 3MILLION = 10 ** 6BILLION = 10 ** 9internalconstantmake rates pct=<pct> (e.g. pct=0.75, for 0.75%)X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)internalconstantUTC timezoneUTC timezoneMMM_DD_YYYY (e.g. JAN_01_2023 for 2023-01-01)23:59:59 UTC for the final day of something, 00:00:00 UTC for the first day of something)internalconstantIF new contract is present in the spell (not yet on chainlog or new to chainlog)
GNU AGPLv3 licensevat, dai, dog, ...)wards or access controlPAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)denied (wards(deployer) is 0)MCD_ESM address is already relied OR being relied (wards(MCD_ESM) is 1) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy)Rely events except for PAUSE_PROXY and MCD_ESM (using a block explorer like etherscan)code --diff etherscan.sol github.sol)addresses_deployers.solIF core system parameter changes are present in the instructions
jug.ilk.duty) is updatedDssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used// Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%pot.dsr) is updatedDssExecLib.setDSR(rate, doDrip)) is used// Increase DSR by X.XX% from X.XX% to X.XX%make rates pct=<pct> (e.g. pct=0.75, for 0.75%)spotter.ilk.mat is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)) is useddog.ilk.hole is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)) is usedvat.ilk.dust is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)) is useddog.ilk.chop is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)) is usedclip.buf is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)) is usedclipperMom.clip.tolerance is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)) is usedclip.tail is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)) is usedclip.cusp is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)) is usedclip.chip is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)) is usedclip.tip is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)) is usedcalc.tau is updated, (DssExecLib.setLinearDecrease(calc, duration)) is usedcalc.cut or calc.step are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps) is usedIF debt ceiling changes are present in the instructions
ilk) have AutoLine enabled (MCD_IAM_AUTO_LINE)0MCD_IAM_AUTO_LINE) via DssExecLib.removeIlkFromAutoLine(ilk)MCD_IAM_AUTO_LINE) is present in the Exec Sheet0 via DssExecLib.setIlkDebtCeiling(ilk, amount)vat.Line) is updated accordingly, UNLESS specifically instructed not toAutoLine parameters are updatedDssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)vat.ilk.line) is updatedilk) have AutoLine disabled previously or in the spellvat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeilingDssExecLib.setGlobalDebtCeiling(amount)DssExecLib.increaseGlobalDebtCeiling(amount)DssExecLib.decreaseGlobalDebtCeiling(amount)IF onboarding is present
IF collateral offboarding is present in the spell
ilk) is removed from AutoLine (MCD_IAM_AUTO_LINE) IF currently enabledvat.ilk.line) is set to 0vat.Line) decreased by the total amount of offboarded ilkschop) is set to 0 IF requested by governancetip) is set to 0 IF requested by governancechip) is set to 0 IF requested by governancehole) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount) IF requested by governanceMCD_CLIP_) is active (i.e. stopped is 0)spotter.ilk.mat) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio))DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration))name format matches "XXX-X Offboarding"target matches DssExecLib.spotter() addressilk format matches collateral type (ilk) name ("XXX-X")what matches string "mat"startTime matches block.timestampstart uses variable CURRENT_XXX_A_MATstart matches current spotter.ilk.mat valueend uses variable TARGET_XXX_A_MATend value matches the instructionend allows liquidation of all remaining vaults (end is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor)duration matches the instructionDssExecLib.updateCollateralPrice(ilk) IF collateral have no running oracle (i.e. relevant PIP_ contract have outdated zzz value)_checkIlkClipper helperIF RWA updates are present
doc is updated_updateDoc helper is copied one-to-one from the archive and defined above actions_updateDoc(ilk, doc) is called in the spellDssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl) or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)vat.ilk.line) update is requested by the Exec Docilk) have AutoLine disabled previously or in the spellvat.ilk.line) is updated, via EITHER:DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)DssExecLib.setIlkDebtCeiling(ilk, amount)vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeilingDssExecLib.setGlobalDebtCeiling(amount)DssExecLib.increaseGlobalDebtCeiling(amount)DssExecLib.decreaseGlobalDebtCeiling(amount)RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val) patternbump explains val computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"bump provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei)debt_ceiling in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLinerwa_stability_fee in the executable formula matches stability fee of the specified RWA found on chainminimum_deal_duration_in_years in the executable formula matches number found in the Exec Doc of the spell containing relevant RWA onboardingliquidation_ratio in the executable formula matches liquidation ratio of the specified RWA found on chainval in the spellval makes sense in context of the rate mechanismval calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimalDssExecLib.updateCollateralPrice(ilk).tell(ilk)) AND debt ceiling is 0 (OR is being set to 0 in the current spell)RwaLiquidationOracle.tell(ilk) call is presentRWAXX_A_INPUT_CONDUIT is an instance of TinlakeMgr (it is a Centrifuge integration), additional TinlakeMgr.tell() call is present (in order to prevent further TIN redemptions in the Centrifuge pool)IF payments are present in the spell
MKR transfers are presentaddresses_wallets.solether keywordether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred heretestMKRPayments testtestMKRPayments matches number in the Exec DocDAI surplus buffer transfers are presentaddresses_wallets.soltestDAIPayments testtestDAIPayments matches number in the Exec DocMKR or DAI streams (DssVest) are createdVestAbstract interface is imported from dss-interfaces/dss/VestAbstract.solrestrict is used for each stream, UNLESS otherwise explicitly stated in the Exec Docusr (Vest recipient address) matches Exec Docusr address in the instruction is in the checksummed formatusr address variable name match one found in addresses_wallets.soltot (Total stream amount) matches Exec Docether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred herebgn (Vest start timestamp) matches Exec Doctau is expressed as bgn - fin (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)fin (Vest end timestamp) matches Exec Doceta (Vest cliff duration) matches the following logiceta is explicitly specified in the Exec Doc, then the values matcheta and clf (Cliff end timestamp) are not specified in the Exec Doc, then eta is 0clf is specified, but clf <= bgn, then eta is 0clf is specified and clf > bgn, eta is expressed as clf - bgn (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)mgr (Vest manager address) is specified in the Exec Doc, matches the value, OTHERWISE matches address(0)cap) is enough for the new streamstot divided by tau) <= the maximum vest streaming rate (cap)tot divided by tau) > the maximum vest streaming rate (cap)cap value equal to 10% greater than the new maximum vesting rate, then round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)cap) is changed in the spelltotal (the sum of all tot values)testVestDAI or testVestMKRMKR or DAI vest termination (Yank) is presentMCD_VEST_MKR_TREASURY chainlog address is used for MKR stream yankMCD_VEST_DAI chainlog address is used for DAI stream yanktestYankDAI or testYankMKRIF SubDAO-related content is present
ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));addresses_deployers.sol as an entryDelegateCall context)vat, etc. (Check comprehensively where the risk is high)PAUSE_PROXY as their admin (i.e. the party that can upgrade)admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)IF external contracts calls are present (Not SubDAOs, e.g. Starknet)
delegatecallCREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their codeIF spell interacts with ChainLog
addresses_mainnet.soltestNewOrUpdatedChainlogValues[x] Ensure every spell variable is declared as public/internal
[x] Ensure immutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses
address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)DssExecLib.vat())ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)[x] Spell actions match the corresponding Exec Doc
Tests
testGeneral() and editing config.sol properly
[x] Push GUSD out of input conduit
✅ testPushGUSDOutInputConduit()
[x] Aave SparkLend Revenue Share
✅ testDAIPayments()
[x] RWA009 doc Update
✅ testRWA009DocChange()
[x] Delegate Compensation
✅ testMKRPayments()DssExecLib.address file is not being modified by the spell PRprintenv | grep "FOUNDRY_\|DAPP_")make test./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠒] Compiling...
[⠆] Compiling 110 files with 0.8.16
[⠆] Solc 0.8.16 finished in 10.86s
Compiler run successful!
Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1079767)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 93.56s
Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 2541463)
[PASS] testCastCost() (gas: 936798)
[PASS] testChainlogIntegrity() (gas: 14418173)
[PASS] testChainlogValues() (gas: 9219916)
[PASS] testContractSize() (gas: 8940)
[PASS] testDAIPayments() (gas: 1004947)
[PASS] testDeployCost() (gas: 2526689)
[PASS] testFailNotScheduled() (gas: 14353)
[PASS] testFailTooEarly() (gas: 13585)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 27300783)
[PASS] testMKRPayments() (gas: 1025470)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 932548)
[PASS] testPSMs() (gas: 2250236)
[PASS] testPushGUSDOutInputConduit() (gas: 950105)
[PASS] testRWA009DocChange() (gas: 989590)
[PASS] testUseEta() (gas: 352324)
Test result: ok. 19 passed; 0 failed; 0 skipped; finished in 771.76s
Ran 2 test suites: 21 tests passed, 0 failed, 0 skipped (21 total tests)
SidestreamColdMelon
commented
9 months ago TLDR: good to deploy
makerdao/community GitHub repo
https://github.com/makerdao/community/blob/master/governance/votes/Executive%20vote%20-%20February%207%2C%202024.mdExecutive vote - Month DD, YYYY.mdTARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL
Insert your Exec Doc Hash here
:warning: The script fails with date: illegal option -- d, which is a known problem. Nevertheless, the hash is checked manually belowcast keccak -- "$(curl '$URL' -o - 2>/dev/null)"
Insert your Exec Doc Hash here
0xcf5fd72f4cea53a4529329d1ff94b29ecb4f92919cbf08623316eae94acaa79c0.8.16true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to falsefalse in the spell. This is in line with the previous spellsblock.timestamp + 30 days)TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASHTARGET_DATE in the description matches the Exec Doc target date// Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"// ----- Section text -----)// Instruction text// Note: (e.g.: // Note: Payments are skipped on goerli)chainlog version bump), the necessity of it is explained in the comment above prefixed with // Note:Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)Reasoning URL and Authority URL have prefix derived from the url itself
// Executive Vote: if URL starts with https://vote.makerdao.com/executive/// Poll: if URL starts with https://vote.makerdao.com/polling/// Forum: if URL starts with https://forum.makerdao.com/t/// MIP: if URL starts with https://mips.makerdao.com/mips/details/foundryuprm -rf ./lib && git submodule update --init --recursive
Insert checked out submodule paths here
Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'dss-exec-lib is synced as welldss-exec-lib (run git submodule status) matches the latest release version or newer
:warning: Hash doesn't match as in many previous spells. Latest release v0.0.9 has hash of c0d3c6c made on Feb 1, 2022, while git submodule of lib/dss-exec-lib is set to track the latest commit 69b658f made on Jan 23, 2023dss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-testdss-interfacesdss-interfacesimport "dss-interfaces/dss/VatAbstract.sol";)dss-interfaces, OTHERWISE should be imported from there
:warning: There seem to be all nesesery interfaces in the dss-interfaces repo (at the 9bfd7afadd1f8c217ef05850b2555691786286cb hash used by both submodules), but it's not a blocker, as they match (except for the RwaInputConduit3Abstract.push that have unit instead of uint256 as in the contract itself, but in this case interface library is less explicit)cast interface <contract_address> commandLike suffix (e.g. VatLike)
WAD = 10 ** 18RAY = 10 ** 27RAD = 10 ** 45internalconstantHUNDRED = 10 ** 2THOUSAND = 10 ** 3MILLION = 10 ** 6BILLION = 10 ** 9HUNDRED is not present in config, but match archive and the value specified in the checklist itselfinternalconstantmake rates pct=<pct> (e.g. pct=0.75, for 0.75%)X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)internalconstantUTC timezoneUTC timezoneMMM_DD_YYYY (e.g. JAN_01_2023 for 2023-01-01)23:59:59 UTC for the final day of something, 00:00:00 UTC for the first day of something)internalconstantGNU AGPLv3 licensevat, dai, dog, ...)wards or access controlPAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)denied (wards(deployer) is 0)MCD_ESM address is already relied OR being relied (wards(MCD_ESM) is 1) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy)Rely events except for PAUSE_PROXY and MCD_ESM (using a block explorer like etherscan)code --diff etherscan.sol github.sol)addresses_deployers.soljug.ilk.duty) is updatedDssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used// Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%pot.dsr) is updatedDssExecLib.setDSR(rate, doDrip)) is used// Increase DSR by X.XX% from X.XX% to X.XX%make rates pct=<pct> (e.g. pct=0.75, for 0.75%)spotter.ilk.mat is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)) is useddog.ilk.hole is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)) is used
:warning: Also DssExecLib.setMaxTotalDAILiquidationAmount is used to update Hole, although is not present in this listvat.ilk.dust is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)) is useddog.ilk.chop is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)) is usedclip.buf is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)) is usedclipperMom.clip.tolerance is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)) is usedclip.tail is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)) is usedclip.cusp is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)) is usedclip.chip is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)) is usedclip.tip is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)) is usedcalc.tau is updated, (DssExecLib.setLinearDecrease(calc, duration)) is usedcalc.cut or calc.step are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps) is usedilk) have AutoLine enabled (MCD_IAM_AUTO_LINE)0
MCD_IAM_AUTO_LINE) via DssExecLib.removeIlkFromAutoLine(ilk)MCD_IAM_AUTO_LINE) is present in the Exec Sheet0 via DssExecLib.setIlkDebtCeiling(ilk, amount)vat.Line) is updated accordingly, UNLESS specifically instructed not toAutoLine parameters are updated
DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)vat.ilk.line) is updatedilk) have AutoLine disabled previously or in the spellvat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:
:warning: As we're updating vat.ilk.line back to the original value of 0, no global debt ceiling changes are necessary
global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeilingDssExecLib.setGlobalDebtCeiling(amount)DssExecLib.increaseGlobalDebtCeiling(amount)DssExecLib.decreaseGlobalDebtCeiling(amount)ilk) is removed from AutoLine (MCD_IAM_AUTO_LINE) IF currently enabledvat.ilk.line) is set to 0vat.Line) decreased by the total amount of offboarded ilkschop) is set to 0 IF requested by governancetip) is set to 0 IF requested by governancechip) is set to 0 IF requested by governancehole) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount) IF requested by governanceMCD_CLIP_) is active (i.e. stopped is 0)spotter.ilk.mat) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio))DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration))name format matches "XXX-X Offboarding"target matches DssExecLib.spotter() addressilk format matches collateral type (ilk) name ("XXX-X")what matches string "mat"startTime matches block.timestampstart uses variable CURRENT_XXX_A_MATstart matches current spotter.ilk.mat valueend uses variable TARGET_XXX_A_MATend value matches the instructionend allows liquidation of all remaining vaults (end is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor)duration matches the instructionDssExecLib.updateCollateralPrice(ilk) IF collateral have no running oracle (i.e. relevant PIP_ contract have outdated zzz value)_checkIlkClipper helperdoc is updated_updateDoc helper is copied one-to-one from the archive and defined above actions_updateDoc(ilk, doc) is called in the spellDssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl) or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)vat.ilk.line) update is requested by the Exec Doc
ilk) have AutoLine disabled previously or in the spellvat.ilk.line) is updated, via EITHER:vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeilingDssExecLib.setGlobalDebtCeiling(amount)DssExecLib.increaseGlobalDebtCeiling(amount)DssExecLib.decreaseGlobalDebtCeiling(amount)RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val) patternbump explains val computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"bump provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei)debt_ceiling in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLinerwa_stability_fee in the executable formula matches stability fee of the specified RWA found on chainminimum_deal_duration_in_years in the executable formula matches number found in the Exec Doc of the spell containing relevant RWA onboardingliquidation_ratio in the executable formula matches liquidation ratio of the specified RWA found on chainval in the spellval makes sense in context of the rate mechanismval calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimalDssExecLib.updateCollateralPrice(ilk).tell(ilk)) AND debt ceiling is 0 (OR is being set to 0 in the current spell)
RwaLiquidationOracle.tell(ilk) call is presentRWAXX_A_INPUT_CONDUIT is an instance of TinlakeMgr (it is a Centrifuge integration), additional TinlakeMgr.tell() call is present (in order to prevent further TIN redemptions in the Centrifuge pool)MKR transfers are presentaddresses_wallets.solether keywordether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred heretestMKRPayments testtestMKRPayments matches number in the Exec DocDAI surplus buffer transfers are presentaddresses_wallets.soltestDAIPayments testtestDAIPayments matches number in the Exec Doc
:warning: Number is not present in the exec doc, but present in the exec sheet. As there is only one DAI transfer it isn't strictly necessaryMKR or DAI streams (DssVest) are createdVestAbstract interface is imported from dss-interfaces/dss/VestAbstract.solrestrict is used for each stream, UNLESS otherwise explicitly stated in the Exec Docusr (Vest recipient address) matches Exec Docusr address in the instruction is in the checksummed formatusr address variable name match one found in addresses_wallets.soltot (Total stream amount) matches Exec Docether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred herebgn (Vest start timestamp) matches Exec Doctau is expressed as bgn - fin (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)fin (Vest end timestamp) matches Exec Doceta (Vest cliff duration) matches the following logiceta is explicitly specified in the Exec Doc, then the values matcheta and clf (Cliff end timestamp) are not specified in the Exec Doc, then eta is 0clf is specified, but clf <= bgn, then eta is 0clf is specified and clf > bgn, eta is expressed as clf - bgn (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)mgr (Vest manager address) is specified in the Exec Doc, matches the value, OTHERWISE matches address(0)cap) is enough for the new streamstot divided by tau) <= the maximum vest streaming rate (cap)tot divided by tau) > the maximum vest streaming rate (cap)cap value equal to 10% greater than the new maximum vesting rate, then round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)cap) is changed in the spell
total (the sum of all tot values)testVestDAI or testVestMKRMKR or DAI vest termination (Yank) is presentMCD_VEST_MKR_TREASURY chainlog address is used for MKR stream yankMCD_VEST_DAI chainlog address is used for DAI stream yanktestYankDAI or testYankMKRProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));addresses_deployers.sol as an entryDelegateCall context)vat, etc. (Check comprehensively where the risk is high)PAUSE_PROXY as their admin (i.e. the party that can upgrade)admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)delegatecallCREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their codeaddresses_mainnet.soltestNewOrUpdatedChainlogValuespublic/internalimmutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses
address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)DssExecLib.vat())ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)testGeneraltestPushGUSDOutInputConduittestDAIPaymentstestRWA009DocChangetestMKRPaymentsDssExecLib.address file is not being modified by the spell PRprintenv | grep "FOUNDRY_\|DAPP_")make test_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠃] Compiling...
[⠢] Compiling 4 files with 0.8.16
[⠊] Solc 0.8.16 finished in 2.29s
Compiler run successful!
Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1079767)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 369.72s
Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 2541463)
[PASS] testCastCost() (gas: 936798)
[PASS] testChainlogIntegrity() (gas: 14418173)
[PASS] testChainlogValues() (gas: 9219916)
[PASS] testContractSize() (gas: 8940)
[PASS] testDAIPayments() (gas: 1004832)
[PASS] testDeployCost() (gas: 2526689)
[PASS] testFailNotScheduled() (gas: 14353)
[PASS] testFailTooEarly() (gas: 13585)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 27300783)
[PASS] testMKRPayments() (gas: 1025470)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 932548)
[PASS] testPSMs() (gas: 2250236)
[PASS] testPushGUSDOutInputConduit() (gas: 950105)
[PASS] testRWA009DocChange() (gas: 989590)
[PASS] testUseEta() (gas: 352324)
Test result: ok. 19 passed; 0 failed; 0 skipped; finished in 600.43s
Ran 2 test suites: 21 tests passed, 0 failed, 0 skipped (21 total tests)Update: Good to deploy!
oddaf
commented
9 months ago Spell deployed to 0x0E9AB92e3Fad77eE35a5f702Ac56c48bAAB7B0eE.
Simulation of cast on Tenderly: https://dashboard.tenderly.co/explorer/fork/simulation/ce71a0da-27e7-47a7-b71b-9d425cfe2ba9
Tenderly testnet with cast spell: https://dashboard.tenderly.co/explorer/vnet/3d8d03a3-4017-4e79-afa3-a5dac29da97c/transactions
SidestreamColdMelon
commented
9 months ago TLDR: good to handover
false UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failedmake diff-deployed-spell or manually)make check-deployed-spellDssExecLib.address filedeployed_spell_created matches deployment timestamp
:warning: The script says it doesn't, but it's a known problem. Verified manuallydeployed_spell_block matches deployment block number
:warning: The script says it doesn't, but it's a known problem. Verified manuallymake deploy-info tx=<tx> matches config
deployed_spell_created timestampdeployed_spell_block block numberDssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)Libraries Used matches DssExecLib Latest Releasec0d3c6c made on Feb 1, 2022, while git submodule of lib/dss-exec-lib is set to track the latest commit 69b658f made on Jan 23, 2023 Here is the diff between the latest release and the submodule hash: https://github.com/makerdao/dss-exec-lib/compare/v0.0.9...69b658f35d8618272cd139dfc18c5713caf6b96b#diff-72201ff20380f5c7fc89281be3ad2dd6bd5a992f246d41d6d9d97f71e078d40d. The only major difference between deployed v0.0.9 and the imported submoduleis the new setRWAIlkDebtCeiling, which we're not using in this spellmake diff-archive-spell for current date or make diff-archive-spell date="YYYY-MM-DD"DssExecLib.address file is not being modified by the spell PRprintenv | grep "FOUNDRY_\|DAPP_")make test_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠰] Compiling...
No files changed, compilation skipped
Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1079767)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 318.25s
Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 2541463)
[PASS] testCastCost() (gas: 936798)
[PASS] testChainlogIntegrity() (gas: 14418173)
[PASS] testChainlogValues() (gas: 9219916)
[PASS] testContractSize() (gas: 8940)
[PASS] testDAIPayments() (gas: 1004947)
[PASS] testDeployCost() (gas: 2526689)
[PASS] testFailNotScheduled() (gas: 14353)
[PASS] testFailTooEarly() (gas: 13585)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 27302880)
[PASS] testMKRPayments() (gas: 1025470)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 932548)
[PASS] testPSMs() (gas: 2250236)
[PASS] testPushGUSDOutInputConduit() (gas: 950105)
[PASS] testRWA009DocChange() (gas: 989590)
[PASS] testUseEta() (gas: 352324)
Test result: ok. 19 passed; 0 failed; 0 skipped; finished in 577.44s
Ran 2 test suites: 21 tests passed, 0 failed, 0 skipped (21 total tests)false UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failedmake diff-deployed-spell or manually)DssExecLib code is replaced, checked also manually.make check-deployed-spellDssExecLib.address filedeployed_spell_created matches deployment timestamp
deployed_spell_block matches deployment block number
make deploy-info tx=<tx> matches config
deployed_spell_created timestampdeployed_spell_block block numberDssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)Libraries Used matches DssExecLib Latest Releasemake diff-archive-spell for current date or make diff-archive-spell date="YYYY-MM-DD"DssExecLib.address file is not being modified by the spell PRprintenv | grep "FOUNDRY_\|DAPP_")make test_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠒] Compiling...
[⠆] Compiling 5 files with 0.8.16
[⠊] Solc 0.8.16 finished in 6.32s
Compiler run successful!
Running 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1079767)
[PASS] testStarknetSpell() (gas: 2324)
Test result: ok. 2 passed; 0 failed; 0 skipped; finished in 439.00s
Running 19 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 2541463)
[PASS] testCastCost() (gas: 936798)
[PASS] testChainlogIntegrity() (gas: 14418173)
[PASS] testChainlogValues() (gas: 9219916)
[PASS] testContractSize() (gas: 8940)
[PASS] testDAIPayments() (gas: 1004947)
[PASS] testDeployCost() (gas: 2526689)
[PASS] testFailNotScheduled() (gas: 14353)
[PASS] testFailTooEarly() (gas: 13585)
[PASS] testFailTooLate() (gas: 13606)
[PASS] testFailWrongDay() (gas: 13585)
[PASS] testGeneral() (gas: 27302880)
[PASS] testMKRPayments() (gas: 1025470)
[PASS] testNextCastTime() (gas: 353681)
[PASS] testOnTime() (gas: 932548)
[PASS] testPSMs() (gas: 2250236)
[PASS] testPushGUSDOutInputConduit() (gas: 950105)
[PASS] testRWA009DocChange() (gas: 989590)
[PASS] testUseEta() (gas: 352324)
Test result: ok. 19 passed; 0 failed; 0 skipped; finished in 725.14s
Ran 2 test suites: 21 tests passed, 0 failed, 0 skipped (21 total tests)
Description
This PR implements 2024-02-07 mainnet spell based on the relevant Exec Sheet.
Contribution Checklist
(PE-<TICKET_NUMBER>)Checklist
officeHoursmodifier override30 daysunless otherwise specified)ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploymainnetcontract on etherscanmake archive-spellormake date="YYYY-MM-DD" archive-spellto make an archive directory and copyDssSpell.sol,DssSpell.t.sol,DssSpell.t.base.sol, andDssSpellCollateralOnboarding.solsquash and mergethis PR