Closed 0xdecr1pto closed 4 months ago
SidestreamColdMelon
commented
4 months ago There is actually a rule in the crafters checklist (which is missing from the reviewers checklist) on how to name the PR. Therefore, please rename it to Mainnet spell 2024-03-06 🙂
oddaf
commented
4 months ago Good to deploy:
Preparation
makerdao/community GitHub repoExecutive vote - Month DD, YYYY.mdTARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL
Insert your Exec Doc Hash here
0x58137ea863fa6ff936cfa4aa430826c5c548b1e863acf4da8df0cdc465f7090ccast keccak -- "$(curl '$URL' -o - 2>/dev/null)"
Insert your Exec Doc Hash here
0x58137ea863fa6ff936cfa4aa430826c5c548b1e863acf4da8df0cdc465f7090cIf this executive proposal passes, the following transfers for Aligned Delegate Compensation will be made to qualifying Aligned Delegates.
| Delegate | Amount (MKR) | Address |
|---|---|---|
| BLUE | 41.67 | 0xb6c09680d822f162449cdfb8248a7d3fc26ec9bf |
| BONAPUBLICA | 41.67 | 0x167c1a762B08D7e78dbF8f24e5C3f1Ab415021D3 |
| Cloaky | 41.67 | 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818 |
| TRUE NAME | 41.67 | 0x612f7924c367575a0edf21333d96b15f1b345a5d |
| 0xDefensor | 23.71 | 0x9542b441d65B6BF4dDdd3d4D2a66D8dCB9EE07a9 |
| JAG | 13.89 | 0x58D1ec57E4294E4fe650D1CB12b96AE34349556f |
| UPMaker | 13.89 | 0xbb819df169670dc71a16f58f55956fe642cc6bcd |
| vigilant | 13.89 | 0x2474937cB55500601BCCE9f4cb0A0A72Dc226F61 |
| PBG | 13.44 | 0x8D4df847dB7FfE0B46AF084fE031F7691C6478c2 |
| Pipkin | 5.82 | 0x0E661eFE390aE39f90a58b04CF891044e56DEDB7 |
| QGov | 4.48 | 0xB0524D8707F76c681901b782372EbeD2d4bA28a6 |
| WBC | 4.03 | 0xeBcE83e491947aDB1396Ee7E55d3c81414fB0D47 |
This is a total of: 259.83 MKR.
hop UpdateIf this executive proposal passes the following change to the hop parameter of the Smart Burn Engine will take place:
hop parameter by 6,570 seconds from 26,280 seconds to 19,710 seconds.If this executive proposal passes the following transfers to the Launch Project will take place:
If this executive proposal passes the following transfer of a whistleblower bounty will take place:
Note: The MKR amount has been rounded to 2 decimal places to aid in the spellcrafting and verification process.
gap ChangesIf this executive proposal passes the following changes to the gap parameter will take place:
gap by 2 million DAI from 2 million DAI to 4 million DAI.gap by 6 million DAI from 2 million DAI to 8 million DAI.If this executive proposal passes a Spark Protocol proxy spell at 0xf3449d6D5827F0F6e0eE4a941f058307056D3736 will be executed. The expected contents of this are:
This new feature will enable dynamic adjustments to borrow and supply caps. The core mechanism is similar to the Debt Ceiling Instant Access Modules (DC-IAM) used for Maker core vaults and will help reduce governance overhead in maintaining the supply and borrow caps for various assets.
If this executive proposal passes, the module will be activated with the following max limit (max), buffer size (gap), and cooldown (ttl) parameters for the covered assets:
WETH
gap: 150,000 WETHttl: 12 hoursmax: 2 million WETHgap: 10,000 WETHttl: 12 hoursmax: 1 million WETHwstETH
gap: 50,000 wstETHttl: 12 hoursmax: 1.2 million wstETHgap: 100 wstETHttl: 12 hoursmax: 3,000 wstETHrETH
gap: 10,000 rETHttl: 12 hoursmax: 80,000 rETHgap: 100 rETHttl: 12 hoursmax: 2,400 rETHWBTC
gap: 500 WBTCttl: 12 hoursmax: 5,000 WBTCgap: 100 WBTCttl: 12 hoursmax: 2,000 WBTCsDAI
gap: 50 million sDAIttl: 12 hoursmax: 1 billion sDAIUSDC
gap: N/Attl: N/Amax: 60 million USDCgap: 6 million USDCttl: 12 hoursmax: 57 million USDCUSDT
gap: N/Attl: N/Amax: 30 million USDTgap: 3 million USDTttl: 12 hoursmax: 28.5 million USDTIf this executive proposal passes the following collateral parameter changes will be made to SparkLend:
WETH
wstETH
rETH
WBTC
sDAI
ETH emode
Increase LTV from 90% to 92%
[x] Ensure that instructions announced in the Exec Doc match instructions in the Exec Sheet
0.8.16true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to falseblock.timestamp + 30 days)TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASHTARGET_DATE in the description matches the Exec Doc target date// Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"// ----- Section text -----)// Instruction text// Note: (e.g.: // Note: Payments are skipped on goerli)chainlog version bump), the necessity of it is explained in the comment above prefixed with // Note:Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)Reasoning URL and Authority URL have prefix derived from the url itself
// Executive Vote: if URL starts with https://vote.makerdao.com/executive/// Poll: if URL starts with https://vote.makerdao.com/polling/// Forum: if URL starts with https://forum.makerdao.com/t/// MIP: if URL starts with https://mips.makerdao.com/mips/details/foundryuprm -rf ./lib && git submodule update --init --recursive
Insert checked out submodule paths here
Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f77'
Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'
Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
Submodule path 'lib/dss-test/lib/forge-std': checked out '155d547c449afa8715f538d69454b83944117811'
Submodule path 'lib/dss-test/lib/forge-std/lib/ds-test': checked out 'e282159d5170298eb2455a6c05280ab5a73a4ef0'dss-exec-lib is synced as welldss-exec-lib (run git submodule status) matches the latest release version or newerdss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-testdss-interfacesdss-interfacesimport "dss-interfaces/dss/VatAbstract.sol";)dss-interfaces, OTHERWISE should be imported from therecast interface <contract_address> commandLike suffix (e.g. VatLike)
WAD = 10 ** 18RAY = 10 ** 27RAD = 10 ** 45internalconstantHUNDRED = 10 ** 2THOUSAND = 10 ** 3MILLION = 10 ** 6BILLION = 10 ** 9internalconstantmake rates pct=<pct> (e.g. pct=0.75, for 0.75%)X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)internalconstantUTC timezoneUTC timezoneMMM_DD_YYYY (e.g. JAN_01_2023 for 2023-01-01)23:59:59 UTC for the final day of something, 00:00:00 UTC for the first day of something)internalconstantGNU AGPLv3 licensevat, dai, dog, ...)wards or access controlPAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)denied (wards(deployer) is 0)MCD_ESM address is already relied OR being relied (wards(MCD_ESM) is 1) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy)Rely events except for PAUSE_PROXY and MCD_ESM (using a block explorer like etherscan)code --diff etherscan.sol github.sol)addresses_deployers.soljug.ilk.duty) is updatedDssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used// Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%pot.dsr) is updatedDssExecLib.setDSR(rate, doDrip)) is used// Increase DSR by X.XX% from X.XX% to X.XX%make rates pct=<pct> (e.g. pct=0.75, for 0.75%)spotter.ilk.mat is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)) is useddog.ilk.hole is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)) is usedvat.ilk.dust is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)) is useddog.ilk.chop is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)) is usedclip.buf is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)) is usedclipperMom.clip.tolerance is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)) is usedclip.tail is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)) is usedclip.cusp is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)) is usedclip.chip is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)) is usedclip.tip is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)) is usedcalc.tau is updated, (DssExecLib.setLinearDecrease(calc, duration)) is usedcalc.cut or calc.step are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps) is usedilk) have AutoLine enabled (MCD_IAM_AUTO_LINE)0MCD_IAM_AUTO_LINE) via DssExecLib.removeIlkFromAutoLine(ilk)MCD_IAM_AUTO_LINE) is present in the Exec Sheet0 via DssExecLib.setIlkDebtCeiling(ilk, amount)vat.Line) is updated accordingly, UNLESS specifically instructed not toAutoLine parameters are updated
DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)vat.ilk.line) is updatedilk) have AutoLine disabled previously or in the spellvat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeilingDssExecLib.setGlobalDebtCeiling(amount)DssExecLib.increaseGlobalDebtCeiling(amount)DssExecLib.decreaseGlobalDebtCeiling(amount)ilk) is removed from AutoLine (MCD_IAM_AUTO_LINE) IF currently enabledvat.ilk.line) is set to 0vat.Line) decreased by the total amount of offboarded ilkschop) is set to 0 IF requested by governancetip) is set to 0 IF requested by governancechip) is set to 0 IF requested by governancehole) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount) IF requested by governanceMCD_CLIP_) is active (i.e. stopped is 0)spotter.ilk.mat) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio))DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration))name format matches "XXX-X Offboarding"target matches DssExecLib.spotter() addressilk format matches collateral type (ilk) name ("XXX-X")what matches string "mat"startTime matches block.timestampstart uses variable CURRENT_XXX_A_MATstart matches current spotter.ilk.mat valueend uses variable TARGET_XXX_A_MATend value matches the instructionend allows liquidation of all remaining vaults (end is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor)duration matches the instructionDssExecLib.updateCollateralPrice(ilk) IF collateral have no running oracle (i.e. relevant PIP_ contract have outdated zzz value)_checkIlkClipper helperdoc is updated_updateDoc helper is copied one-to-one from the archive and defined above actions_updateDoc(ilk, doc) is called in the spellDssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl) or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)vat.ilk.line) update is requested by the Exec Docilk) have AutoLine disabled previously or in the spellvat.ilk.line) is updated, via EITHER:vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeilingDssExecLib.setGlobalDebtCeiling(amount)DssExecLib.increaseGlobalDebtCeiling(amount)DssExecLib.decreaseGlobalDebtCeiling(amount)RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val) patternbump explains val computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"bump provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei)debt_ceiling in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLinerwa_stability_fee in the executable formula matches stability fee of the specified RWA found on chainminimum_deal_duration_in_years in the executable formula matches number found in the Exec Doc of the spell containing relevant RWA onboardingliquidation_ratio in the executable formula matches liquidation ratio of the specified RWA found on chainval in the spellval makes sense in context of the rate mechanismval calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimalDssExecLib.updateCollateralPrice(ilk).tell(ilk)) AND debt ceiling is 0 (OR is being set to 0 in the current spell)RwaLiquidationOracle.tell(ilk) call is presentRWAXX_A_INPUT_CONDUIT is an instance of TinlakeMgr (it is a Centrifuge integration), additional TinlakeMgr.tell() call is present (in order to prevent further TIN redemptions in the Centrifuge pool)MKR transfers are presentaddresses_wallets.solether keywordether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred heretestMKRPayments testtestMKRPayments matches number in the Exec DocDAI surplus buffer transfers are presentaddresses_wallets.soltestDAIPayments testtestDAIPayments matches number in the Exec DocMKR or DAI streams (DssVest) are createdVestAbstract interface is imported from dss-interfaces/dss/VestAbstract.solrestrict is used for each stream, UNLESS otherwise explicitly stated in the Exec Docusr (Vest recipient address) matches Exec Docusr address in the instruction is in the checksummed formatusr address variable name match one found in addresses_wallets.soltot (Total stream amount) matches Exec Docether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred herebgn (Vest start timestamp) matches Exec Doctau is expressed as bgn - fin (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)fin (Vest end timestamp) matches Exec Doceta (Vest cliff duration) matches the following logiceta is explicitly specified in the Exec Doc, then the values matcheta and clf (Cliff end timestamp) are not specified in the Exec Doc, then eta is 0clf is specified, but clf <= bgn, then eta is 0clf is specified and clf > bgn, eta is expressed as clf - bgn (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)mgr (Vest manager address) is specified in the Exec Doc, matches the value, OTHERWISE matches address(0)cap) is enough for the new streamstot divided by tau) <= the maximum vest streaming rate (cap)tot divided by tau) > the maximum vest streaming rate (cap)cap value equal to 10% greater than the new maximum vesting rate, then round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)cap) is changed in the spelltotal (the sum of all tot values)testVestDAI or testVestMKRMKR or DAI vest termination (Yank) is presentMCD_VEST_MKR_TREASURY chainlog address is used for MKR stream yankMCD_VEST_DAI chainlog address is used for DAI stream yanktestYankDAI or testYankMKRProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));addresses_deployers.sol as an entryDelegateCall context)vat, etc. (Check comprehensively where the risk is high)PAUSE_PROXY as their admin (i.e. the party that can upgrade)admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)delegatecallCREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their codeaddresses_mainnet.soltestNewOrUpdatedChainlogValuespublic/internalimmutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses
address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)DssExecLib.vat())ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)Tests
[x] Ensure that the DssExecLib.address file is not being modified by the spell PR
[x] Check all CI tests are passing as at the latest commit Insert most recent commit hash where CI was passing 93bb85466b18bae6a202a7fe59debfe04da72836
[x] Ensure every test function is declared as public
[x] IF the test needs to run, it MUST NOT have the skipped modifier; OTHERWISE, it MUST have the skipped modifier
[x] Ensure each spell action has sufficient test coverage List actions for which coverage was checked here
Delegate Compensation for February 2024 tested in testMKRPayments()
Smart Burn Engine hop Update tested in testGeneral()
Launch Project Funding tested in testMKRPayments() and testDAIPayments
Whistleblower Bounty Payment tested in testMKRPayments()
WBTC vault gap Changes tested in testGeneral()
Spark Proxy Spell tested in testSparkSpellIsExecuted()
[x] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
[x] Check all tests are passing locally using make test
[x] Ensure every test listed in the coverage item above is present in the logs and with the [PASS] prefix.
_Insert your local test logs here_
odd@Workstation spells-mainnet % make test
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠆] Compiling...
No files changed, compilation skipped
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 3019007)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 24.68s (22.47s CPU time)
Ran 33 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 2876161)
[PASS] testCastOnTime() (gas: 2873079)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 11159291)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 11139)
[PASS] testDAIPayments() (gas: 2944103)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 2482005)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 29202813)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testMKRPayments() (gas: 2996438)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 496278)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 4170221)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testSparkSpellIsExecuted() (gas: 2878996)
[PASS] testUseEta() (gas: 352652)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 14 passed; 0 failed; 19 skipped; finished in 281.04s (592.66s CPU time)
Ran 2 test suites in 281.62s (305.71s CPU time): 16 tests passed, 0 failed, 19 skipped (35 total tests)
amusingaxl
commented
4 months ago finished in 281.04s
Oh man, this feels so good 🐸
SidestreamColdMelon
commented
4 months ago TLDR: good to deploy
makerdao/community GitHub repo
https://github.com/makerdao/community/blob/master/governance/votes/Executive%20Vote%20-%20March%206%2C%202024.mdExecutive vote - Month DD, YYYY.mdTARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL
Insert your Exec Doc Hash here
:warning: Script fails with date: illegal option -- d, which is a known problem, but hash is successfully generated via the next commandcast keccak -- "$(curl '$URL' -o - 2>/dev/null)"
Insert your Exec Doc Hash here
0x58137ea863fa6ff936cfa4aa430826c5c548b1e863acf4da8df0cdc465f7090c0.8.16true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to falseblock.timestamp + 30 days)TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASHTARGET_DATE in the description matches the Exec Doc target date// Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"// ----- Section text -----)// Instruction text// Note: (e.g.: // Note: Payments are skipped on goerli)chainlog version bump), the necessity of it is explained in the comment above prefixed with // Note:Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)Reasoning URL and Authority URL have prefix derived from the url itself
// Executive Vote: if URL starts with https://vote.makerdao.com/executive/// Poll: if URL starts with https://vote.makerdao.com/polling/// Forum: if URL starts with https://forum.makerdao.com/t/// MIP: if URL starts with https://mips.makerdao.com/mips/details/foundryuprm -rf ./lib && git submodule update --init --recursive
Insert checked out submodule paths here
Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'dss-exec-lib is synced as welldss-exec-lib (run git submodule status) matches the latest release version or newerdss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-testdss-interfacesdss-interfacesimport "dss-interfaces/dss/VatAbstract.sol";)dss-interfaces, OTHERWISE should be imported from therecast interface <contract_address> command
:warning: ProxyLike.exec have slightly different interface when calling cast interface 0x3300f198988e4C9C63F75dF86De36421f06af8c4 (which returns function exec(address target, bytes memory args) external payable returns (bytes memory out)), but it's a known situation that cast/etherscan can't distinguish between calldata and memory. Instead checked that defined interface actually matches verified source codeLike suffix (e.g. VatLike)
WAD = 10 ** 18RAY = 10 ** 27RAD = 10 ** 45internalconstantHUNDRED = 10 ** 2THOUSAND = 10 ** 3MILLION = 10 ** 6BILLION = 10 ** 9internalconstantmake rates pct=<pct> (e.g. pct=0.75, for 0.75%)X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)internalconstantUTC timezoneUTC timezoneMMM_DD_YYYY (e.g. JAN_01_2023 for 2023-01-01)23:59:59 UTC for the final day of something, 00:00:00 UTC for the first day of something)internalconstantGNU AGPLv3 licensevat, dai, dog, ...)wards or access controlPAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)denied (wards(deployer) is 0)MCD_ESM address is already relied OR being relied (wards(MCD_ESM) is 1) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy)Rely events except for PAUSE_PROXY and MCD_ESM (using a block explorer like etherscan)code --diff etherscan.sol github.sol)addresses_deployers.solflap.hop is updated using DssExecLib.setValue based on the archive pattern
jug.ilk.duty) is updatedDssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used// Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%pot.dsr) is updatedDssExecLib.setDSR(rate, doDrip)) is used// Increase DSR by X.XX% from X.XX% to X.XX%make rates pct=<pct> (e.g. pct=0.75, for 0.75%)spotter.ilk.mat is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)) is useddog.ilk.hole is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)) is usedvat.ilk.dust is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)) is useddog.ilk.chop is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)) is usedclip.buf is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)) is usedclipperMom.clip.tolerance is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)) is usedclip.tail is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)) is usedclip.cusp is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)) is usedclip.chip is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)) is usedclip.tip is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)) is usedcalc.tau is updated, (DssExecLib.setLinearDecrease(calc, duration)) is usedcalc.cut or calc.step are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps) is usedilk) have AutoLine enabled (MCD_IAM_AUTO_LINE)0
MCD_IAM_AUTO_LINE) via DssExecLib.removeIlkFromAutoLine(ilk)MCD_IAM_AUTO_LINE) is present in the Exec Sheet0 via DssExecLib.setIlkDebtCeiling(ilk, amount)vat.Line) is updated accordingly, UNLESS specifically instructed not toAutoLine parameters are updated
DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)vat.ilk.line) is updatedilk) have AutoLine disabled previously or in the spellvat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeilingDssExecLib.setGlobalDebtCeiling(amount)DssExecLib.increaseGlobalDebtCeiling(amount)DssExecLib.decreaseGlobalDebtCeiling(amount)ilk) is removed from AutoLine (MCD_IAM_AUTO_LINE) IF currently enabledvat.ilk.line) is set to 0vat.Line) decreased by the total amount of offboarded ilkschop) is set to 0 IF requested by governancetip) is set to 0 IF requested by governancechip) is set to 0 IF requested by governancehole) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount) IF requested by governanceMCD_CLIP_) is active (i.e. stopped is 0)spotter.ilk.mat) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio))DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration))name format matches "XXX-X Offboarding"target matches DssExecLib.spotter() addressilk format matches collateral type (ilk) name ("XXX-X")what matches string "mat"startTime matches block.timestampstart uses variable CURRENT_XXX_A_MATstart matches current spotter.ilk.mat valueend uses variable TARGET_XXX_A_MATend value matches the instructionend allows liquidation of all remaining vaults (end is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor)duration matches the instructionDssExecLib.updateCollateralPrice(ilk) IF collateral have no running oracle (i.e. relevant PIP_ contract have outdated zzz value)_checkIlkClipper helperdoc is updated_updateDoc helper is copied one-to-one from the archive and defined above actions_updateDoc(ilk, doc) is called in the spellDssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl) or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)vat.ilk.line) update is requested by the Exec Doc
ilk) have AutoLine disabled previously or in the spellvat.ilk.line) is updated, via EITHER:vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeilingDssExecLib.setGlobalDebtCeiling(amount)DssExecLib.increaseGlobalDebtCeiling(amount)DssExecLib.decreaseGlobalDebtCeiling(amount)RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val) patternbump explains val computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"bump provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei)debt_ceiling in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLinerwa_stability_fee in the executable formula matches stability fee of the specified RWA found on chainminimum_deal_duration_in_years in the executable formula matches number found in the Exec Doc of the spell containing relevant RWA onboardingliquidation_ratio in the executable formula matches liquidation ratio of the specified RWA found on chainval in the spellval makes sense in context of the rate mechanismval calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimalDssExecLib.updateCollateralPrice(ilk).tell(ilk)) AND debt ceiling is 0 (OR is being set to 0 in the current spell)
RwaLiquidationOracle.tell(ilk) call is presentRWAXX_A_INPUT_CONDUIT is an instance of TinlakeMgr (it is a Centrifuge integration), additional TinlakeMgr.tell() call is present (in order to prevent further TIN redemptions in the Centrifuge pool)MKR transfers are presentaddresses_wallets.solether keywordether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred heretestMKRPayments testtestMKRPayments matches number in the Exec Doc
:warning: There is no number in the Exec Doc that specifies the sum of all MKR transfers. But it's present in the Exec Sheet and matches the testDAI surplus buffer transfers are presentaddresses_wallets.soltestDAIPayments testtestDAIPayments matches number in the Exec Doc
:warning: There is no number in the Exec Doc that specifies the sum of all DAI payments. But it present in the Exec SheetMKR or DAI streams (DssVest) are createdVestAbstract interface is imported from dss-interfaces/dss/VestAbstract.solrestrict is used for each stream, UNLESS otherwise explicitly stated in the Exec Docusr (Vest recipient address) matches Exec Docusr address in the instruction is in the checksummed formatusr address variable name match one found in addresses_wallets.soltot (Total stream amount) matches Exec Docether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred herebgn (Vest start timestamp) matches Exec Doctau is expressed as bgn - fin (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)fin (Vest end timestamp) matches Exec Doceta (Vest cliff duration) matches the following logiceta is explicitly specified in the Exec Doc, then the values matcheta and clf (Cliff end timestamp) are not specified in the Exec Doc, then eta is 0clf is specified, but clf <= bgn, then eta is 0clf is specified and clf > bgn, eta is expressed as clf - bgn (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)mgr (Vest manager address) is specified in the Exec Doc, matches the value, OTHERWISE matches address(0)cap) is enough for the new streamstot divided by tau) <= the maximum vest streaming rate (cap)tot divided by tau) > the maximum vest streaming rate (cap)cap value equal to 10% greater than the new maximum vesting rate, then round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)cap) is changed in the spell
total (the sum of all tot values)testVestDAI or testVestMKRMKR or DAI vest termination (Yank) is presentMCD_VEST_MKR_TREASURY chainlog address is used for MKR stream yankMCD_VEST_DAI chainlog address is used for DAI stream yanktestYankDAI or testYankMKRProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));addresses_deployers.sol as an entryDelegateCall context)vat, etc. (Check comprehensively where the risk is high)PAUSE_PROXY as their admin (i.e. the party that can upgrade)admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)delegatecallCREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their codeaddresses_mainnet.soltestNewOrUpdatedChainlogValuespublic/internalimmutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses
address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)DssExecLib.vat())ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)DssExecLib.address file is not being modified by the spell PRpublicskipped modifier; OTHERWISE, it MUST have the skipped modifiertestMKRPaymentstestGeneraltestDAIPaymentstestMKRPaymentstestMKRPaymentstestGeneraltestSparkSpellIsExecutedprintenv | grep "FOUNDRY_\|DAPP_")make test[PASS] prefix._Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠢] Compiling...
No files changed, compilation skipped
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 3019063)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 35.08s (31.61s CPU time)
Ran 33 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 2876217)
[PASS] testCastOnTime() (gas: 2873135)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 11159347)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 11139)
[PASS] testDAIPayments() (gas: 2944859)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 2482005)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 29202869)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testMKRPayments() (gas: 2996494)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 495577)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 4170277)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testSparkSpellIsExecuted() (gas: 2879052)
[PASS] testUseEta() (gas: 352652)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 14 passed; 0 failed; 19 skipped; finished in 358.74s (801.63s CPU time)
Ran 2 test suites in 359.30s (393.82s CPU time): 16 tests passed, 0 failed, 19 skipped (35 total tests)
0xdecr1pto
commented
4 months ago oddaf
commented
4 months ago Good to handover:
false UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failedmake diff-deployed-spell or manually)make check-deployed-spellDssExecLib.address filedeployed_spell_created matches deployment timestampdeployed_spell_block matches deployment block number
make deploy-info tx=<tx> matches config
deployed_spell_created timestampdeployed_spell_block block numberDssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)Libraries Used matches DssExecLib Latest Releasemake diff-archive-spell for current date or make diff-archive-spell date="YYYY-MM-DD"DssExecLib.address file is not being modified by the spell PRprintenv | grep "FOUNDRY_\|DAPP_")make test_Insert your local test logs here_
odd@Workstation spells-mainnet % make test
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠆] Compiling...
No files changed, compilation skipped
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 3019007)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 24.35s (22.74s CPU time)
Ran 33 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 2496960)
[PASS] testCastCost() (gas: 2876161)
[PASS] testCastOnTime() (gas: 2873079)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 11159291)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[PASS] testDAIPayments() (gas: 2944218)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 29204910)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testMKRPayments() (gas: 2996438)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 496171)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 4170221)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testSparkSpellIsExecuted() (gas: 2878996)
[PASS] testUseEta() (gas: 352652)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 13 passed; 0 failed; 20 skipped; finished in 281.03s (594.44s CPU time)
Ran 2 test suites in 281.66s (305.37s CPU time): 15 tests passed, 0 failed, 20 skipped (35 total tests)TLDR: good to handover
false UNLESS the contract size is too big AND all mitigation strategies (i.e.: removing revert strings) have failedmake diff-deployed-spell or manually)make check-deployed-spellDssExecLib.address filedeployed_spell_created matches deployment timestamp
:warning: The script says it does not match, but it's a known situation, checked manually belowdeployed_spell_block matches deployment block number
:warning: The script says it does not match, but it's a known situation, checked manually belowmake deploy-info tx=<tx> matches config
deployed_spell_created timestampdeployed_spell_block block numberDssExecLib.address file (e.g. look under the 'Files Changed' PR tab, etc.)Libraries Used matches DssExecLib Latest Releasec0d3c6c made on Feb 1, 2022, while git submodule of lib/dss-exec-lib is set to track the latest commit 69b658f made on Jan 23, 2023 Here is the diff between the latest release and the submodule hash: https://github.com/makerdao/dss-exec-lib/compare/v0.0.9...69b658f35d8618272cd139dfc18c5713caf6b96b#diff-72201ff20380f5c7fc89281be3ad2dd6bd5a992f246d41d6d9d97f71e078d40d. The only major difference between deployed and the imported library is the new setRWAIlkDebtCeiling, which we're not using in this spellmake diff-archive-spell for current date or make diff-archive-spell date="YYYY-MM-DD"DssExecLib.address file is not being modified by the spell PRprintenv | grep "FOUNDRY_\|DAPP_")make test_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠒] Compiling...
[⠒] Compiling 4 files with 0.8.16
[⠘] Solc 0.8.16 finished in 2.07s
Compiler run successful!
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 3019007)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 31.94s (29.01s CPU time)
Ran 33 tests for src/DssSpell.t.sol:DssSpellTest
[PASS] testBytecodeMatches() (gas: 2496960)
[PASS] testCastCost() (gas: 2876161)
[PASS] testCastOnTime() (gas: 2873079)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 11159291)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[PASS] testDAIPayments() (gas: 2944218)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 29204910)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testMKRPayments() (gas: 2996438)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 446546)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 496171)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 4170221)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17507)
[PASS] testSparkSpellIsExecuted() (gas: 2878996)
[PASS] testUseEta() (gas: 352652)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 13 passed; 0 failed; 20 skipped; finished in 353.49s (798.36s CPU time)
Ran 2 test suites in 354.35s (385.44s CPU time): 15 tests passed, 0 failed, 20 skipped (35 total tests)testBytecodeMatches passdelegatecall inside verified codeselfdestruct inside verified code
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)Checklist
officeHoursmodifier override30 daysunless otherwise specified)ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploymainnetcontract on etherscanmake archive-spellormake date="YYYY-MM-DD" archive-spellto make an archive directory and copyDssSpell.sol,DssSpell.t.sol,DssSpell.t.base.sol, andDssSpellCollateralOnboarding.solsquash and mergethis PR