Mainnet spell 2024-04-18

[SidestreamStrongStrawberry]

Description

This PR implements 2024-04-18 mainnet spell based on the relevant Exec Sheet.

Contribution Checklist

• [ ] PR title starts with (PE-<TICKET_NUMBER>)
• [ ] Code approved
• [ ] Tests approved
• [ ] CI Tests pass

Checklist

• [ ] Every contract variable/method declared as public/external private/internal
• [ ] Consider if this PR needs the officeHours modifier override
• [ ] Verify expiration (30 days unless otherwise specified)
• [ ] Verify hash in the description matches here
• [ ] Validate all addresses used are in changelog or known
• [ ] Notify any external teams affected by the spell so they have the opportunity to review
• [ ] Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
• [ ] Verify mainnet contract on etherscan
• [ ] Change test to use mainnet spell address and deploy timestamp
• [ ] Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
• [ ] squash and merge this PR

[SidestreamIcedMango]

Good to deploy :)

Mainnet Executive Spell Review Checklist

Development Stage

• Preparation
  • [x] Exec Sheet for the specified date is found in the "Executive Vote Implementation Process" google sheet Insert URL to the specific sheet here https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/edit#gid=684547605
  • [x] Exec Doc for the specified date is found in the makerdao/community GitHub repo
  • [x] Exec Doc file name follows the format Executive vote - Month DD, YYYY.md
  • [x] Extract permanent URL to the raw markdown file and paste it below Insert your Raw Exec Doc URL here https://raw.githubusercontent.com/makerdao/community/48e8ec892d004e2f350930eaebd0d9e7e23cbd84/governance/votes/Executive%20vote%20-%20April%2018%2C%202024.md
  • [ ] Using Exec Doc URL from the above and the TARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL Insert your Exec Doc Hash here ⚠️ The script is failing with Error: Executive vote not found, but the hash is generated in the next step
  • [x] Using Exec Doc URL from the above, generate Exec Doc Hash via cast keccak -- "$(curl '$URL' -o - 2>/dev/null)" Insert your Exec Doc Hash here 0x71efd61f3800b237e562b1ad518d90b9a155fa6565c98c1cd8d383afcc69b146
  • [x] Using Exec Doc URL from the above, read spell instructions from the Exec Doc and list them below List all instructions announced in the Exec Doc
  • Aligned Delegate Compensation for March 2024
    • the following transfers totalling 214.55 MKR for Aligned Delegate Compensation will be made to qualifying Aligned Delegates.
    • BONAPUBLICA 0x167c1a762B08D7e78dbF8f24e5C3f1Ab415021D3 41.67
    • Cloaky 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818 41.67
    • TRUE NAME 0x612F7924c367575a0Edf21333D96b15F1B345A5d 41.67
    • BLUE 0xb6C09680D822F162449cdFB8248a7D3FC26Ec9Bf 39.75
    • vigilant 0x2474937cB55500601BCCE9f4cb0A0A72Dc226F61 13.89
    • Pipkin 0x0E661eFE390aE39f90a58b04CF891044e56DEDB7 13.89
    • JAG 0x58D1ec57E4294E4fe650D1CB12b96AE34349556f 9.08
    • UPMaker 0xbB819DF169670DC71A16F58F55956FE642cc6BcD 12.93
  • AVC Members Compensation Q1 2024
    • the following distributions totalling 175.14 MKR will be made for Q1 2024 AVC member compensation.
    • IamMeeoh 0x47f7A5d8D27f259582097E1eE59a07a816982AE9 20.85
    • DAI-Vinci 0x9ee47F0f82F1A6F45C4E1D25Ce95C321D8C8356a 20.85
    • opensky 0xf44f97f4113759E0a57756bE49C0655d490Cf19F 20.85
    • ACRE DAOs 0xBF9226345F601150F64Ea4fEaAE7E40530763cbd 20.85
    • Res 0x8c5c8d76372954922400e4654AF7694e158AB784 20.85
    • Harmony 0xE20A2e231215e9b7Aa308463F1A7490b2ECE55D3 20.85
    • Libertas 0xE1eBfFa01883EF2b4A9f59b587fFf1a5B44dbb2f 20.85
    • seedlatam.eth 0xd43b89621fFd48A8A51704f85fd0C87CbC0EB299 20.85
    • 0xRoot 0xC74392777443a11Dc26Ce8A3D934370514F38A91 8.34
  • Aave Revenue Share Payment
    • a payment from the Surplus Buffer of 238,339 DAI to a smart contract 0x464C71f6c2F760DdA6093dCB91C24c39e5d6e18c controlled by Aave Governance will be made as part of the Spark Protocol-Aave Revenue Share.
  • Whitelist New Address 0x6759610547a36E9597Ef452aa0B9cace91291a2f in the RWA015-A Output Conduit
  • Push USDP Out of the Input Conduit
    • Raise the PSM_PAX_A Debt Ceiling to 100,000 DAI.
    • Call push(uint256 amt) on the the PSM_PAX_A_INPUT_CONDUIT_JAR contract with an amount of 84,211.27 USDP, depositing the contents of the contract to the PSM and receiving an identical amount of Dai into the PSM_PAX_A_JAR contract.
    • Call void() on the PSM_PAX_A_JAR contract to deposit the Dai to the Surplus Buffer.
    • Set PSM-PAX-A Debt Ceiling to 0 DAI.
    • Decrease Debt Ceiling of PSM_PAX_A back to 0 DAI.
  • Trigger Spark Proxy Spell at 0x3d1DD14Fa08163E7f64b0abf0F514f6276f50882
  • [x] Ensure that instructions announced in the Exec Doc match instructions in the Exec Sheet
• Base checks
  • [x] Current solc version 0.8.16
  • [x] Office hours is true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to false
  • [x] Office hours value matches the Exec Sheet
  • [x] Office hours value matches the Exec Doc
  • [x] 30 days spell expiry set in the constructor (block.timestamp + 30 days)
• Spell description
  • [x] Description follows the format TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH
  • [x] TARGET_DATE in the description matches the Exec Doc target date
  • [x] Accompanying comment above spell description follows the format // Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"
  • [ ] Exec Doc URL in comment matches your Raw Exec Doc URL above ⚠️ URLs differ in the commit hash, but it's only commit hash vs last commit inside PR so it's not crutial
  • [x] Exec Doc URL in comment refers to the https://github.com/makerdao/community repo
• Comments inside the spell
  • [x] Every Section text from the Exec Sheet is copied to the spell code as a comment surrounded by the set of dashes (E.g. // ----- Section text -----)
  • [x] Every Instruction text from the Exec Sheet is copied to the spell code as // Instruction text
  • [x] Every Instruction text have newline above it
  • [ ] IF an instruction can not be taken, it should have explanation under the instruction prefixed with // Note: (e.g.: // Note: Payments are skipped on goerli)
  • [x] IF action in the spell doesn't have relevant instruction (e.g.: chainlog version bump), the necessity of it is explained in the comment above prefixed with // Note:
  • [x] Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)
  • [x] Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL have prefix derived from the url itself
    • // Executive Vote: if URL starts with https://vote.makerdao.com/executive/
    • // Poll: if URL starts with https://vote.makerdao.com/polling/
    • // Forum: if URL starts with https://forum.makerdao.com/t/
    • // MIP: if URL starts with https://mips.makerdao.com/mips/details/
• Dependency checks
  • [x] Update Foundry by running foundryup
  • [x] Reinstall libraries by running rm -rf ./lib && git submodule update --init --recursive

    Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
    Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out       '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out      '0aa99eb8456693c015350c5e6c4f442ebe912f77'
    Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out      'cd98eff28324bfac652e63a239a60632a761790b'
    Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'
    Submodule path 'lib/dss-test/lib/dss-interfaces': checked out       '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-test/lib/forge-std': checked out      '155d547c449afa8715f538d69454b83944117811'
    Submodule path 'lib/dss-test/lib/forge-std/lib/ds-test': checked out      'e282159d5170298eb2455a6c05280ab5a73a4ef0'

  • [ ] IF submodule upgrades are present, make sure dss-exec-lib is synced as well
  • [x] git submodule hash of dss-exec-lib (run git submodule status) matches the latest release version or newer
  • [x] dss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-test
• IF interfaces are present in the spell
  • Interfaces imported from dss-interfaces
  • [x] No unused dss-interfaces
  • [x] Only single import layout is used (e.g. import "dss-interfaces/dss/VatAbstract.sol";)
  • Static Interfaces
  • [x] No unused static interfaces
  • [x] Declared static interface not present in the dss-interfaces, OTHERWISE should be imported from there
  • [x] Interface matches deployed contract using cast interface <contract_address> command
  • [x] Interface naming style should match with Like suffix (e.g. VatLike)
    • EXCEPTION: known interface naming exceptions
  • [x] Each static interface declare only functions actually used in the spell code
• IF variable declarations are present in the spell
  • IF precision units are present
  • [ ] Precision units used in the spell match their defined values:
    • WAD = 10 ** 18
    • RAY = 10 ** 27
    • RAD = 10 ** 45
  • [ ] Precision units match with Numerical Ranges
  • [ ] Each variable visibility is declared as internal
  • [ ] Each variable state mutability is declared as constant
  • IF math units are present
  • [ ] Match their defined values:
    • HUNDRED = 10 ** 2
    • THOUSAND = 10 ** 3
    • MILLION = 10 ** 6
    • BILLION = 10 ** 9
  • [ ] Match with config
  • [ ] Each variable visibility is declared as internal
  • [ ] Each variable state mutability is declared as constant
  • IF rates are present
  • [ ] Rates match generated locally via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
  • [ ] Rates match IPFS document
  • [ ] Rate variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)
  • [ ] Rate variable visibility declared as internal
  • [ ] Rate variable state mutability declared as constant
  • IF timestamps are present
  • [ ] Comment above timestamp states full date including UTC timezone
  • [ ] Timestamp converts back to the correct date
  • [ ] Timestamp converts back to the UTC timezone
  • [ ] Variable naming matches MMM_DD_YYYY (e.g. JAN_01_2023 for 2023-01-01)
  • [ ] Time of day makes logical sense in the context of timestamp usage (i.e. 23:59:59 UTC for the final day of something, 00:00:00 UTC for the first day of something)
  • [ ] Each variable visibility is declared as internal
  • [ ] Each variable state mutability is declared as constant
• IF new contract is present in the spell (not yet on chainlog or new to chainlog)
  • [ ] Source code is verified on etherscan
  • [ ] Compilation optimizations match deployment settings defined in the source code repo
  • [ ] GNU AGPLv3 license
  • [ ] Every maker-related constructor argument matches chainlog (e.g. vat, dai, dog, ...)
  • IF new contract have concept of wards or access control
  • [ ] Ensure PAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)
  • [ ] Ensure that contract deployer address was denied (wards(deployer) is 0)
  • [ ] Ensure MCD_ESM address is already relied OR being relied (wards(MCD_ESM) is 1) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy)
  • [ ] Ensure that there are no other Rely events except for PAUSE_PROXY and MCD_ESM (using a block explorer like etherscan)
  • [ ] Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
  • [ ] Deployer address is included into addresses_deployers.sol
• IF core system parameter changes are present in the instructions
  • IF stability fee (jug.ilk.duty) is updated
  • [ ] (DssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used
  • [ ] Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%
  • IF Dai Savings Rate (pot.dsr) is updated
  • [ ] (DssExecLib.setDSR(rate, doDrip)) is used
  • [ ] Comment matches pattern // Increase DSR by X.XX% from X.XX% to X.XX%
  • [ ] Double check that rate match make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
  • [ ] Double check that rate match IPFS document
  • [ ] IF spotter.ilk.mat is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)) is used
  • [ ] IF dog.ilk.hole is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)) is used
  • [ ] IF vat.ilk.dust is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)) is used
  • [ ] IF dog.ilk.chop is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)) is used
  • [ ] IF clip.buf is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)) is used
  • [ ] IF clipperMom.clip.tolerance is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)) is used
  • [ ] IF clip.tail is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)) is used
  • [ ] IF clip.cusp is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)) is used
  • [ ] IF clip.chip is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)) is used
  • [ ] IF clip.tip is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)) is used
  • [ ] IF calc.tau is updated, (DssExecLib.setLinearDecrease(calc, duration)) is used
  • [ ] IF calc.cut or calc.step are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps) is used
• IF debt ceiling changes are present in the instructions
  • IF adjusted collateral type (ilk) have AutoLine enabled (MCD_IAM_AUTO_LINE)
  • IF collateral debt ceiling requested to be 0
    • [ ] Collateral is removed from AutoLine (MCD_IAM_AUTO_LINE) via DssExecLib.removeIlkFromAutoLine(ilk)
    • [ ] The instruction to remove from AutoLine (MCD_IAM_AUTO_LINE) is present in the Exec Sheet
    • [ ] Collateral debt ceiling is set to 0 via DssExecLib.setIlkDebtCeiling(ilk, amount)
    • [ ] Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to
  • IF AutoLine parameters are updated
    • [ ] EITHER is used, depending on the instruction:
    • DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
    • DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)
  • IF collateral debt ceiling (vat.ilk.line) is updated
  • [x] Collateral type (ilk) have AutoLine disabled previously or in the spell
  • [x] EITHER is used, depending on the instruction:
    • DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)
    • DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)
    • DssExecLib.setIlkDebtCeiling(ilk, amount)
  • [ ] Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER: ⚠️ This is not present in the spell, but is not required as the debt ceiling is only temporarily raised and set back to it's previous value (0) after
    • global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeiling
    • DssExecLib.setGlobalDebtCeiling(amount)
    • DssExecLib.increaseGlobalDebtCeiling(amount)
    • DssExecLib.decreaseGlobalDebtCeiling(amount)
• IF onboarding is present
  • [ ] Insert and follow the relevant checklists below:
  • Collateral Onboarding
  • RWA Onboarding
  • Teleport Onboarding
• IF collateral offboarding is present in the spell
  • 1st stage collateral offboarding
  • [ ] Collateral type (ilk) is removed from AutoLine (MCD_IAM_AUTO_LINE) IF currently enabled
  • [ ] Collateral debt ceiling (vat.ilk.line) is set to 0
  • [ ] Global debt ceiling (vat.Line) decreased by the total amount of offboarded ilks
  • 2nd stage collateral offboarding
  • [ ] All actions from the 1st stage offboarding are previously taken (EITHER in the current or past spells – check the archive)
  • [ ] Collateral liquidation penalty (chop) is set to 0 IF requested by governance
  • [ ] Flat keeper incentive (tip) is set to 0 IF requested by governance
  • [ ] Relative keeper incentive (chip) is set to 0 IF requested by governance
  • [ ] Max liquidation amount (hole) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount) IF requested by governance
  • [ ] Relevant clipper contract (MCD_CLIP_) is active (i.e. stopped is 0)
  • [ ] Liquidations are triggered via (depending on governance instruction):
    • EITHER liquidation ratio (spotter.ilk.mat) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio))
    • OR via enabling linear interpolation (DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration))
    • [ ] Ensure name format matches "XXX-X Offboarding"
    • [ ] Ensure target matches DssExecLib.spotter() address
    • [ ] Ensure ilk format matches collateral type (ilk) name ("XXX-X")
    • [ ] Ensure what matches string "mat"
    • [ ] Ensure startTime matches block.timestamp
    • [ ] Ensure start uses variable CURRENT_XXX_A_MAT
    • [ ] Ensure start matches current spotter.ilk.mat value
    • [ ] Ensure end uses variable TARGET_XXX_A_MAT
    • [ ] Ensure end value matches the instruction
    • [ ] Ensure end allows liquidation of all remaining vaults (end is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor)
    • [ ] Ensure duration matches the instruction
  • [ ] Spotter price is updated via DssExecLib.updateCollateralPrice(ilk) IF collateral have no running oracle (i.e. relevant PIP_ contract have outdated zzz value)
  • [ ] Spotter price is updated after all other actions
  • [ ] Offboarding is tested at least via _checkIlkClipper helper
• IF RWA updates are present
  • IF doc is updated
  • [ ] _updateDoc helper is copied one-to-one from the archive and defined above actions
  • [ ] _updateDoc(ilk, doc) is called in the spell
  • IF debt ceiling is updated
  • IF AutoLine update is requested by the Exec Doc
    • [ ] Parameters are set via DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl) or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
  • IF regular debt ceiling (vat.ilk.line) update is requested by the Exec Doc
    • [ ] Collateral type (ilk) have AutoLine disabled previously or in the spell
    • [ ] Debt ceiling (vat.ilk.line) is updated, via EITHER: * DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)
      • DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)
      • DssExecLib.setIlkDebtCeiling(ilk, amount)
    • [ ] Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:
      • global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeiling
      • DssExecLib.setGlobalDebtCeiling(amount)
      • DssExecLib.increaseGlobalDebtCeiling(amount)
      • DssExecLib.decreaseGlobalDebtCeiling(amount)
  • [ ] Liquidation oracle price is bumped via RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val) pattern
    • [ ] Comment above bump explains val computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"
    • [ ] Comment above bump provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei)
    • [ ] The formula matches the example provided above
    • [ ] debt_ceiling in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLine
    • [ ] rwa_stability_fee in the executable formula matches stability fee of the specified RWA found on chain
    • [ ] minimum_deal_duration_in_years in the executable formula matches number found in the Exec Doc of the spell containing relevant RWA onboarding
    • [ ] liquidation_ratio in the executable formula matches liquidation ratio of the specified RWA found on chain
    • [ ] Executing formula locally provides integer number that matches the val in the spell
    • [ ] val makes sense in context of the rate mechanism
  • [ ] IF multiple RWA ilks are being combined into one, val calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal
  • [ ] Oracle price is updated via DssExecLib.updateCollateralPrice(ilk)
  • IF soft liquidation explicitly requested to be triggered (via .tell(ilk)) AND debt ceiling is 0 (OR is being set to 0 in the current spell)
    • [ ] RwaLiquidationOracle.tell(ilk) call is present
    • [ ] IF RWAXX_A_INPUT_CONDUIT is an instance of TinlakeMgr (it is a Centrifuge integration), additional TinlakeMgr.tell() call is present (in order to prevent further TIN redemptions in the Centrifuge pool)
• IF payments are present in the spell
  • IF MKR transfers are present
  • [x] Recipient address in the instruction is in the checksummed format
  • [x] Recipient address matches Exec Doc
  • [x] Recipient address variable name matches one found in addresses_wallets.sol
  • [x] Transfer amount matches Exec Doc
  • [x] Transfer amount is specified with (at least) 2 decimals using ether keyword
  • [x] IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
  • [x] The transfers are tested via testMKRPayments test
  • [x] Sum of all MKR transfers tested in testMKRPayments matches number in the Exec Doc
  • IF DAI surplus buffer transfers are present
  • [x] Recipient address in the instruction is in the checksummed format
  • [x] Recipient address matches Exec Doc
  • [x] Recipient address variable name matches one found in addresses_wallets.sol
  • [x] Transfer amount matches Exec Doc
  • [x] The transfers are tested via testDAIPayments test
  • [x] Sum of all DAI transfers tested in testDAIPayments matches number in the Exec Doc
  • IF MKR or DAI streams (DssVest) are created
  • [ ] VestAbstract interface is imported from dss-interfaces/dss/VestAbstract.sol
  • [ ] restrict is used for each stream, UNLESS otherwise explicitly stated in the Exec Doc
  • [ ] usr (Vest recipient address) matches Exec Doc
  • [ ] usr address in the instruction is in the checksummed format
  • [ ] usr address variable name match one found in addresses_wallets.sol
  • [ ] tot (Total stream amount) matches Exec Doc
  • [ ] IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
  • [ ] IF vest amount is expressed in 'per year' or similar in the Exec Doc, account for leap days
  • [ ] bgn (Vest start timestamp) matches Exec Doc
  • [ ] tau is expressed as bgn - fin (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
  • [ ] fin (Vest end timestamp) matches Exec Doc
  • [ ] eta (Vest cliff duration) matches the following logic
    • IF eta is explicitly specified in the Exec Doc, then the values match
    • IF eta and clf (Cliff end timestamp) are not specified in the Exec Doc, then eta is 0
    • IF clf is specified, but clf <= bgn, then eta is 0
    • IF clf is specified and clf > bgn, eta is expressed as clf - bgn (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
  • [ ] IF mgr (Vest manager address) is specified in the Exec Doc, matches the value, OTHERWISE matches address(0)
  • [ ] Ensure that max vesting rate (cap) is enough for the new streams
    • The maximum vesting rate (tot divided by tau) <= the maximum vest streaming rate (cap)
    • The maximum vesting rate (tot divided by tau) > the maximum vest streaming rate (cap)
    • Calculate new cap value equal to 10% greater than the new maximum vesting rate, then round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)
  • IF max vesting rate (cap) is changed in the spell
    • [ ] Governance facilitators were notified
    • [ ] Exec Sheet contain explicit instruction
    • [ ] Exec Doc contain explicit instruction
  • IF MKR stream (DssVestTransferrable) is present
    • [ ] Vest contract's MKR allowance increased by the cumulative total (the sum of all tot values)
    • [ ] Ensure allowance increase follows archive patterns
  • [ ] Tested via testVestDAI or testVestMKR
  • IF MKR or DAI vest termination (Yank) is present
  • [ ] Yanked stream ID matches Exec Doc
  • [ ] MCD_VEST_MKR_TREASURY chainlog address is used for MKR stream yank
  • [ ] MCD_VEST_DAI chainlog address is used for DAI stream yank
  • [ ] Tested via testYankDAI or testYankMKR
• IF SubDAO-related content is present
  • IF SubDAO provides SubProxy spell address
  • [x] SubDAO spell address matches Exec Doc
  • [x] Executed via ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
  • [x] Execution is NOT delegate call
  • [x] IF SubDAO spell deployer is a smart contract (e.g. multisig or factory), ensure the deployer address is in addresses_deployers.sol as an entry
  • [ ] Ensure that SubDAO spell have enough gas and does not revert with "out of gas" error inside simulation. Note: low level call gas estimation is not done by our scripts ⚠️ Will be properly checked during casting on Tenderly
  • IF SubDAO provides instructions to be executed by the main spell (i.e. that will operate within Pause Proxy DelegateCall context)
  • [ ] No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)
  • [ ] SubDAO contract licensing and optimizations generally do not matter (except where they pose a security risk)
  • [ ] SubDAO contracts and all libraries / dependencies have verified source code (Blocking)
  • Upgradable SubDAO contracts
    • [ ] Upgradable contracts have the PAUSE_PROXY as their admin (i.e. the party that can upgrade)
    • [ ] Any upgradable SubDAO contracts with an admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)
  • [ ] All SubDAO content addresses (i.e. provided contract addresses or EOAs) present in the Maker Core spell are present in the Exec Doc and are correct. SubDAO addresses being authed or given any permissions MUST be in the Exec Doc. SubDAO addresses being called must be confirmed by the SubDAO spell team.
  • [ ] IF addresses not PR'ed in by the SubDAO team (use git blame for example), SubDAO content addresses all have inline comment for provenance or source being OKed by SubDAO
  • [ ] SubDAO actions match Exec Doc (only where inline with main spell code) and do not affect core contracts
  • [ ] Core contract knock-on actions (such as offboarding or setting DC to 0) are present in the exec and match the code
  • [ ] External calls for SubDAO content are NOT delegate call
  • [ ] Code does not have untoward behavior within the scope of Maker Core Contracts (e.g. up to the SubDAO proxy)
• IF external contracts calls are present (Not SubDAOs, e.g. Starknet)
  • [ ] Target Contract doesn't block spell execution
  • [ ] External call is NOT delegatecall
  • [ ] Target Contract doesn't have permissions on the Vat
  • [ ] Target Contract doesn't do anything untoward (e.g. interacting with unsafe contracts)
  • [ ] Contracts deployed via CREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their code
  • [ ] MCD Pause Proxy doesn't give any approvals
  • [ ] All possible actions of the Target Contract are documented
  • [ ] Target contract is not upgradable
  • [ ] Target Contract is included in the ChainLog
  • [ ] Test Coverage is comprehensive
• IF spell interacts with ChainLog
  • [ ] ChainLog version is incremented based on update type
  • Major -> New Vat (++.0.0)
  • Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
  • Patch -> Collateral addition or addition/modification (0.0.++)
  • [ ] New addresses are added to the addresses_mainnet.sol
  • [ ] Changes are tested via testNewOrUpdatedChainlogValues
• [x] Ensure every spell variable is declared as public/internal
• [x] Ensure immutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses
  • [x] Fetch addresses as type address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)
  • [x] Use the DssExecLib Core Address Helpers where possible (e.g. DssExecLib.vat())
  • [x] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)
• [x] Spell actions match the corresponding Exec Doc ⚠️ Exec Doc currently contains two duplicative instructions, but they don't affect the spell as even if executed twice will have the same effect
• Tests
  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit Insert most recent commit hash where CI was passing 2de92a3522453f0a3970b3a7434b3f0fda671a49
  • [x] Ensure every test function is declared as public
  • [x] IF the test needs to run, it MUST NOT have the skipped modifier; OTHERWISE, it MUST have the skipped modifier
  • [x] Ensure each spell action has sufficient test coverage List actions for which coverage was checked here
  • MKR Transfers
    • tested via testMKRPayments
  • DAI Transfers
    • tested via testDAIPayments
  • Call kiss on RWA015_A_OUTPUT_CONDUIT with address 0x6759610547a36E9597Ef452aa0B9cace91291a2f
    • tested via testRWA015NewBud and testRWA015OutputConduitPushWithNewBud
  • Push USDP out of input conduit
    • tested via testPushPAXOutInputConduit
  • Spark Proxy Spell
    • tested via testSparkSpellIsExecuted
  • [x] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")
  • [x] Check all tests are passing locally using make test
  • [x] Ensure every test listed in the coverage item above is present in the logs and with the [PASS] prefix.

_Insert your local test logs here_
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠔] Compiling...
[⠊] Compiling 5 files with 0.8.16
[⠢] Solc 0.8.16 finished in 3.58s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1288521)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 31.97s (27.40s CPU time)

Ran 36 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 1145675)
[PASS] testCastOnTime() (gas: 1142549)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 9512313)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 11162)
[PASS] testDAIPayments() (gas: 1213653)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 2563628)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 27822703)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testMKRPayments() (gas: 1289780)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 353796)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 13422)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 2440064)
[PASS] testPushPAXOutInputConduit() (gas: 1161950)
[PASS] testRWA015NewBud() (gas: 1152184)
[PASS] testRWA015OutputConduitPushWithNewBud(address) (runs: 256, μ: 1400808, ~: 1400808)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17610)
[PASS] testSparkSpellIsExecuted() (gas: 1148488)
[PASS] testUseEta() (gas: 352506)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 17 passed; 0 failed; 19 skipped; finished in 404.99s (1015.27s CPU time)

Ran 2 test suites in 406.01s (436.95s CPU time): 19 tests passed, 0 failed, 19 skipped (38 total tests)

[0xp3th1um]

TLDR: Good to deploy!

Mainnet Executive Spell Review Checklist

Development Stage

• Preparation

  • [x] Exec Sheet for the specified date is found in the "Executive Vote Implementation Process" google sheet Insert URL to the specific sheet here https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/edit#gid=684547605

  • [x] Exec Doc for the specified date is found in the makerdao/community GitHub repo

  • [x] Exec Doc file name follows the format Executive vote - Month DD, YYYY.md

  • [x] Extract permanent URL to the raw markdown file and paste it below Insert your Raw Exec Doc URL here https://raw.githubusercontent.com/makerdao/community/48e8ec892d004e2f350930eaebd0d9e7e23cbd84/governance/votes/Executive%20vote%20-%20April%2018%2C%202024.md

  • [x] Using Exec Doc URL from the above and the TARGET_DATE, generate Exec Doc Hash via make exec-hash date=$TARGET_DATE $URL Insert your Exec Doc Hash here ⚠️ Script is not working on Mac

  • [ ] Using Exec Doc URL from the above, generate Exec Doc Hash via cast keccak -- "$(curl '$URL' -o - 2>/dev/null)" Insert your Exec Doc Hash here 0x71efd61f3800b237e562b1ad518d90b9a155fa6565c98c1cd8d383afcc69b146

  • [x] Using Exec Doc URL from the above, read spell instructions from the Exec Doc and list them below List all instructions announced in the Exec Doc

    • Aligned Delegate Compensation for March 2024: the following transfers totalling 214.55 MKR for Aligned Delegate Compensation will be made to qualifying Aligned Delegates.

      • BONAPUBLICA 0x167c1a762B08D7e78dbF8f24e5C3f1Ab415021D3 41.67
      • Cloaky 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818 41.67
      • TRUE NAME 0x612F7924c367575a0Edf21333D96b15F1B345A5d 41.67
      • BLUE 0xb6C09680D822F162449cdFB8248a7D3FC26Ec9Bf 39.75
      • vigilant 0x2474937cB55500601BCCE9f4cb0A0A72Dc226F61 13.89
      • Pipkin 0x0E661eFE390aE39f90a58b04CF891044e56DEDB7 13.89
      • JAG 0x58D1ec57E4294E4fe650D1CB12b96AE34349556f 9.08
      • UPMaker 0xbB819DF169670DC71A16F58F55956FE642cc6BcD 12.93

    • AVC Members Compensation Q1 2024: the following distributions totalling 175.14 MKR will be made for Q1 2024 AVC member compensation.

      • IamMeeoh 0x47f7A5d8D27f259582097E1eE59a07a816982AE9 20.85
      • DAI-Vinci 0x9ee47F0f82F1A6F45C4E1D25Ce95C321D8C8356a 20.85
      • opensky 0xf44f97f4113759E0a57756bE49C0655d490Cf19F 20.85
      • ACRE DAOs 0xBF9226345F601150F64Ea4fEaAE7E40530763cbd 20.85
      • Res 0x8c5c8d76372954922400e4654AF7694e158AB784 20.85
      • Harmony 0xE20A2e231215e9b7Aa308463F1A7490b2ECE55D3 20.85
      • Libertas 0xE1eBfFa01883EF2b4A9f59b587fFf1a5B44dbb2f 20.85
      • seedlatam.eth 0xd43b89621fFd48A8A51704f85fd0C87CbC0EB299 20.85
      • 0xRoot 0xC74392777443a11Dc26Ce8A3D934370514F38A91 8.34

    • Aave Revenue Share Payment: a payment from the Surplus Buffer of 238,339 DAI to a smart contract 0x464C71f6c2F760DdA6093dCB91C24c39e5d6e18c controlled by Aave Governance will be made as part of the Spark Protocol-Aave Revenue Share.

    • Whitelist New Address in the RWA015-A Output Conduit: the following address will be whitelisted in the RWA015-A output conduit:

      • 0x6759610547a36E9597Ef452aa0B9cace91291a2f

    • Push USDP Out of the Input Conduit Authorization: following the recommendation of the Governance Facilitators in collaboration with the spell team, the following operations will be performed:

      • Raise the PSM_PAX_A Debt Ceiling to 100,000 DAI.
      • Call push(uint256 amt) on the the PSM_PAX_A_INPUT_CONDUIT_JAR contract with an amount of 84,211.27 USDP, depositing the contents of the contract to the PSM and receiving an identical amount of Dai into the PSM_PAX_A_JAR contract.
      • Call void() on the PSM_PAX_A_JAR contract to deposit the Dai to the Surplus Buffer.
      • Set PSM-PAX-A Debt Ceiling to 0 DAI.
      • Decrease Debt Ceiling of PSM_PAX_A back to 0 DAI.

      This will have the following net results:

      • The PSM_PAX_A Debt Debt Ceiling remains at 0 DAI after the transaction has been executed.
      • Dai generated from PSM_PAX_A increases by 84,211.27 DAI.
      • USDP balance of MCD_JOIN_PSM_PAX_A increases by 84,211.27 USDP.
      • USDP balance of PSM_PAX_A_INPUT_CONDUIT_JAR decreases to 0 USDP.
      • Surplus Buffer increases by 84,211.27 DAI.

    • Trigger Spark Proxy Spell: the SparkLend Proxy Spell on Ethereum at 0x3d1DD14Fa08163E7f64b0abf0F514f6276f50882 will be executed.

  • [x] Ensure that instructions announced in the Exec Doc match instructions in the Exec Sheet

• Base checks

  • [x] Current solc version 0.8.16
  • [x] Office hours is true IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding) OTHERWISE explicitly set to false
  • [x] Office hours value matches the Exec Sheet
  • [x] Office hours value matches the Exec Doc
  • [x] 30 days spell expiry set in the constructor (block.timestamp + 30 days)

• Spell description

  • [x] Description follows the format TARGET_DATE MakerDAO Executive Spell | Hash: EXEC_DOC_HASH
  • [x] TARGET_DATE in the description matches the Exec Doc target date
  • [x] Accompanying comment above spell description follows the format // Hash: cast keccak -- "$(wget 'EXEC_DOC_URL' -q -O - 2>/dev/null)"
  • [ ] Exec Doc URL in comment matches your Raw Exec Doc URL above ⚠️ It does not match (not the latest commit), but the hash is the same so it is fine
  • [x] Exec Doc URL in comment refers to the https://github.com/makerdao/community repo

• Comments inside the spell

  • [x] Every Section text from the Exec Sheet is copied to the spell code as a comment surrounded by the set of dashes (E.g. // ----- Section text -----)
  • [x] Every Instruction text from the Exec Sheet is copied to the spell code as // Instruction text
  • [x] Every Instruction text have newline above it
  • [x] IF an instruction can not be taken, it should have explanation under the instruction prefixed with // Note: (e.g.: // Note: Payments are skipped on goerli)
  • [x] IF action in the spell doesn't have relevant instruction (e.g.: chainlog version bump), the necessity of it is explained in the comment above prefixed with // Note:
  • [x] Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL is present in the spell code under relevant section or instruction (depending on which row the url is present)
  • [x] Every proof url from the Exec Sheet, such as Reasoning URL and Authority URL have prefix derived from the url itself
  • // Executive Vote: if URL starts with https://vote.makerdao.com/executive/
  • // Poll: if URL starts with https://vote.makerdao.com/polling/
  • // Forum: if URL starts with https://forum.makerdao.com/t/
  • // MIP: if URL starts with https://mips.makerdao.com/mips/details/

• Dependency checks

  • [x] Update Foundry by running foundryup
  • [x] Reinstall libraries by running rm -rf ./lib && git submodule update --init --recursive

    Insert checked out submodule paths here
    Submodule path 'lib/dss-exec-lib': checked out '69b658f35d8618272cd139dfc18c5713caf6b96b'
    Submodule path 'lib/dss-exec-lib/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-exec-lib/lib/forge-std': checked out '0aa99eb8456693c015350c5e6c4f442ebe912f77'
    Submodule path 'lib/dss-exec-lib/lib/forge-std/lib/ds-test': checked out 'cd98eff28324bfac652e63a239a60632a761790b'
    Submodule path 'lib/dss-test': checked out '36ff4adbcb35760614e0d2df864026991c23d028'
    Submodule path 'lib/dss-test/lib/dss-interfaces': checked out '9bfd7afadd1f8c217ef05850b2555691786286cb'
    Submodule path 'lib/dss-test/lib/forge-std': checked out '155d547c449afa8715f538d69454b83944117811'
    Submodule path 'lib/dss-test/lib/forge-std/lib/ds-test': checked out 'e282159d5170298eb2455a6c05280ab5a73a4ef0'

  • [ ] IF submodule upgrades are present, make sure dss-exec-lib is synced as well
  • [x] git submodule hash of dss-exec-lib (run git submodule status) matches the latest release version or newer
  • [x] dss-interfaces library used inside lib/dss-exec-lib matches submodule used inside lib/dss-test

• IF interfaces are present in the spell

  • Interfaces imported from dss-interfaces
  • [x] No unused dss-interfaces
  • [x] Only single import layout is used (e.g. import "dss-interfaces/dss/VatAbstract.sol";)
  • Static Interfaces
  • [x] No unused static interfaces
  • [x] Declared static interface not present in the dss-interfaces, OTHERWISE should be imported from there
  • [x] Interface matches deployed contract using cast interface <contract_address> command
  • [x] Interface naming style should match with Like suffix (e.g. VatLike)
    • EXCEPTION: known interface naming exceptions
  • [x] Each static interface declare only functions actually used in the spell code

• IF variable declarations are present in the spell

  • IF precision units are present
  • [ ] Precision units used in the spell match their defined values:
    • WAD = 10 ** 18
    • RAY = 10 ** 27
    • RAD = 10 ** 45
  • [ ] Precision units match with Numerical Ranges
  • [ ] Each variable visibility is declared as internal
  • [ ] Each variable state mutability is declared as constant
  • IF math units are present
  • [ ] Match their defined values:
    • HUNDRED = 10 ** 2
    • THOUSAND = 10 ** 3
    • MILLION = 10 ** 6
    • BILLION = 10 ** 9
  • [ ] Match with config
  • [ ] Each variable visibility is declared as internal
  • [ ] Each variable state mutability is declared as constant
  • IF rates are present
  • [ ] Rates match generated locally via make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
  • [ ] Rates match IPFS document
  • [ ] Rate variable name conforms to X_PT_Y_Z_PCT_RATE (e.g. ZERO_PT_SEVEN_FIVE_PCT_RATE for 0.75%)
  • [ ] Rate variable visibility declared as internal
  • [ ] Rate variable state mutability declared as constant
  • IF timestamps are present
  • [ ] Comment above timestamp states full date including UTC timezone
  • [ ] Timestamp converts back to the correct date
  • [ ] Timestamp converts back to the UTC timezone
  • [ ] Variable naming matches MMM_DD_YYYY (e.g. JAN_01_2023 for 2023-01-01)
  • [ ] Time of day makes logical sense in the context of timestamp usage (i.e. 23:59:59 UTC for the final day of something, 00:00:00 UTC for the first day of something)
  • [ ] Each variable visibility is declared as internal
  • [ ] Each variable state mutability is declared as constant

• IF new contract is present in the spell (not yet on chainlog or new to chainlog)

  • [ ] Source code is verified on etherscan
  • [ ] Compilation optimizations match deployment settings defined in the source code repo
  • [ ] GNU AGPLv3 license
  • [ ] Every maker-related constructor argument matches chainlog (e.g. vat, dai, dog, ...)
  • IF new contract have concept of wards or access control
  • [ ] Ensure PAUSE_PROXY address was relied (wards(PAUSE_PROXY) is 1)
  • [ ] Ensure that contract deployer address was denied (wards(deployer) is 0)
  • [ ] Ensure MCD_ESM address is already relied OR being relied (wards(MCD_ESM) is 1) in this spell (as approved by Governance Facilitators, in order to allow de-authing the pause proxy during Emergency Shutdown, via denyProxy)
  • [ ] Ensure that there are no other Rely events except for PAUSE_PROXY and MCD_ESM (using a block explorer like etherscan)
  • [ ] Source code matches corresponding github source code (e.g. diffcheck via vscode code --diff etherscan.sol github.sol)
  • [ ] Deployer address is included into addresses_deployers.sol

• IF core system parameter changes are present in the instructions

  • IF stability fee (jug.ilk.duty) is updated
  • [ ] (DssExecLib.setIlkStabilityFee(ilk, rate, doDrip)) is used
  • [ ] Comment matches pattern // Increase ILK-A Stability Fee by X.XX% from X.XX% to X.XX%
  • IF Dai Savings Rate (pot.dsr) is updated
  • [ ] (DssExecLib.setDSR(rate, doDrip)) is used
  • [ ] Comment matches pattern // Increase DSR by X.XX% from X.XX% to X.XX%
  • [ ] Double check that rate match make rates pct=<pct> (e.g. pct=0.75, for 0.75%)
  • [ ] Double check that rate match IPFS document
  • [ ] IF spotter.ilk.mat is updated, (DssExecLib.setIlkLiquidationRatio(ilk, pct_bps)) is used
  • [ ] IF dog.ilk.hole is updated, (DssExecLib.setIlkMaxLiquidationAmount(ilk, amount)) is used
  • [ ] IF vat.ilk.dust is updated, (DssExecLib.setIlkMinVaultAmount(ilk, amount)) is used
  • [ ] IF dog.ilk.chop is updated, (DssExecLib.setIlkLiquidationPenalty(ilk, pct_bps)) is used
  • [ ] IF clip.buf is updated, (DssExecLib.setStartingPriceMultiplicativeFactor(ilk, pct_bps)) is used
  • [ ] IF clipperMom.clip.tolerance is updated, (DssExecLib.setLiquidationBreakerPriceTolerance(clip, pct_bps)) is used
  • [ ] IF clip.tail is updated, (DssExecLib.setAuctionTimeBeforeReset(ilk, duration)) is used
  • [ ] IF clip.cusp is updated, (DssExecLib.setAuctionPermittedDrop(ilk, pct_bps)) is used
  • [ ] IF clip.chip is updated, (DssExecLib.setKeeperIncentivePercent(ilk, pct_bps)) is used
  • [ ] IF clip.tip is updated, (DssExecLib.setKeeperIncentiveFlatRate(ilk, amount)) is used
  • [ ] IF calc.tau is updated, (DssExecLib.setLinearDecrease(calc, duration)) is used
  • [ ] IF calc.cut or calc.step are updated, DssExecLib.setStairstepExponentialDecrease(calc, duration, pct_bps) is used

• IF debt ceiling changes are present in the instructions

  • IF adjusted collateral type (ilk) have AutoLine enabled (MCD_IAM_AUTO_LINE)
  • IF collateral debt ceiling requested to be 0
    • [ ] Collateral is removed from AutoLine (MCD_IAM_AUTO_LINE) via DssExecLib.removeIlkFromAutoLine(ilk)
    • [ ] The instruction to remove from AutoLine (MCD_IAM_AUTO_LINE) is present in the Exec Sheet
    • [ ] Collateral debt ceiling is set to 0 via DssExecLib.setIlkDebtCeiling(ilk, amount)
    • [ ] Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to
  • IF AutoLine parameters are updated
    • [ ] EITHER is used, depending on the instruction:
    • DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
    • DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl)
  • IF collateral debt ceiling (vat.ilk.line) is updated
  • [x] Collateral type (ilk) have AutoLine disabled previously or in the spell
  • [x] EITHER is used, depending on the instruction:
    • DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)
    • DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)
    • DssExecLib.setIlkDebtCeiling(ilk, amount)
  • [ ] Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER: ⚠️ None of the functions below is used, since the debt ceiling of the collateral is set back to 0.
    • global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeiling
    • DssExecLib.setGlobalDebtCeiling(amount)
    • DssExecLib.increaseGlobalDebtCeiling(amount)
    • DssExecLib.decreaseGlobalDebtCeiling(amount)

• IF onboarding is present

  • [ ] Insert and follow the relevant checklists below:
  • Collateral Onboarding
  • RWA Onboarding
  • Teleport Onboarding

• IF collateral offboarding is present in the spell

  • 1st stage collateral offboarding
  • [ ] Collateral type (ilk) is removed from AutoLine (MCD_IAM_AUTO_LINE) IF currently enabled
  • [ ] Collateral debt ceiling (vat.ilk.line) is set to 0
  • [ ] Global debt ceiling (vat.Line) decreased by the total amount of offboarded ilks
  • 2nd stage collateral offboarding
  • [ ] All actions from the 1st stage offboarding are previously taken (EITHER in the current or past spells – check the archive)
  • [ ] Collateral liquidation penalty (chop) is set to 0 IF requested by governance
  • [ ] Flat keeper incentive (tip) is set to 0 IF requested by governance
  • [ ] Relative keeper incentive (chip) is set to 0 IF requested by governance
  • [ ] Max liquidation amount (hole) is adjusted via DssExecLib.setIlkMaxLiquidationAmount(ilk, amount) IF requested by governance
  • [ ] Relevant clipper contract (MCD_CLIP_) is active (i.e. stopped is 0)
  • [ ] Liquidations are triggered via (depending on governance instruction):
    • EITHER liquidation ratio (spotter.ilk.mat) being set very high in the spell (using DssExecLib.setValue(DssExecLib.spotter(), ilk, "mat", ratio))
    • OR via enabling linear interpolation (DssExecLib.linearInterpolation(name, target, ilk, what, startTime, start, end, duration))
    • [ ] Ensure name format matches "XXX-X Offboarding"
    • [ ] Ensure target matches DssExecLib.spotter() address
    • [ ] Ensure ilk format matches collateral type (ilk) name ("XXX-X")
    • [ ] Ensure what matches string "mat"
    • [ ] Ensure startTime matches block.timestamp
    • [ ] Ensure start uses variable CURRENT_XXX_A_MAT
    • [ ] Ensure start matches current spotter.ilk.mat value
    • [ ] Ensure end uses variable TARGET_XXX_A_MAT
    • [ ] Ensure end value matches the instruction
    • [ ] Ensure end allows liquidation of all remaining vaults (end is bigger than collateral_type_collateralization_ratio * risk_multiplier_factor)
    • [ ] Ensure duration matches the instruction
  • [ ] Spotter price is updated via DssExecLib.updateCollateralPrice(ilk) IF collateral have no running oracle (i.e. relevant PIP_ contract have outdated zzz value)
  • [ ] Spotter price is updated after all other actions
  • [ ] Offboarding is tested at least via _checkIlkClipper helper

• IF RWA updates are present

  • IF doc is updated
  • [ ] _updateDoc helper is copied one-to-one from the archive and defined above actions
  • [ ] _updateDoc(ilk, doc) is called in the spell
  • IF debt ceiling is updated
  • IF AutoLine update is requested by the Exec Doc
    • [ ] Parameters are set via DssExecLib.setIlkAutoLineParameters(ilk, amount, gap, ttl) or DssExecLib.setIlkAutoLineDebtCeiling(ilk, amount)
  • IF regular debt ceiling (vat.ilk.line) update is requested by the Exec Doc
    • [ ] Collateral type (ilk) have AutoLine disabled previously or in the spell
    • [ ] Debt ceiling (vat.ilk.line) is updated, via EITHER:
    • DssExecLib.increaseIlkDebtCeiling(ilk, amount, global)
    • DssExecLib.decreaseIlkDebtCeiling(ilk, amount, global)
    • DssExecLib.setIlkDebtCeiling(ilk, amount)
    • [ ] Global debt ceiling (vat.Line) is updated accordingly, UNLESS specifically instructed not to, via EITHER:
    • global set to true in increaseIlkDebtCeiling/decreaseIlkDebtCeiling
    • DssExecLib.setGlobalDebtCeiling(amount)
    • DssExecLib.increaseGlobalDebtCeiling(amount)
    • DssExecLib.decreaseGlobalDebtCeiling(amount)
  • [ ] Liquidation oracle price is bumped via RwaLiquidationOracleLike(MIP21_LIQUIDATION_ORACLE).bump(ilk, val) pattern
    • [ ] Comment above bump explains val computation via // Note: the formula is: "debt_ceiling * [ (1 + rwa_stability_fee ) ^ (minimum_deal_duration_in_years) ] * liquidation_ratio"
    • [ ] Comment above bump provides locally executable formula (e.g. // bc -l <<< 'scale=18; 50000000 * e(l(1.07) * (3342/365)) * 1.00' | cast --to-wei)
    • [ ] The formula matches the example provided above
    • [ ] debt_ceiling in the executable formula matches new debt ceiling set in the spell or the maximum possible debt ceiling in case of the enabled AutoLine
    • [ ] rwa_stability_fee in the executable formula matches stability fee of the specified RWA found on chain
    • [ ] minimum_deal_duration_in_years in the executable formula matches number found in the Exec Doc of the spell containing relevant RWA onboarding
    • [ ] liquidation_ratio in the executable formula matches liquidation ratio of the specified RWA found on chain
    • [ ] Executing formula locally provides integer number that matches the val in the spell
    • [ ] val makes sense in context of the rate mechanism
  • [ ] IF multiple RWA ilks are being combined into one, val calculation is done once per ilk and added to make the total, with separate executable formulas provided in comments. The existing val value can be retrieved by calling read() on PIP_RWAXX and converting the result into decimal
  • [ ] Oracle price is updated via DssExecLib.updateCollateralPrice(ilk)
  • IF soft liquidation explicitly requested to be triggered (via .tell(ilk)) AND debt ceiling is 0 (OR is being set to 0 in the current spell)
    • [ ] RwaLiquidationOracle.tell(ilk) call is present
    • [ ] IF RWAXX_A_INPUT_CONDUIT is an instance of TinlakeMgr (it is a Centrifuge integration), additional TinlakeMgr.tell() call is present (in order to prevent further TIN redemptions in the Centrifuge pool)

• IF payments are present in the spell

  • IF MKR transfers are present
  • [x] Recipient address in the instruction is in the checksummed format
  • [x] Recipient address matches Exec Doc
  • [x] Recipient address variable name matches one found in addresses_wallets.sol
  • [x] Transfer amount matches Exec Doc
  • [x] Transfer amount is specified with (at least) 2 decimals using ether keyword
  • [x] IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
  • [x] The transfers are tested via testMKRPayments test
  • [x] Sum of all MKR transfers tested in testMKRPayments matches number in the Exec Doc
  • IF DAI surplus buffer transfers are present
  • [x] Recipient address in the instruction is in the checksummed format
  • [x] Recipient address matches Exec Doc
  • [x] Recipient address variable name matches one found in addresses_wallets.sol
  • [x] Transfer amount matches Exec Doc
  • [x] The transfers are tested via testDAIPayments test
  • [x] Sum of all DAI transfers tested in testDAIPayments matches number in the Exec Doc
  • IF MKR or DAI streams (DssVest) are created
  • [ ] VestAbstract interface is imported from dss-interfaces/dss/VestAbstract.sol
  • [ ] restrict is used for each stream, UNLESS otherwise explicitly stated in the Exec Doc
  • [ ] usr (Vest recipient address) matches Exec Doc
  • [ ] usr address in the instruction is in the checksummed format
  • [ ] usr address variable name match one found in addresses_wallets.sol
  • [ ] tot (Total stream amount) matches Exec Doc
  • [ ] IF ether keyword is used, comment is present on the same line // Note: ether is a keyword helper, only MKR is transferred here
  • [ ] IF vest amount is expressed in 'per year' or similar in the Exec Doc, account for leap days
  • [ ] bgn (Vest start timestamp) matches Exec Doc
  • [ ] tau is expressed as bgn - fin (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
  • [ ] fin (Vest end timestamp) matches Exec Doc
  • [ ] eta (Vest cliff duration) matches the following logic
    • IF eta is explicitly specified in the Exec Doc, then the values match
    • IF eta and clf (Cliff end timestamp) are not specified in the Exec Doc, then eta is 0
    • IF clf is specified, but clf <= bgn, then eta is 0
    • IF clf is specified and clf > bgn, eta is expressed as clf - bgn (i.e. MONTH_DD_YYYY - MONTH_DD_YYYY)
  • [ ] IF mgr (Vest manager address) is specified in the Exec Doc, matches the value, OTHERWISE matches address(0)
  • [ ] Ensure that max vesting rate (cap) is enough for the new streams
    • The maximum vesting rate (tot divided by tau) <= the maximum vest streaming rate (cap)
    • The maximum vesting rate (tot divided by tau) > the maximum vest streaming rate (cap)
    • Calculate new cap value equal to 10% greater than the new maximum vesting rate, then round new cap up with 2 significant figure precision (i.e. 2446 becomes 2500)
  • IF max vesting rate (cap) is changed in the spell
    • [ ] Governance facilitators were notified
    • [ ] Exec Sheet contain explicit instruction
    • [ ] Exec Doc contain explicit instruction
  • IF MKR stream (DssVestTransferrable) is present
    • [ ] Vest contract's MKR allowance increased by the cumulative total (the sum of all tot values)
    • [ ] Ensure allowance increase follows archive patterns
  • [ ] Tested via testVestDAI or testVestMKR
  • IF MKR or DAI vest termination (Yank) is present
  • [ ] Yanked stream ID matches Exec Doc
  • [ ] MCD_VEST_MKR_TREASURY chainlog address is used for MKR stream yank
  • [ ] MCD_VEST_DAI chainlog address is used for DAI stream yank
  • [ ] Tested via testYankDAI or testYankMKR

• IF SubDAO-related content is present

  • IF SubDAO provides SubProxy spell address
  • [x] SubDAO spell address matches Exec Doc
  • [x] Executed via ProxyLike(SUBDAO_PROXY).exec(SUBDAO_SPELL, abi.encodeWithSignature("execute()"));
  • [x] Execution is NOT delegate call
  • [x] IF SubDAO spell deployer is a smart contract (e.g. multisig or factory), ensure the deployer address is in addresses_deployers.sol as an entry
  • [ ] Ensure that SubDAO spell have enough gas and does not revert with "out of gas" error inside simulation. Note: low level call gas estimation is not done by our scripts ⚠️ Cannot be performed now, but later on the casting phase
  • IF SubDAO provides instructions to be executed by the main spell (i.e. that will operate within Pause Proxy DelegateCall context)
  • [ ] No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)
  • [ ] SubDAO contract licensing and optimizations generally do not matter (except where they pose a security risk)
  • [ ] SubDAO contracts and all libraries / dependencies have verified source code (Blocking)
  • Upgradable SubDAO contracts
    • [ ] Upgradable contracts have the PAUSE_PROXY as their admin (i.e. the party that can upgrade)
    • [ ] Any upgradable SubDAO contracts with an admin that is not PAUSE_PROXY are not authed on any core contracts (Blocking)
  • [ ] All SubDAO content addresses (i.e. provided contract addresses or EOAs) present in the Maker Core spell are present in the Exec Doc and are correct. SubDAO addresses being authed or given any permissions MUST be in the Exec Doc. SubDAO addresses being called must be confirmed by the SubDAO spell team.
  • [ ] IF addresses not PR'ed in by the SubDAO team (use git blame for example), SubDAO content addresses all have inline comment for provenance or source being OKed by SubDAO
  • [ ] SubDAO actions match Exec Doc (only where inline with main spell code) and do not affect core contracts
  • [ ] Core contract knock-on actions (such as offboarding or setting DC to 0) are present in the exec and match the code
  • [ ] External calls for SubDAO content are NOT delegate call
  • [ ] Code does not have untoward behavior within the scope of Maker Core Contracts (e.g. up to the SubDAO proxy)

• IF external contracts calls are present (Not SubDAOs, e.g. Starknet)

  • [ ] Target Contract doesn't block spell execution
  • [ ] External call is NOT delegatecall
  • [ ] Target Contract doesn't have permissions on the Vat
  • [ ] Target Contract doesn't do anything untoward (e.g. interacting with unsafe contracts)
  • [ ] Contracts deployed via CREATE2 (e.g. if it looks like a vanity address) do not have selfdestruct in their code
  • [ ] MCD Pause Proxy doesn't give any approvals
  • [ ] All possible actions of the Target Contract are documented
  • [ ] Target contract is not upgradable
  • [ ] Target Contract is included in the ChainLog
  • [ ] Test Coverage is comprehensive

• IF spell interacts with ChainLog

  • [ ] ChainLog version is incremented based on update type
  • Major -> New Vat (++.0.0)
  • Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
  • Patch -> Collateral addition or addition/modification (0.0.++)
  • [ ] New addresses are added to the addresses_mainnet.sol
  • [ ] Changes are tested via testNewOrUpdatedChainlogValues

• [x] Ensure every spell variable is declared as public/internal

• [x] Ensure immutable visibility is only used when fetching addresses from the ChainLog via DssExecLib.getChangelogAddress(key) and constant is used instead for static addresses

  • [x] Fetch addresses as type address and wrap with Like suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (Such as MKR)
  • [x] Use the DssExecLib Core Address Helpers where possible (e.g. DssExecLib.vat())
  • [x] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. MCD_VAT rather than vat), except where the archive pattern differs from this pattern (e.g. MKR)

• [x] Spell actions match the corresponding Exec Doc

• Tests

  • [x] Ensure that the DssExecLib.address file is not being modified by the spell PR
  • [x] Check all CI tests are passing as at the latest commit Insert most recent commit hash where CI was passing https://github.com/makerdao/spells-mainnet/commit/cb573070bfa140893ce61b99bfe9bf743408b5c7
  • [x] Ensure every test function is declared as public
  • [x] IF the test needs to run, it MUST NOT have the skipped modifier; OTHERWISE, it MUST have the skipped modifier
  • [x] Ensure each spell action has sufficient test coverage List actions for which coverage was checked here [x] AD Compensation ✅ tested via testMKRPayments [x] AVC Member Compensation ✅ tested via testMKRPayments [x] Aave Revenue Share ✅ tested via testDAIPayments [x] Whitelist new address in the RWA015-A output conduit ✅ tested via testRWA015NewBud testRWA015OutputConduitPushWithNewBud and testPushPAXOutInputConduit [x] Push USDP out of input conduit ✅ tested via testPushPAXOutInputConduit [x] Spark Proxy Spell ✅ tested via testSparkSpellIsExecuted

• [x] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of printenv | grep "FOUNDRY_\|DAPP_")

• [x] Check all tests are passing locally using make test

  • [x] Ensure every test listed in the coverage item above is present in the logs and with the [PASS] prefix.

_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠆] Compiling...
[⠊] Compiling 7 files with 0.8.16
[⠒] Solc 0.8.16 finished in 4.70s
Compiler run successful!

Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 1288521)
[PASS] testStarknetSpell() (gas: 2324)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 39.99s (33.19s CPU time)

Ran 36 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 1145675)
[PASS] testCastOnTime() (gas: 1142549)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 9512313)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 11162)
[PASS] testDAIPayments() (gas: 1213538)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 2563628)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 27822703)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testMKRPayments() (gas: 1289780)
[SKIP] testMedianizers() (gas: 0)
[SKIP] testNewIlkRegistryValues() (gas: 0)
[PASS] testNextCastTime() (gas: 353796)
[SKIP] testOSMs() (gas: 0)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 13422)
[SKIP] testOracleList() (gas: 0)
[PASS] testPSMs() (gas: 2440064)
[PASS] testPushPAXOutInputConduit() (gas: 1161950)
[PASS] testRWA015NewBud() (gas: 1152184)
[PASS] testRWA015OutputConduitPushWithNewBud(address) (runs: 256, μ: 1400808, ~: 1400808)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17610)
[PASS] testSparkSpellIsExecuted() (gas: 1148488)
[PASS] testUseEta() (gas: 352506)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 17 passed; 0 failed; 19 skipped; finished in 464.46s (1093.23s CPU time)

Ran 2 test suites in 465.23s (504.45s CPU time): 19 tests passed, 0 failed, 19 skipped (38 total tests)

[SidestreamStrongStrawberry]

The target date is updated. New PR: https://github.com/makerdao/spells-mainnet/pull/406