search

makerdao / token-auction

Continuous Splitting Token Auction
GNU Affero General Public License v3.0
21 stars 21 forks source link

bids strictly increase, even for small tokens #42

Closed jorisbontje closed 8 years ago

jorisbontje commented 8 years ago

regarding https://github.com/makerdao/token-auction/commit/dab6b6014c8b20c41996ed730a6186113d3be7ce

This means that if I have an auction of 1.00 MKR with starting bid of 1.00 MKR and 1% min_increase; you have to bid MORE than 1.01 ETH.

The min_increase does already / enforce a minimum increase; so this could be >= as assertion condition in the case where min_increase is set. For the case where min_increase is zero, I suggest to addassert(bid_how_much > a.buy_amount);

rainbreak commented 8 years ago

Random thought: another way of setting the bid delta is to provide (u, v) of b' = u + vb. This would allow for both relative and absolute increase.