search

makerdao / token-auction

Continuous Splitting Token Auction
GNU Affero General Public License v3.0
21 stars 21 forks source link

division by zero #55

Open jorisbontje opened 8 years ago

jorisbontje commented 8 years ago

pre Solidity 0.4, division by zero returns 0 instead of throwing. we might want to assert divisors to be > 0, such as https://github.com/makerdao/token-auction/blob/master/contracts/auction.sol#L213

rainbreak commented 7 years ago

I think that upgrading to 0.4 (#57) and using a pragma is sufficient here.