makerdao / token-auction

Continuous Splitting Token Auction
GNU Affero General Public License v3.0
21 stars 21 forks source link

upgrade to dapple 0.8 / solidity 0.4 #59

Closed rainbreak closed 8 years ago

rainbreak commented 8 years ago

Fixes #57, #55.

TODO:

The latter appears to be dapple / solidity issue, probably exposed by the largish setUp method in the auction tests (which creates several new contracts).

The global setUp method could be replaced by some use of dapple script - this would set the initial chain state from which each unit test would fork from.

rainbreak commented 8 years ago

@mhhf: I still can't work out these deployment failures. There seems to be some relation to test contract size, but it isn't at all direct.

Some data points:

It feels like a race condition, but ¯_(ツ)_/¯

rainbreak commented 8 years ago

@mhhf: https://github.com/ethereumjs/ethereumjs-vm/pull/91 fixes the deployment failures :D

mhhf commented 8 years ago

Awesome :D Once it get merged into etherumjs-vm i'll build it into dapple immediately!