Closed rainbreak closed 8 years ago
@mhhf: I still can't work out these deployment failures. There seems to be some relation to test contract size, but it isn't at all direct.
Some data points:
ForwardSplittingTest
: dapple test -r forwardsplittingtest
fails to deploy, dapple test
is okClaimTest
: dapple test -r claimtest
deploys and passes, dapple test
fails to deployBidTest
: dapple test -r bidtest
fails to deploy, dapple test
fails to deployReverseGasTest
: dapple test -r reversegastest
deploys and passes, dapple test
fails to deployIt feels like a race condition, but ¯_(ツ)_/¯
@mhhf: https://github.com/ethereumjs/ethereumjs-vm/pull/91 fixes the deployment failures :D
Awesome :D Once it get merged into etherumjs-vm i'll build it into dapple immediately!
Fixes #57, #55.
TODO:
The latter appears to be dapple / solidity issue, probably exposed by the largish setUp method in the auction tests (which creates several new contracts).
The global setUp method could be replaced by some use of dapple script - this would set the initial chain state from which each unit test would fork from.