makerdao / token-auction

Continuous Splitting Token Auction
GNU Affero General Public License v3.0
21 stars 21 forks source link

Not lowering "auction.sell_amount" on bidding in reverse auctions #70

Closed ghost closed 7 years ago

ghost commented 7 years ago

I didn't find any good reason to decrease the sell_amount for reverse auctions, but it's much more convenient if you can see the original sell amount (ie. the starting bid) in the frontend. Despite that, this way it is consistent with other auction types.

Couldn't find any side effects, all tests are passing as well.