Gas optimizations and test improvements

makerdao / univ2-lp-oracle

GNU Affero General Public License v3.0

23 stars 13 forks source link

Closed kmbarry1 closed 3 years ago

kmbarry1 commented 3 years ago

Does a few things:

overwrites storage slots of on-chain contracts that are pulled in with fixed values to allow for repeatable tests that aren't broken by mainnet state evolution
improves the testing for seek
gas optimizes the implementation of seek; this makes seek about 1.6% cheaper

There's a lot more that can be done on the tests now that they're deterministic, but I think the diff here is big enough for one PR.

kmbarry1 commented 3 years ago

comments addressed

NiklasKunkel commented 3 years ago

This looks good to me and I think is ready to be merged. Any objections @brianmcmichael ?