makerdao / univ2-lp-oracle

GNU Affero General Public License v3.0
23 stars 13 forks source link

CVF-13: Index some creation parameters #40

Closed kmbarry1 closed 3 years ago

kmbarry1 commented 3 years ago

IMO tok0 and tok1 make the most sense to index, although I could possibly see an argument for sender--but I generally expect that to be low cardinality, unless other teams besides Maker start using this exact same oracle code. I don't think orcl is very interesting to index if tok0 and tok1 are indexed. orb0 and orb1 are probably more interesting to have as data to check if they are what is expected based on tok0 and tok1. I think indexing wat likely becomes redundant as well if tok0 and tok1 are indexed.