search

makerdao / univ2-lp-oracle

GNU Affero General Public License v3.0
23 stars 13 forks source link

Standardize with regular osm and add void #53

Open gbalabasquer opened 2 years ago

gbalabasquer commented 2 years ago

cc @NiklasKunkel

gbalabasquer commented 2 years ago

Just a comment, I had to adjust the maximum gas usage in a couple of tests because it was above the limits. Not really sure where those limits came from and why the difference now. Probably changes in the gas prices from some opcodes during this time.

gbalabasquer commented 2 years ago

@iamchrissmith already got the 2 approvals, but if you can also give yours would be great. Then I'll wait for @NiklasKunkel and proceed to merge.

gbalabasquer commented 2 years ago

@NiklasKunkel @madumas need some of you for a final approval and then we will get it merged. Thanks!

gbalabasquer commented 2 years ago

cc James @jar-o