kmbarry1 review comments

makerdao / vote-delegate

GNU Affero General Public License v3.0

37 stars 29 forks source link

kmbarry1 review comments #2

Closed kmbarry1 closed 3 years ago

kmbarry1 commented 3 years ago

We usually name mappings after their values, not their keys, and we usually use the singular, so I'd suggest renaming delegators to stake or something similar.

Other than that...just the ongoing concern about delegation being potentially everlasting, which #1 is addressing.

gbalabasquer commented 3 years ago

This was fixed in this PR: https://github.com/makerdao/vote-delegate/pull/3