[dss-bridge] modularity

makerdao / xdomain

GNU Affero General Public License v3.0

19 stars 9 forks source link

[dss-bridge] modularity #57

Open maciejka opened 2 years ago

maciejka commented 2 years ago

It seems dss-bridge contains three related units of functionality:

l2 vault engine with preminted DAI management
simple DAI bridge
teleport Do we consider this relation strong enough to combine everything into a single package instead of having modules per unit of functionality?

hexonaut commented 2 years ago

I would be okay with splitting these into separate, inherited contracts. IE DomainHostMCD, DomainHostDaiBridge and DomainHostTeleport or similar.

Alternatively functionality could be provided via a library instead of inheritance as we discussed in the offsite.