makerdiary / nrf52840-mdk-usb-dongle

An open-source, small and low-cost USB Dongle that supports Bluetooth 5.4, Bluetooth mesh, Thread, Zigbee, 802.15.4, ANT and 2.4 GHz proprietary protocols
https://wiki.makerdiary.com/nrf52840-mdk-usb-dongle/
Apache License 2.0
301 stars 79 forks source link

OpenSK compatible? #16

Closed tmikaeld closed 4 years ago

tmikaeld commented 4 years ago

Would this work with https://github.com/google/OpenSK ?

EDIT: Also mentioned here https://github.com/google/OpenSK/issues/3

caizelin commented 4 years ago

Would this work with https://github.com/google/OpenSK ?

EDIT: Also mentioned here google/OpenSK#3

Hi there, You are really up-to-date! Yes, the hardware is compatible and we are working in process to adapt the LEDs and button. @kfihihc @xiongyihui

tmikaeld commented 4 years ago

Hello @caizelin!

Superb! I can't wait to order these devices and try it out.

Thanks for doing this, FIDO2 really needs to get out there :)

xiongyihui commented 4 years ago

@tmikaeld You can follow Get Started with OpenSK guide to use FIDO2 with nRF52840 MDK USB Dongle

Raboo commented 4 years ago

Great news! I installed OpenSK according to your Getting Started with OpenSK guide and wanted to report my results. Currently it only partially works. It works on my MacOS device (which I used to install OpenSK). It did not work on my Windows 10 device nor on my Android device (using same USB-C to USB dongle I used on Mac).

Also am I correct that the dongle has a antenna that can be used with NFC? I also tried NFC with my phone, that didn't work either, it did not find any NFC device.

xiongyihui commented 4 years ago

@Raboo It's weird. It works on my Windows 10 (version 1909)

The dongle has two NFC pins, but NFC is not enabled at OpenSK yet

tmikaeld commented 4 years ago

@Raboo Should work in latest Win10, I've had issues with older version when using Yubikey as well. Also, Windows Hello is super-buggy in general....

Raboo commented 4 years ago

I have Windows 10 Pro, Version 1909. https://webauthn.io/ looks like this when trying to login (registering seems to work). bild

I also tested https://demo.yubico.com/webauthn-technical/registration and I wasn't able to login from my registration that I did on my Mac, I had to register again, then it worked. I don't know how long the registration is valid. It went some hours between register on Mac and login on Windows.

tmikaeld commented 4 years ago

These tests don't use any server, it only stores the registration locally so you can test it. So re-registration is always needed.

EDIT: The Windows error message is very stupid, it should say "The App doesn't know this key, please try another one or register the security key"

Raboo commented 4 years ago

I tried again, with Firefox, Edge, Chrome. All of them have problems on webauthn.io. So I need to register the security key somehow?

Raboo commented 4 years ago

The dongle has two NFC pins, but NFC is not enabled at OpenSK yet

A bit off topic here... Maybe I should move this question to a new issue? I'm a bit novice when it comes to this. Those pins need to be connected to the onboard antenna or I need to buy a NFC antenna and solder it? Also would a battery or a capacitor be required for this then, like mentioned here https://github.com/google/OpenSK/issues/15#issuecomment-582645999?

tmikaeld commented 4 years ago

I'll close this issue, since it's now clearly compatible and working 👍

Thanks @xiongyihui for looking at it so quickly!

tmikaeld commented 4 years ago

Just got the device and programmed it in a few easy steps, works flawlessly 👍