search

makerforgetech / modular-biped

An open source framework for creating a bipedal modular companion robot.
https://www.instagram.com/dan.makes.things/
GNU General Public License v3.0
271 stars 41 forks source link

RobustSerial ->NeoPixel #79

Closed SentryCoderDev closed 7 months ago

SentryCoderDev commented 7 months ago

Hello, I made a few tweaks to your current Neopixel code. I wonder if you have a chance to check it out. My purpose in the code was to transfer the colors and animations to Arduino and drive the neopixel with Arduino. Frankly, I am very confused and I ask for your help.

I used the v2 branch for the changes, it is not finished yet, I need to edit the Arduino sketch and robust serial.

danic85 commented 7 months ago

I can see what you're going for, the serial command is the only change needed here to enable your functionality, and you should be able to toggle the 'mode' to be serial, gpio or i2c.

I don't mind including this functionality again in the new neopixel module I'm making for viam, but I can't merge this until it is compatible with the other existing modes, rather than replacing them.

SentryCoderDev commented 7 months ago

oh I understand what you mean @danic85 , I wrote the code to work alone (directly) without I2C or GPIO (to understand how it will work). I will return it to its previous state when the warehouse draft merge request.

SentryCoderDev commented 7 months ago

We currently have the opportunity to choose configuration for neopixel in config.json but arduino it's not completed yet.

We need to update the case LED: definition in the Arduino code according to v4.

SentryCoderDev commented 7 months ago

I can see what you're going for, the serial command is the only change needed here to enable your functionality, and you should be able to toggle the 'mode' to be serial, gpio or i2c.

I don't mind including this functionality again in the new neopixel module I'm making for viam, but I can't merge this until it is compatible with the other existing modes, rather than replacing them.

Uh, do I need to set PR to Viam branch instead of V4, if I don't misunderstand?

danic85 commented 7 months ago

I can see what you're going for, the serial command is the only change needed here to enable your functionality, and you should be able to toggle the 'mode' to be serial, gpio or i2c. I don't mind including this functionality again in the new neopixel module I'm making for viam, but I can't merge this until it is compatible with the other existing modes, rather than replacing them.

Uh, do I need to set PR to Viam branch instead of V4, if I don't misunderstand? No, I will add changes to the viam modules. They aren't part of the Viam branch. I will be closing that branch soon.